[INFO] updating cached repository ward/rust-chronorace [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ward/rust-chronorace [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ward/rust-chronorace" "work/ex/clippy-test-run/sources/stable/gh/ward/rust-chronorace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ward/rust-chronorace'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ward/rust-chronorace" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ward/rust-chronorace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ward/rust-chronorace'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e1e5f7eb3c12bab2f2d313d759fdee3b76f7a354 [INFO] sha for GitHub repo ward/rust-chronorace: e1e5f7eb3c12bab2f2d313d759fdee3b76f7a354 [INFO] validating manifest of ward/rust-chronorace on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ward/rust-chronorace on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ward/rust-chronorace [INFO] finished frobbing ward/rust-chronorace [INFO] frobbed toml for ward/rust-chronorace written to work/ex/clippy-test-run/sources/stable/gh/ward/rust-chronorace/Cargo.toml [INFO] started frobbing ward/rust-chronorace [INFO] finished frobbing ward/rust-chronorace [INFO] frobbed toml for ward/rust-chronorace written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ward/rust-chronorace/Cargo.toml [INFO] crate ward/rust-chronorace has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ward/rust-chronorace against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ward/rust-chronorace:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98f656ff4375c697265486526b3a56cd934d71437c273ddb53712f6338942e5a [INFO] running `"docker" "start" "-a" "98f656ff4375c697265486526b3a56cd934d71437c273ddb53712f6338942e5a"` [INFO] [stderr] Checking futures v0.1.24 [INFO] [stderr] Compiling rand_core v0.2.1 [INFO] [stderr] Compiling unicase v2.1.0 [INFO] [stderr] Checking encoding_rs v0.8.8 [INFO] [stderr] Compiling openssl-sys v0.9.36 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking url v1.2.3 [INFO] [stderr] Checking serde_json v1.0.31 [INFO] [stderr] Compiling unicase v1.4.0 [INFO] [stderr] Checking time v0.1.35 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking phf_shared v0.7.23 [INFO] [stderr] Compiling rand v0.5.5 [INFO] [stderr] Checking phf v0.7.23 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Compiling openssl v0.10.12 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Checking mime v0.3.9 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Checking tokio-executor v0.1.5 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking tokio-current-thread v0.1.3 [INFO] [stderr] Checking tokio-timer v0.2.7 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking rust-chronorace v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/chronorace.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | / let mut locationidx = 6; [INFO] [stderr] 97 | | if interestingcolumns.len() == 8 { [INFO] [stderr] 98 | | let mut chiptime = strip_tags(cells[interestingcolumns[5]].to_string()); [INFO] [stderr] 99 | | if chiptime.chars().filter(|&c| c == ':').count() == 1 { [INFO] [stderr] ... | [INFO] [stderr] 107 | | locationidx = 7; [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let locationidx = if interestingcolumns.len() == 8 { ..; 7 } else { 6 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/chronorace.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | / let mut locationidx = 6; [INFO] [stderr] 97 | | if interestingcolumns.len() == 8 { [INFO] [stderr] 98 | | let mut chiptime = strip_tags(cells[interestingcolumns[5]].to_string()); [INFO] [stderr] 99 | | if chiptime.chars().filter(|&c| c == ':').count() == 1 { [INFO] [stderr] ... | [INFO] [stderr] 107 | | locationidx = 7; [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let locationidx = if interestingcolumns.len() == 8 { ..; 7 } else { 6 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/chronorace.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | let ref athlete_rutten = athletes[347]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^----------------- help: try: `let athlete_rutten = &athletes[347];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 41.62s [INFO] running `"docker" "inspect" "98f656ff4375c697265486526b3a56cd934d71437c273ddb53712f6338942e5a"` [INFO] running `"docker" "rm" "-f" "98f656ff4375c697265486526b3a56cd934d71437c273ddb53712f6338942e5a"` [INFO] [stdout] 98f656ff4375c697265486526b3a56cd934d71437c273ddb53712f6338942e5a