[INFO] updating cached repository walfie/rs-streams-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/walfie/rs-streams-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/walfie/rs-streams-test" "work/ex/clippy-test-run/sources/stable/gh/walfie/rs-streams-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/walfie/rs-streams-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/walfie/rs-streams-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/walfie/rs-streams-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/walfie/rs-streams-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1bf0ab52883491bdbc7197f348862811bf024f5b [INFO] sha for GitHub repo walfie/rs-streams-test: 1bf0ab52883491bdbc7197f348862811bf024f5b [INFO] validating manifest of walfie/rs-streams-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of walfie/rs-streams-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing walfie/rs-streams-test [INFO] finished frobbing walfie/rs-streams-test [INFO] frobbed toml for walfie/rs-streams-test written to work/ex/clippy-test-run/sources/stable/gh/walfie/rs-streams-test/Cargo.toml [INFO] started frobbing walfie/rs-streams-test [INFO] finished frobbing walfie/rs-streams-test [INFO] frobbed toml for walfie/rs-streams-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/walfie/rs-streams-test/Cargo.toml [INFO] crate walfie/rs-streams-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting walfie/rs-streams-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/walfie/rs-streams-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e6318163376f863be7ef72ec2b503971add3a3a08e0a1dcc71fd32ae0c7798a8 [INFO] running `"docker" "start" "-a" "e6318163376f863be7ef72ec2b503971add3a3a08e0a1dcc71fd32ae0c7798a8"` [INFO] [stderr] Checking net2 v0.2.29 [INFO] [stderr] Checking mio v0.6.7 [INFO] [stderr] Checking tokio-core v0.1.7 [INFO] [stderr] Checking streams v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/group_by.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/group_by.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | key_selector: key_selector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key_selector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/group_by.rs:69:29 [INFO] [stderr] | [INFO] [stderr] 69 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/group_by.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/group_by.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | key_selector: key_selector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key_selector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/group_by.rs:69:29 [INFO] [stderr] | [INFO] [stderr] 69 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: function is never used: `new` [INFO] [stderr] --> src/broadcast.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new(messages: MsgStream) [INFO] [stderr] 9 | | -> (SubscriptionManager, [INFO] [stderr] 10 | | Broadcast>) [INFO] [stderr] 11 | | where [INFO] [stderr] ... | [INFO] [stderr] 29 | | (manager, broadcast) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `EventStream` [INFO] [stderr] --> src/broadcast.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / pub struct EventStream( [INFO] [stderr] 34 | | Select>, [INFO] [stderr] 35 | | Map Event>> [INFO] [stderr] 36 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `subscribe` [INFO] [stderr] --> src/broadcast.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / fn subscribe [INFO] [stderr] 57 | | ( [INFO] [stderr] 58 | | &self, [INFO] [stderr] 59 | | id: SubId, [INFO] [stderr] ... | [INFO] [stderr] 73 | | ) [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Subscribe` [INFO] [stderr] --> src/broadcast.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | Subscribe { id: SubId, subscriber: Sub }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Message` [INFO] [stderr] --> src/broadcast.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | Message(Msg), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Broadcast` [INFO] [stderr] --> src/broadcast.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | pub struct Broadcast { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Backlog` [INFO] [stderr] --> src/backlog.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | struct Backlog { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `with_capacity` [INFO] [stderr] --> src/backlog.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | fn with_capacity(capacity: usize) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `insert` [INFO] [stderr] --> src/backlog.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | fn insert(&mut self, item: T) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `snapshot` [INFO] [stderr] --> src/backlog.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | fn snapshot(&self) -> Arc> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/broadcast.rs:9:8 [INFO] [stderr] | [INFO] [stderr] 9 | -> (SubscriptionManager, [INFO] [stderr] | ________^ [INFO] [stderr] 10 | | Broadcast>) [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/broadcast.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / Select>, [INFO] [stderr] 35 | | Map Event>> [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/broadcast.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | ) -> Result, mpsc::SendError>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/backlog.rs:52:32 [INFO] [stderr] | [INFO] [stderr] 52 | items.extend(right.into_iter().cloned()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/backlog.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | items.extend(left.into_iter().cloned()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `sub` [INFO] [stderr] --> src/broadcast.rs:237:25 [INFO] [stderr] | [INFO] [stderr] 237 | let sub = manager.subscribe(1, tx); [INFO] [stderr] | ^^^ help: consider using `_sub` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/broadcast.rs:9:8 [INFO] [stderr] | [INFO] [stderr] 9 | -> (SubscriptionManager, [INFO] [stderr] | ________^ [INFO] [stderr] 10 | | Broadcast>) [INFO] [stderr] | |_______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/broadcast.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / Select>, [INFO] [stderr] 35 | | Map Event>> [INFO] [stderr] | |______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/broadcast.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | ) -> Result, mpsc::SendError>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/backlog.rs:52:32 [INFO] [stderr] | [INFO] [stderr] 52 | items.extend(right.into_iter().cloned()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/backlog.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | items.extend(left.into_iter().cloned()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.72s [INFO] running `"docker" "inspect" "e6318163376f863be7ef72ec2b503971add3a3a08e0a1dcc71fd32ae0c7798a8"` [INFO] running `"docker" "rm" "-f" "e6318163376f863be7ef72ec2b503971add3a3a08e0a1dcc71fd32ae0c7798a8"` [INFO] [stdout] e6318163376f863be7ef72ec2b503971add3a3a08e0a1dcc71fd32ae0c7798a8