[INFO] updating cached repository walfie/elmlike [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/walfie/elmlike [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/walfie/elmlike" "work/ex/clippy-test-run/sources/stable/gh/walfie/elmlike"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/walfie/elmlike'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/walfie/elmlike" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/walfie/elmlike"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/walfie/elmlike'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c1a3e7019d56961834a26abca2e44751c6ad47c5 [INFO] sha for GitHub repo walfie/elmlike: c1a3e7019d56961834a26abca2e44751c6ad47c5 [INFO] validating manifest of walfie/elmlike on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of walfie/elmlike on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing walfie/elmlike [INFO] finished frobbing walfie/elmlike [INFO] frobbed toml for walfie/elmlike written to work/ex/clippy-test-run/sources/stable/gh/walfie/elmlike/Cargo.toml [INFO] started frobbing walfie/elmlike [INFO] finished frobbing walfie/elmlike [INFO] frobbed toml for walfie/elmlike written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/walfie/elmlike/Cargo.toml [INFO] crate walfie/elmlike has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting walfie/elmlike against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/walfie/elmlike:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e0bdbbbb9f6d0761d6902488a2003aea6867b17387079ad2fc3732518b17f053 [INFO] running `"docker" "start" "-a" "e0bdbbbb9f6d0761d6902488a2003aea6867b17387079ad2fc3732518b17f053"` [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Checking mio v0.6.13 [INFO] [stderr] Checking tokio-io v0.1.5 [INFO] [stderr] Checking tokio v0.1.1 [INFO] [stderr] Checking elmlike v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/platform/mailbox.rs:41:56 [INFO] [stderr] | [INFO] [stderr] 41 | let send_stream = s.for_each(move |item: T| Ok(tx.send(item))); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 41 | let send_stream = s.for_each(move |item: T| Ok(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/platform/mod.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / loop { [INFO] [stderr] 77 | | match self.cmd_inbox.poll()? { [INFO] [stderr] 78 | | Async::Ready(Some(cmd)) => { [INFO] [stderr] 79 | | self.effect_manager.handle(cmd, &self.msg_outbox); [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ help: try: `while let Async::Ready(Some(cmd)) = self.cmd_inbox.poll()? { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/platform/mailbox.rs:41:56 [INFO] [stderr] | [INFO] [stderr] 41 | let send_stream = s.for_each(move |item: T| Ok(tx.send(item))); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 41 | let send_stream = s.for_each(move |item: T| Ok(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/platform/mod.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / loop { [INFO] [stderr] 77 | | match self.cmd_inbox.poll()? { [INFO] [stderr] 78 | | Async::Ready(Some(cmd)) => { [INFO] [stderr] 79 | | self.effect_manager.handle(cmd, &self.msg_outbox); [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ help: try: `while let Async::Ready(Some(cmd)) = self.cmd_inbox.poll()? { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.84s [INFO] running `"docker" "inspect" "e0bdbbbb9f6d0761d6902488a2003aea6867b17387079ad2fc3732518b17f053"` [INFO] running `"docker" "rm" "-f" "e0bdbbbb9f6d0761d6902488a2003aea6867b17387079ad2fc3732518b17f053"` [INFO] [stdout] e0bdbbbb9f6d0761d6902488a2003aea6867b17387079ad2fc3732518b17f053