[INFO] updating cached repository wahn/rs_partio [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wahn/rs_partio [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wahn/rs_partio" "work/ex/clippy-test-run/sources/stable/gh/wahn/rs_partio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wahn/rs_partio'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wahn/rs_partio" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wahn/rs_partio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wahn/rs_partio'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2103574e460c48c978eb1a71ed42f25e561471a5 [INFO] sha for GitHub repo wahn/rs_partio: 2103574e460c48c978eb1a71ed42f25e561471a5 [INFO] validating manifest of wahn/rs_partio on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wahn/rs_partio on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wahn/rs_partio [INFO] finished frobbing wahn/rs_partio [INFO] frobbed toml for wahn/rs_partio written to work/ex/clippy-test-run/sources/stable/gh/wahn/rs_partio/Cargo.toml [INFO] started frobbing wahn/rs_partio [INFO] finished frobbing wahn/rs_partio [INFO] frobbed toml for wahn/rs_partio written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wahn/rs_partio/Cargo.toml [INFO] crate wahn/rs_partio has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wahn/rs_partio against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wahn/rs_partio:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 278c63bac834811603dbffa08cf1400f1e06c8d3bcf6bdcfaeac15b9beb9b795 [INFO] running `"docker" "start" "-a" "278c63bac834811603dbffa08cf1400f1e06c8d3bcf6bdcfaeac15b9beb9b795"` [INFO] [stderr] Checking partio v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | ptype: ptype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ptype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | attribute_data: attribute_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | name_to_attribute: name_to_attribute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_to_attribute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:434:13 [INFO] [stderr] | [INFO] [stderr] 434 | attribute_strides: attribute_strides, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute_strides` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:435:13 [INFO] [stderr] | [INFO] [stderr] 435 | fixed_attributes: fixed_attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fixed_attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | ptype: ptype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ptype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:431:13 [INFO] [stderr] | [INFO] [stderr] 431 | attribute_data: attribute_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:432:13 [INFO] [stderr] | [INFO] [stderr] 432 | name_to_attribute: name_to_attribute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_to_attribute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | attributes: attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:434:13 [INFO] [stderr] | [INFO] [stderr] 434 | attribute_strides: attribute_strides, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute_strides` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:435:13 [INFO] [stderr] | [INFO] [stderr] 435 | fixed_attributes: fixed_attributes, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fixed_attributes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:286:46 [INFO] [stderr] | [INFO] [stderr] 286 | let asize: u16 = attr.count as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(attr.count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:409:63 [INFO] [stderr] | [INFO] [stderr] 409 | .extend_from_slice(std::slice::from_raw_parts(std::mem::transmute(data), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data as *const T as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ParticlesSimpleBuilder` [INFO] [stderr] --> src/lib.rs:419:5 [INFO] [stderr] | [INFO] [stderr] 419 | / pub fn new() -> ParticlesSimpleBuilder { [INFO] [stderr] 420 | | ParticlesSimpleBuilder {} [INFO] [stderr] 421 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 415 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:286:46 [INFO] [stderr] | [INFO] [stderr] 286 | let asize: u16 = attr.count as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(attr.count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:409:63 [INFO] [stderr] | [INFO] [stderr] 409 | .extend_from_slice(std::slice::from_raw_parts(std::mem::transmute(data), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data as *const T as *const u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ParticlesSimpleBuilder` [INFO] [stderr] --> src/lib.rs:419:5 [INFO] [stderr] | [INFO] [stderr] 419 | / pub fn new() -> ParticlesSimpleBuilder { [INFO] [stderr] 420 | | ParticlesSimpleBuilder {} [INFO] [stderr] 421 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 415 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> examples/test_save_load.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | let mut foo: partio::ParticlesSimple = builder.finalize(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> examples/test_save_load.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let foo: partio::ParticlesSimple = make_data(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "278c63bac834811603dbffa08cf1400f1e06c8d3bcf6bdcfaeac15b9beb9b795"` [INFO] running `"docker" "rm" "-f" "278c63bac834811603dbffa08cf1400f1e06c8d3bcf6bdcfaeac15b9beb9b795"` [INFO] [stdout] 278c63bac834811603dbffa08cf1400f1e06c8d3bcf6bdcfaeac15b9beb9b795