[INFO] updating cached repository wafflespeanut/free-fall [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wafflespeanut/free-fall [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wafflespeanut/free-fall" "work/ex/clippy-test-run/sources/stable/gh/wafflespeanut/free-fall"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wafflespeanut/free-fall'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wafflespeanut/free-fall" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wafflespeanut/free-fall"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wafflespeanut/free-fall'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 157d70ffe5b23162d91632e708689861f11a5a23 [INFO] sha for GitHub repo wafflespeanut/free-fall: 157d70ffe5b23162d91632e708689861f11a5a23 [INFO] validating manifest of wafflespeanut/free-fall on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wafflespeanut/free-fall on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wafflespeanut/free-fall [INFO] finished frobbing wafflespeanut/free-fall [INFO] frobbed toml for wafflespeanut/free-fall written to work/ex/clippy-test-run/sources/stable/gh/wafflespeanut/free-fall/Cargo.toml [INFO] started frobbing wafflespeanut/free-fall [INFO] finished frobbing wafflespeanut/free-fall [INFO] frobbed toml for wafflespeanut/free-fall written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wafflespeanut/free-fall/Cargo.toml [INFO] crate wafflespeanut/free-fall has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wafflespeanut/free-fall against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wafflespeanut/free-fall:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cded86c56619e380c25a874323501e7d20bbeaadb4a5b2dddffebd34dda825d8 [INFO] running `"docker" "start" "-a" "cded86c56619e380c25a874323501e7d20bbeaadb4a5b2dddffebd34dda825d8"` [INFO] [stderr] Checking winapi v0.2.2 [INFO] [stderr] Checking libc v0.1.10 [INFO] [stderr] Checking libc v0.2.17 [INFO] [stderr] Compiling advapi32-sys v0.1.2 [INFO] [stderr] Compiling kernel32-sys v0.1.4 [INFO] [stderr] Checking time v0.1.32 [INFO] [stderr] Checking rand v0.3.10 [INFO] [stderr] Checking free-fall v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprites.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | size: size [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprites.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | x_pos: x_pos, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `x_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprites.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | poll_timeout: poll_timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `poll_timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprites.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | jumper: jumper, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `jumper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprites.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | size: size [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprites.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | x_pos: x_pos, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `x_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprites.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | poll_timeout: poll_timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `poll_timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sprites.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | jumper: jumper, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `jumper` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/keyevents.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | 4283163 => Ok(Key::Up), [INFO] [stderr] | ^^^^^^^ help: consider: `4_283_163` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/keyevents.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | 4348699 => Ok(Key::Down), [INFO] [stderr] | ^^^^^^^ help: consider: `4_348_699` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/keyevents.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | 4414235 => Ok(Key::Right), [INFO] [stderr] | ^^^^^^^ help: consider: `4_414_235` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/keyevents.rs:123:17 [INFO] [stderr] | [INFO] [stderr] 123 | 4479771 => Ok(Key::Left), [INFO] [stderr] | ^^^^^^^ help: consider: `4_479_771` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:59:94 [INFO] [stderr] | [INFO] [stderr] 59 | poll_timeout_ms = game.poll_timeout - ((time_since_last_ns / 1000000) as c_uint); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/keyevents.rs:120:17 [INFO] [stderr] | [INFO] [stderr] 120 | 4283163 => Ok(Key::Up), [INFO] [stderr] | ^^^^^^^ help: consider: `4_283_163` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/keyevents.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | 4348699 => Ok(Key::Down), [INFO] [stderr] | ^^^^^^^ help: consider: `4_348_699` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/keyevents.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | 4414235 => Ok(Key::Right), [INFO] [stderr] | ^^^^^^^ help: consider: `4_414_235` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/keyevents.rs:123:17 [INFO] [stderr] | [INFO] [stderr] 123 | 4479771 => Ok(Key::Left), [INFO] [stderr] | ^^^^^^^ help: consider: `4_479_771` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:59:94 [INFO] [stderr] | [INFO] [stderr] 59 | poll_timeout_ms = game.poll_timeout - ((time_since_last_ns / 1000000) as c_uint); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprites.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | rng.choose(&[true, false, jumper_side]).unwrap().clone() // increase the chance of hitting the jumper [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*rng.choose(&[true, false, jumper_side]).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/sprites.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | rng.choose(&[true, false, jumper_side]).unwrap().clone() // increase the chance of hitting the jumper [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*rng.choose(&[true, false, jumper_side]).unwrap()` [INFO] [stderr] | [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/sprites.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | let x_pos: usize = match left_side { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 89 | | true => rng.gen_range(1, full_width / 3) - 1, [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] 90 | | false => full_width - x_size - rng.gen_range(1, full_width / 3) - 1, [INFO] [stderr] 91 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if left_side { rng.gen_range(1, full_width / 3) - 1 } else { full_width - x_size - rng.gen_range(1, full_width / 3) - 1 }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/sprites.rs:88:28 [INFO] [stderr] | [INFO] [stderr] 88 | let x_pos: usize = match left_side { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 89 | | true => rng.gen_range(1, full_width / 3) - 1, [INFO] [stderr] 90 | | false => full_width - x_size - rng.gen_range(1, full_width / 3) - 1, [INFO] [stderr] 91 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if left_side { rng.gen_range(1, full_width / 3) - 1 } else { full_width - x_size - rng.gen_range(1, full_width / 3) - 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/sprites.rs:182:23 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn is_running(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/sprites.rs:182:23 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn is_running(&mut self) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `frame` [INFO] [stderr] --> src/sprites.rs:254:22 [INFO] [stderr] | [INFO] [stderr] 254 | for i in y_pos..(y_pos + body_height) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 254 | for (i, ) in frame.iter_mut().enumerate().skip(y_pos).take(body_height) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/sprites.rs:261:38 [INFO] [stderr] | [INFO] [stderr] 261 | self.collision = match ignore_collision { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 262 | | true => None, [INFO] [stderr] 263 | | false => collision(&line[x_pos..x_pos + body_width]), [INFO] [stderr] 264 | | }; [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if ignore_collision { None } else { collision(&line[x_pos..x_pos + body_width]) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `frame` [INFO] [stderr] --> src/sprites.rs:254:22 [INFO] [stderr] | [INFO] [stderr] 254 | for i in y_pos..(y_pos + body_height) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 254 | for (i, ) in frame.iter_mut().enumerate().skip(y_pos).take(body_height) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/sprites.rs:261:38 [INFO] [stderr] | [INFO] [stderr] 261 | self.collision = match ignore_collision { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 262 | | true => None, [INFO] [stderr] 263 | | false => collision(&line[x_pos..x_pos + body_width]), [INFO] [stderr] 264 | | }; [INFO] [stderr] | |_____________________^ help: consider using an if/else expression: `if ignore_collision { None } else { collision(&line[x_pos..x_pos + body_width]) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.44s [INFO] running `"docker" "inspect" "cded86c56619e380c25a874323501e7d20bbeaadb4a5b2dddffebd34dda825d8"` [INFO] running `"docker" "rm" "-f" "cded86c56619e380c25a874323501e7d20bbeaadb4a5b2dddffebd34dda825d8"` [INFO] [stdout] cded86c56619e380c25a874323501e7d20bbeaadb4a5b2dddffebd34dda825d8