[INFO] updating cached repository wKLV/game-board [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/wKLV/game-board [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/wKLV/game-board" "work/ex/clippy-test-run/sources/stable/gh/wKLV/game-board"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/wKLV/game-board'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/wKLV/game-board" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wKLV/game-board"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wKLV/game-board'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f0b6f7b08dd8579fb2f5ecd0b60e573c205efd2 [INFO] sha for GitHub repo wKLV/game-board: 7f0b6f7b08dd8579fb2f5ecd0b60e573c205efd2 [INFO] validating manifest of wKLV/game-board on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of wKLV/game-board on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing wKLV/game-board [INFO] finished frobbing wKLV/game-board [INFO] frobbed toml for wKLV/game-board written to work/ex/clippy-test-run/sources/stable/gh/wKLV/game-board/Cargo.toml [INFO] started frobbing wKLV/game-board [INFO] finished frobbing wKLV/game-board [INFO] frobbed toml for wKLV/game-board written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/wKLV/game-board/Cargo.toml [INFO] crate wKLV/game-board has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting wKLV/game-board against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/wKLV/game-board:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c3d456196c46e392569740bf296ef78f74281180633be451a24ac57bad67dd5 [INFO] running `"docker" "start" "-a" "9c3d456196c46e392569740bf296ef78f74281180633be451a24ac57bad67dd5"` [INFO] [stderr] Compiling libc v0.2.17 [INFO] [stderr] Compiling phf_shared v0.7.19 [INFO] [stderr] Compiling serde v0.8.17 [INFO] [stderr] Compiling itoa v0.1.1 [INFO] [stderr] Compiling num-traits v0.1.36 [INFO] [stderr] Compiling dtoa v0.2.2 [INFO] [stderr] Compiling gcc v0.3.38 [INFO] [stderr] Compiling log v0.3.6 [INFO] [stderr] Checking rustc-demangle v0.1.2 [INFO] [stderr] Checking smallvec v0.1.8 [INFO] [stderr] Compiling xml-rs v0.3.4 [INFO] [stderr] Compiling x11-dl v2.11.0 [INFO] [stderr] Checking num-integer v0.1.32 [INFO] [stderr] Compiling phf v0.7.19 [INFO] [stderr] Compiling rand v0.3.14 [INFO] [stderr] Checking gif v0.9.0 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking num_cpus v1.1.0 [INFO] [stderr] Compiling tempfile v2.1.4 [INFO] [stderr] Compiling miniz-sys v0.1.7 [INFO] [stderr] Compiling backtrace-sys v0.1.4 [INFO] [stderr] Checking num-iter v0.1.32 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking memmap v0.2.3 [INFO] [stderr] Checking enum_primitive v0.1.0 [INFO] [stderr] Compiling phf_generator v0.7.19 [INFO] [stderr] Checking rayon v0.5.0 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Compiling phf_codegen v0.7.19 [INFO] [stderr] Checking flate2 v0.2.14 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Compiling wayland-scanner v0.5.11 [INFO] [stderr] Compiling gl_generator v0.5.2 [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking jpeg-decoder v0.1.8 [INFO] [stderr] Compiling wayland-client v0.5.12 [INFO] [stderr] Compiling serde_json v0.8.3 [INFO] [stderr] Compiling glutin v0.6.2 [INFO] [stderr] Compiling glium v0.15.0 [INFO] [stderr] Checking image v0.10.3 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking tt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:187:28 [INFO] [stderr] | [INFO] [stderr] 187 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:188:28 [INFO] [stderr] | [INFO] [stderr] 188 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:189:28 [INFO] [stderr] | [INFO] [stderr] 189 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:194:19 [INFO] [stderr] | [INFO] [stderr] 194 | UIState { display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:195:24 [INFO] [stderr] | [INFO] [stderr] 195 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:196:24 [INFO] [stderr] | [INFO] [stderr] 196 | entity_template: entity_template, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_template` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:187:28 [INFO] [stderr] | [INFO] [stderr] 187 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:188:28 [INFO] [stderr] | [INFO] [stderr] 188 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:189:28 [INFO] [stderr] | [INFO] [stderr] 189 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:194:19 [INFO] [stderr] | [INFO] [stderr] 194 | UIState { display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:195:24 [INFO] [stderr] | [INFO] [stderr] 195 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/io.rs:196:24 [INFO] [stderr] | [INFO] [stderr] 196 | entity_template: entity_template, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `entity_template` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/io.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/io.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | .with_title(format!("tt")) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"tt".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io.rs:238:18 [INFO] [stderr] | [INFO] [stderr] 238 | fn as_canvas(&self) -> (f32, f32) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn mapT>(&self, f:F)->T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/io.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | .with_title(format!("tt")) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"tt".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/io.rs:238:18 [INFO] [stderr] | [INFO] [stderr] 238 | fn as_canvas(&self) -> (f32, f32) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn mapT>(&self, f:F)->T { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 15s [INFO] running `"docker" "inspect" "9c3d456196c46e392569740bf296ef78f74281180633be451a24ac57bad67dd5"` [INFO] running `"docker" "rm" "-f" "9c3d456196c46e392569740bf296ef78f74281180633be451a24ac57bad67dd5"` [INFO] [stdout] 9c3d456196c46e392569740bf296ef78f74281180633be451a24ac57bad67dd5