[INFO] updating cached repository w-k-s/BrainfuckInterpreter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/w-k-s/BrainfuckInterpreter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/w-k-s/BrainfuckInterpreter" "work/ex/clippy-test-run/sources/stable/gh/w-k-s/BrainfuckInterpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/w-k-s/BrainfuckInterpreter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/w-k-s/BrainfuckInterpreter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/w-k-s/BrainfuckInterpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/w-k-s/BrainfuckInterpreter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 310c94f4292ca1efad6213c7754cf0967a5a4a5c [INFO] sha for GitHub repo w-k-s/BrainfuckInterpreter: 310c94f4292ca1efad6213c7754cf0967a5a4a5c [INFO] validating manifest of w-k-s/BrainfuckInterpreter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of w-k-s/BrainfuckInterpreter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing w-k-s/BrainfuckInterpreter [INFO] finished frobbing w-k-s/BrainfuckInterpreter [INFO] frobbed toml for w-k-s/BrainfuckInterpreter written to work/ex/clippy-test-run/sources/stable/gh/w-k-s/BrainfuckInterpreter/Cargo.toml [INFO] started frobbing w-k-s/BrainfuckInterpreter [INFO] finished frobbing w-k-s/BrainfuckInterpreter [INFO] frobbed toml for w-k-s/BrainfuckInterpreter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/w-k-s/BrainfuckInterpreter/Cargo.toml [INFO] crate w-k-s/BrainfuckInterpreter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting w-k-s/BrainfuckInterpreter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/w-k-s/BrainfuckInterpreter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 537dd0d63175a5be16295c71aa3d1e656d825d48bcb1c69212ee4b9d9d3f8996 [INFO] running `"docker" "start" "-a" "537dd0d63175a5be16295c71aa3d1e656d825d48bcb1c69212ee4b9d9d3f8996"` [INFO] [stderr] Checking brainfuck_interpreter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | for (i, value) in self.data.iter().enumerate() { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | fn reset(&mut self) -> &mut Brainfuck { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / let mut value_string: String; [INFO] [stderr] 85 | | if i == self.data_pointer { [INFO] [stderr] 86 | | value_string = format!("[{}] ", self.data[i]); [INFO] [stderr] 87 | | } else { [INFO] [stderr] 88 | | value_string = format!("{} ", self.data[i]); [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let value_string = if i == self.data_pointer { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:104:37 [INFO] [stderr] | [INFO] [stderr] 104 | let source = env::args().nth(1).unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | for (i, value) in self.data.iter().enumerate() { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / let mut value_string: String; [INFO] [stderr] 85 | | if i == self.data_pointer { [INFO] [stderr] 86 | | value_string = format!("[{}] ", self.data[i]); [INFO] [stderr] 87 | | } else { [INFO] [stderr] 88 | | value_string = format!("{} ", self.data[i]); [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let value_string = if i == self.data_pointer { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:104:37 [INFO] [stderr] | [INFO] [stderr] 104 | let source = env::args().nth(1).unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.86s [INFO] running `"docker" "inspect" "537dd0d63175a5be16295c71aa3d1e656d825d48bcb1c69212ee4b9d9d3f8996"` [INFO] running `"docker" "rm" "-f" "537dd0d63175a5be16295c71aa3d1e656d825d48bcb1c69212ee4b9d9d3f8996"` [INFO] [stdout] 537dd0d63175a5be16295c71aa3d1e656d825d48bcb1c69212ee4b9d9d3f8996