[INFO] updating cached repository vytis/circlone-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vytis/circlone-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vytis/circlone-rust" "work/ex/clippy-test-run/sources/stable/gh/vytis/circlone-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vytis/circlone-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vytis/circlone-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vytis/circlone-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vytis/circlone-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 080187780943b2acd598d05db3c9c9723cdb9882 [INFO] sha for GitHub repo vytis/circlone-rust: 080187780943b2acd598d05db3c9c9723cdb9882 [INFO] validating manifest of vytis/circlone-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vytis/circlone-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vytis/circlone-rust [INFO] finished frobbing vytis/circlone-rust [INFO] frobbed toml for vytis/circlone-rust written to work/ex/clippy-test-run/sources/stable/gh/vytis/circlone-rust/Cargo.toml [INFO] started frobbing vytis/circlone-rust [INFO] finished frobbing vytis/circlone-rust [INFO] frobbed toml for vytis/circlone-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vytis/circlone-rust/Cargo.toml [INFO] crate vytis/circlone-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vytis/circlone-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vytis/circlone-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c2626c8f61e10eb1f023205e5925aaff8a4286a3fbfed187bf4eeced94c7dc4 [INFO] running `"docker" "start" "-a" "9c2626c8f61e10eb1f023205e5925aaff8a4286a3fbfed187bf4eeced94c7dc4"` [INFO] [stderr] Checking circlone v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return val*limit [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val*limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generate.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return val*limit [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val*limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/viewport.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(width: &String, height: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/viewport.rs:10:40 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(width: &String, height: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output/svg.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | let mut result: String = String::from(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/output/mod.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | fn output(circles: &Vec, viewport: Viewport) -> String; [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Circle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/viewport.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(width: &String, height: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/viewport.rs:10:40 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn new(width: &String, height: &String) -> Result> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output/svg.rs:21:34 [INFO] [stderr] | [INFO] [stderr] 21 | let mut result: String = String::from(contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/output/mod.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | fn output(circles: &Vec, viewport: Viewport) -> String; [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Circle]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.38s [INFO] running `"docker" "inspect" "9c2626c8f61e10eb1f023205e5925aaff8a4286a3fbfed187bf4eeced94c7dc4"` [INFO] running `"docker" "rm" "-f" "9c2626c8f61e10eb1f023205e5925aaff8a4286a3fbfed187bf4eeced94c7dc4"` [INFO] [stdout] 9c2626c8f61e10eb1f023205e5925aaff8a4286a3fbfed187bf4eeced94c7dc4