[INFO] updating cached repository vrischmann/producerid-service [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vrischmann/producerid-service [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vrischmann/producerid-service" "work/ex/clippy-test-run/sources/stable/gh/vrischmann/producerid-service"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vrischmann/producerid-service'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vrischmann/producerid-service" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vrischmann/producerid-service"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vrischmann/producerid-service'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b96c1a19307ac335c0da711b07174f35c6ced9e7 [INFO] sha for GitHub repo vrischmann/producerid-service: b96c1a19307ac335c0da711b07174f35c6ced9e7 [INFO] validating manifest of vrischmann/producerid-service on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vrischmann/producerid-service on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vrischmann/producerid-service [INFO] finished frobbing vrischmann/producerid-service [INFO] frobbed toml for vrischmann/producerid-service written to work/ex/clippy-test-run/sources/stable/gh/vrischmann/producerid-service/Cargo.toml [INFO] started frobbing vrischmann/producerid-service [INFO] finished frobbing vrischmann/producerid-service [INFO] frobbed toml for vrischmann/producerid-service written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vrischmann/producerid-service/Cargo.toml [INFO] crate vrischmann/producerid-service has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vrischmann/producerid-service against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vrischmann/producerid-service:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3979ef4d187813d0130c4f0e75e23c5ade2554bae3701aaf4901edc434662741 [INFO] running `"docker" "start" "-a" "3979ef4d187813d0130c4f0e75e23c5ade2554bae3701aaf4901edc434662741"` [INFO] [stderr] Compiling proc-macro2 v0.4.19 [INFO] [stderr] Checking futures v0.1.24 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking ascii v0.7.1 [INFO] [stderr] Compiling redis v0.9.1 [INFO] [stderr] Checking chunked_transfer v0.3.1 [INFO] [stderr] Checking ascii v0.8.7 [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking lock_api v0.1.3 [INFO] [stderr] Checking bytes v0.4.10 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking combine v3.5.2 [INFO] [stderr] Compiling quote v0.6.8 [INFO] [stderr] Checking tiny_http v0.6.0 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking tokio-executor v0.1.4 [INFO] [stderr] Compiling syn v0.15.4 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Checking producerid-service v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | http_server: http_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_server` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | processor: processor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | http_server: http_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `http_server` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | processor: processor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return Error::JSON(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::JSON(err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return Error::IO(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::IO(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return Error::Redis(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::Redis(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / return Error::Other(CustomError { [INFO] [stderr] 70 | | description: err.description().to_owned(), [INFO] [stderr] 71 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 69 | Error::Other(CustomError { [INFO] [stderr] 70 | description: err.description().to_owned(), [INFO] [stderr] 71 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / return Ok(Processor { [INFO] [stderr] 99 | | conn: client.get_connection()?, [INFO] [stderr] 100 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 98 | Ok(Processor { [INFO] [stderr] 99 | conn: client.get_connection()?, [INFO] [stderr] 100 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | const K: &'static str = "producerid-service::history_per_pod"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | const K: &'static str = "producerid-service::history_per_producer"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | mapped [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | let mapped = iter [INFO] [stderr] | ______________________^ [INFO] [stderr] 140 | | .map(|v| serde_json::from_str(&v)) [INFO] [stderr] 141 | | .collect::, JSONError>>() [INFO] [stderr] 142 | | .map_err(|e| Error::from(e)); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / return Ok(Server { [INFO] [stderr] 213 | | http_server: http_server, [INFO] [stderr] 214 | | processor: processor, [INFO] [stderr] 215 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 212 | Ok(Server { [INFO] [stderr] 213 | http_server: http_server, [INFO] [stderr] 214 | processor: processor, [INFO] [stderr] 215 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | return server.run(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `server.run()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return Error::JSON(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::JSON(err)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return Error::IO(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::IO(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return Error::Redis(err); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error::Redis(err)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | / return Error::Other(CustomError { [INFO] [stderr] 70 | | description: err.description().to_owned(), [INFO] [stderr] 71 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 69 | Error::Other(CustomError { [INFO] [stderr] 70 | description: err.description().to_owned(), [INFO] [stderr] 71 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / return Ok(Processor { [INFO] [stderr] 99 | | conn: client.get_connection()?, [INFO] [stderr] 100 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 98 | Ok(Processor { [INFO] [stderr] 99 | conn: client.get_connection()?, [INFO] [stderr] 100 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | const K: &'static str = "producerid-service::history_per_pod"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | const K: &'static str = "producerid-service::history_per_producer"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | mapped [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | let mapped = iter [INFO] [stderr] | ______________________^ [INFO] [stderr] 140 | | .map(|v| serde_json::from_str(&v)) [INFO] [stderr] 141 | | .collect::, JSONError>>() [INFO] [stderr] 142 | | .map_err(|e| Error::from(e)); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / return Ok(Server { [INFO] [stderr] 213 | | http_server: http_server, [INFO] [stderr] 214 | | processor: processor, [INFO] [stderr] 215 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 212 | Ok(Server { [INFO] [stderr] 213 | http_server: http_server, [INFO] [stderr] 214 | processor: processor, [INFO] [stderr] 215 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | return server.run(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `server.run()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:109:15 [INFO] [stderr] | [INFO] [stderr] 109 | while n <= 0 || exists { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using n == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/main.rs:109:15 [INFO] [stderr] | [INFO] [stderr] 109 | while n <= 0 || exists { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using n == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:142:22 [INFO] [stderr] | [INFO] [stderr] 142 | .map_err(|e| Error::from(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:142:22 [INFO] [stderr] | [INFO] [stderr] 142 | .map_err(|e| Error::from(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:219:49 [INFO] [stderr] | [INFO] [stderr] 219 | let response: serde_json::Value = match hreq.url().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `hreq.url()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:219:49 [INFO] [stderr] | [INFO] [stderr] 219 | let response: serde_json::Value = match hreq.url().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `hreq.url()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | / match r.pod_name.is_empty() { [INFO] [stderr] 259 | | true => serde_json::to_value(StatusResponse { [INFO] [stderr] 260 | | status: Status::ERROR, [INFO] [stderr] 261 | | error: Some("pod name can't be empty".to_owned()), [INFO] [stderr] ... | [INFO] [stderr] 265 | | }), [INFO] [stderr] 266 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 258 | if r.pod_name.is_empty() { serde_json::to_value(StatusResponse { [INFO] [stderr] 259 | status: Status::ERROR, [INFO] [stderr] 260 | error: Some("pod name can't be empty".to_owned()), [INFO] [stderr] 261 | })? } else { json!({ [INFO] [stderr] 262 | "producer_id": self.processor.acquire(&r.pod_name)? [INFO] [stderr] 263 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:258:17 [INFO] [stderr] | [INFO] [stderr] 258 | / match r.pod_name.is_empty() { [INFO] [stderr] 259 | | true => serde_json::to_value(StatusResponse { [INFO] [stderr] 260 | | status: Status::ERROR, [INFO] [stderr] 261 | | error: Some("pod name can't be empty".to_owned()), [INFO] [stderr] ... | [INFO] [stderr] 265 | | }), [INFO] [stderr] 266 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 258 | if r.pod_name.is_empty() { serde_json::to_value(StatusResponse { [INFO] [stderr] 259 | status: Status::ERROR, [INFO] [stderr] 260 | error: Some("pod name can't be empty".to_owned()), [INFO] [stderr] 261 | })? } else { json!({ [INFO] [stderr] 262 | "producer_id": self.processor.acquire(&r.pod_name)? [INFO] [stderr] 263 | }) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | / match r.pod_name.is_empty() { [INFO] [stderr] 277 | | true => serde_json::to_value(StatusResponse { [INFO] [stderr] 278 | | status: Status::ERROR, [INFO] [stderr] 279 | | error: Some("pod name can't be empty".to_owned()), [INFO] [stderr] ... | [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 276 | if r.pod_name.is_empty() { serde_json::to_value(StatusResponse { [INFO] [stderr] 277 | status: Status::ERROR, [INFO] [stderr] 278 | error: Some("pod name can't be empty".to_owned()), [INFO] [stderr] 279 | })? } else { [INFO] [stderr] 280 | self.processor.release(&r.pod_name)?; [INFO] [stderr] 281 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:276:17 [INFO] [stderr] | [INFO] [stderr] 276 | / match r.pod_name.is_empty() { [INFO] [stderr] 277 | | true => serde_json::to_value(StatusResponse { [INFO] [stderr] 278 | | status: Status::ERROR, [INFO] [stderr] 279 | | error: Some("pod name can't be empty".to_owned()), [INFO] [stderr] ... | [INFO] [stderr] 288 | | } [INFO] [stderr] 289 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 276 | if r.pod_name.is_empty() { serde_json::to_value(StatusResponse { [INFO] [stderr] 277 | status: Status::ERROR, [INFO] [stderr] 278 | error: Some("pod name can't be empty".to_owned()), [INFO] [stderr] 279 | })? } else { [INFO] [stderr] 280 | self.processor.release(&r.pod_name)?; [INFO] [stderr] 281 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `producerid-service`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `producerid-service`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3979ef4d187813d0130c4f0e75e23c5ade2554bae3701aaf4901edc434662741"` [INFO] running `"docker" "rm" "-f" "3979ef4d187813d0130c4f0e75e23c5ade2554bae3701aaf4901edc434662741"` [INFO] [stdout] 3979ef4d187813d0130c4f0e75e23c5ade2554bae3701aaf4901edc434662741