[INFO] updating cached repository vpeurala/reaktor-fast-track-2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vpeurala/reaktor-fast-track-2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vpeurala/reaktor-fast-track-2" "work/ex/clippy-test-run/sources/stable/gh/vpeurala/reaktor-fast-track-2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vpeurala/reaktor-fast-track-2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vpeurala/reaktor-fast-track-2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vpeurala/reaktor-fast-track-2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vpeurala/reaktor-fast-track-2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cacebe3d7945974f6d1f4829231499a614b84b76 [INFO] sha for GitHub repo vpeurala/reaktor-fast-track-2: cacebe3d7945974f6d1f4829231499a614b84b76 [INFO] validating manifest of vpeurala/reaktor-fast-track-2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vpeurala/reaktor-fast-track-2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vpeurala/reaktor-fast-track-2 [INFO] finished frobbing vpeurala/reaktor-fast-track-2 [INFO] frobbed toml for vpeurala/reaktor-fast-track-2 written to work/ex/clippy-test-run/sources/stable/gh/vpeurala/reaktor-fast-track-2/Cargo.toml [INFO] started frobbing vpeurala/reaktor-fast-track-2 [INFO] finished frobbing vpeurala/reaktor-fast-track-2 [INFO] frobbed toml for vpeurala/reaktor-fast-track-2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vpeurala/reaktor-fast-track-2/Cargo.toml [INFO] crate vpeurala/reaktor-fast-track-2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vpeurala/reaktor-fast-track-2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vpeurala/reaktor-fast-track-2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a33e6c8f80b30f05fe575c8f22f0f0a4d396278d50da73f719dfebbfb682ebcd [INFO] running `"docker" "start" "-a" "a33e6c8f80b30f05fe575c8f22f0f0a4d396278d50da73f719dfebbfb682ebcd"` [INFO] [stderr] Checking serde v1.0.24 [INFO] [stderr] Compiling serde_derive_internals v0.18.0 [INFO] [stderr] Compiling serde_derive v1.0.24 [INFO] [stderr] Checking serde_json v1.0.8 [INFO] [stderr] Checking serde_test v1.0.24 [INFO] [stderr] Checking reaktor_fast_track_2 v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:131:32 [INFO] [stderr] | [INFO] [stderr] 131 | AdjacencyListBackedGraph { vertices: vertices } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:131:32 [INFO] [stderr] | [INFO] [stderr] 131 | AdjacencyListBackedGraph { vertices: vertices } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertices` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/graph.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | let output: Vec = all_outgoing.iter().filter(|e| !visited.contains(&e.0)).map(|e| e.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `all_outgoing.iter().filter(|e| !visited.contains(&e.0)).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph.rs:49:97 [INFO] [stderr] | [INFO] [stderr] 49 | let output: Vec = all_outgoing.iter().filter(|e| !visited.contains(&e.0)).map(|e| e.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/graph.rs:64:42 [INFO] [stderr] | [INFO] [stderr] 64 | self.edges.iter().map(|e| e.weight()).fold(0, |sum, weight| sum + weight) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/graph.rs:126:7 [INFO] [stderr] | [INFO] [stderr] 126 | / if !vertices.contains_key(&je.from()) { [INFO] [stderr] 127 | | vertices.insert(je.from(), Vec::new()); [INFO] [stderr] 128 | | } [INFO] [stderr] | |_______^ help: consider using: `vertices.entry(je.from()).or_insert(Vec::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/graph.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | let output: Vec = all_outgoing.iter().filter(|e| !visited.contains(&e.0)).map(|e| e.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `all_outgoing.iter().filter(|e| !visited.contains(&e.0)).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/graph.rs:49:97 [INFO] [stderr] | [INFO] [stderr] 49 | let output: Vec = all_outgoing.iter().filter(|e| !visited.contains(&e.0)).map(|e| e.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/graph.rs:64:42 [INFO] [stderr] | [INFO] [stderr] 64 | self.edges.iter().map(|e| e.weight()).fold(0, |sum, weight| sum + weight) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/graph.rs:126:7 [INFO] [stderr] | [INFO] [stderr] 126 | / if !vertices.contains_key(&je.from()) { [INFO] [stderr] 127 | | vertices.insert(je.from(), Vec::new()); [INFO] [stderr] 128 | | } [INFO] [stderr] | |_______^ help: consider using: `vertices.entry(je.from()).or_insert(Vec::new())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.85s [INFO] running `"docker" "inspect" "a33e6c8f80b30f05fe575c8f22f0f0a4d396278d50da73f719dfebbfb682ebcd"` [INFO] running `"docker" "rm" "-f" "a33e6c8f80b30f05fe575c8f22f0f0a4d396278d50da73f719dfebbfb682ebcd"` [INFO] [stdout] a33e6c8f80b30f05fe575c8f22f0f0a4d396278d50da73f719dfebbfb682ebcd