[INFO] updating cached repository void-productions/transp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/void-productions/transp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/void-productions/transp" "work/ex/clippy-test-run/sources/stable/gh/void-productions/transp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/void-productions/transp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/void-productions/transp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/void-productions/transp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/void-productions/transp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ad087600e52fbed80522527c679c7bae64a17581 [INFO] sha for GitHub repo void-productions/transp: ad087600e52fbed80522527c679c7bae64a17581 [INFO] validating manifest of void-productions/transp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of void-productions/transp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing void-productions/transp [INFO] finished frobbing void-productions/transp [INFO] frobbed toml for void-productions/transp written to work/ex/clippy-test-run/sources/stable/gh/void-productions/transp/Cargo.toml [INFO] started frobbing void-productions/transp [INFO] finished frobbing void-productions/transp [INFO] frobbed toml for void-productions/transp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/void-productions/transp/Cargo.toml [INFO] crate void-productions/transp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting void-productions/transp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/void-productions/transp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 961240cbb8adbbbc9d19855947333e1ed817a666664965e74fadac8f322f94fc [INFO] running `"docker" "start" "-a" "961240cbb8adbbbc9d19855947333e1ed817a666664965e74fadac8f322f94fc"` [INFO] [stderr] Checking libc v0.1.12 [INFO] [stderr] Checking serde v1.0.12 [INFO] [stderr] Checking c_linked_list v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.12 [INFO] [stderr] Checking get_if_addrs v0.4.0 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking transp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sender.rs:55:2 [INFO] [stderr] | [INFO] [stderr] 55 | return Ok(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(input)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sender.rs:55:2 [INFO] [stderr] | [INFO] [stderr] 55 | return Ok(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(input)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/receiver/ip.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | match ifaces.iter() [INFO] [stderr] | ___________________^ [INFO] [stderr] 7 | | .map(|x| x.ip()) [INFO] [stderr] 8 | | .map(|x| x.to_string()) [INFO] [stderr] 9 | | .filter(|x| x.starts_with("192.168.178.")) [INFO] [stderr] 10 | | .next() { [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| x.starts_with("192.168.178.")).next()` with `find(|x| x.starts_with("192.168.178."))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/receiver/allow.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | None => { return Err(format!("Failed to normalize empty path!")); }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to normalize empty path!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/packet.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn deserialize(bin: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/receiver/ip.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | match ifaces.iter() [INFO] [stderr] | ___________________^ [INFO] [stderr] 7 | | .map(|x| x.ip()) [INFO] [stderr] 8 | | .map(|x| x.to_string()) [INFO] [stderr] 9 | | .filter(|x| x.starts_with("192.168.178.")) [INFO] [stderr] 10 | | .next() { [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|x| x.starts_with("192.168.178.")).next()` with `find(|x| x.starts_with("192.168.178."))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/receiver/allow.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | None => { return Err(format!("Failed to normalize empty path!")); }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Failed to normalize empty path!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/packet.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn deserialize(bin: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.29s [INFO] running `"docker" "inspect" "961240cbb8adbbbc9d19855947333e1ed817a666664965e74fadac8f322f94fc"` [INFO] running `"docker" "rm" "-f" "961240cbb8adbbbc9d19855947333e1ed817a666664965e74fadac8f322f94fc"` [INFO] [stdout] 961240cbb8adbbbc9d19855947333e1ed817a666664965e74fadac8f322f94fc