[INFO] updating cached repository vmannn/TheRustGame [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vmannn/TheRustGame [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vmannn/TheRustGame" "work/ex/clippy-test-run/sources/stable/gh/vmannn/TheRustGame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vmannn/TheRustGame'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vmannn/TheRustGame" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vmannn/TheRustGame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vmannn/TheRustGame'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 039723b1c092223c02c8fdf198bfca1625997554 [INFO] sha for GitHub repo vmannn/TheRustGame: 039723b1c092223c02c8fdf198bfca1625997554 [INFO] validating manifest of vmannn/TheRustGame on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vmannn/TheRustGame on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vmannn/TheRustGame [INFO] finished frobbing vmannn/TheRustGame [INFO] frobbed toml for vmannn/TheRustGame written to work/ex/clippy-test-run/sources/stable/gh/vmannn/TheRustGame/Cargo.toml [INFO] started frobbing vmannn/TheRustGame [INFO] finished frobbing vmannn/TheRustGame [INFO] frobbed toml for vmannn/TheRustGame written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vmannn/TheRustGame/Cargo.toml [INFO] crate vmannn/TheRustGame has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vmannn/TheRustGame against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vmannn/TheRustGame:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8843ba1e302a47a5e8c6b1a783f9972a7a0a428b7806a7e3643d106d827359fa [INFO] running `"docker" "start" "-a" "8843ba1e302a47a5e8c6b1a783f9972a7a0a428b7806a7e3643d106d827359fa"` [INFO] [stderr] Compiling dtoa v0.4.3 [INFO] [stderr] Compiling proc-macro2 v0.4.12 [INFO] [stderr] Compiling bitflags v1.0.3 [INFO] [stderr] Compiling pkg-config v0.3.13 [INFO] [stderr] Checking bitflags v0.8.2 [INFO] [stderr] Compiling phf_shared v0.7.22 [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Compiling syn v0.10.8 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking inflate v0.3.4 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking draw_state v0.7.1 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling phf v0.7.22 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Compiling quote v0.6.6 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Compiling syn v0.14.8 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking piston-gfx_texture v0.30.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.47.0 [INFO] [stderr] Checking piston_window v0.74.0 [INFO] [stderr] Checking snakegarden v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:424:9 [INFO] [stderr] | [INFO] [stderr] 424 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:424:9 [INFO] [stderr] | [INFO] [stderr] 424 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/renderings.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | let mapx = (x as f64) * SQUARES; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/renderings.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | let mapy = (y as f64) * SQUARES; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | self.wait_time = self.wait_time + time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.wait_time += time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:366:9 [INFO] [stderr] | [INFO] [stderr] 366 | / match directional [INFO] [stderr] 367 | | { [INFO] [stderr] 368 | | Some(d) => advance = d, [INFO] [stderr] 369 | | None => {}, [INFO] [stderr] 370 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = directional { advance = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:413:10 [INFO] [stderr] | [INFO] [stderr] 413 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:431:10 [INFO] [stderr] | [INFO] [stderr] 431 | / match path [INFO] [stderr] 432 | | { [INFO] [stderr] 433 | | Some(p) => self.direction = p, [INFO] [stderr] 434 | | None => (), [INFO] [stderr] 435 | | } [INFO] [stderr] | |__________^ help: try this: `if let Some(p) = path { self.direction = p }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variant `left` should have a camel case name such as `Left` [INFO] [stderr] --> src/game.rs:483:5 [INFO] [stderr] | [INFO] [stderr] 483 | left, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `up` should have a camel case name such as `Up` [INFO] [stderr] --> src/game.rs:484:5 [INFO] [stderr] | [INFO] [stderr] 484 | up, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant `right` should have a camel case name such as `Right` [INFO] [stderr] --> src/game.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `down` should have a camel case name such as `Down` [INFO] [stderr] --> src/game.rs:486:5 [INFO] [stderr] | [INFO] [stderr] 486 | down, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:500:20 [INFO] [stderr] | [INFO] [stderr] 500 | pub fn inverse(&self) -> Facing [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:21:46 [INFO] [stderr] | [INFO] [stderr] 21 | WindowSettings::new("snakegame", [((30 as f64 * 15.00) as u32), ((26 as f64 * 15.00) as u32)]) [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(30)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:21:76 [INFO] [stderr] | [INFO] [stderr] 21 | WindowSettings::new("snakegame", [((30 as f64 * 15.00) as u32), ((26 as f64 * 15.00) as u32)]) [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(26)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/renderings.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | let mapx = (x as f64) * SQUARES; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/renderings.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | let mapy = (y as f64) * SQUARES; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | self.wait_time = self.wait_time + time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.wait_time += time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:366:9 [INFO] [stderr] | [INFO] [stderr] 366 | / match directional [INFO] [stderr] 367 | | { [INFO] [stderr] 368 | | Some(d) => advance = d, [INFO] [stderr] 369 | | None => {}, [INFO] [stderr] 370 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(d) = directional { advance = d }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/game.rs:413:10 [INFO] [stderr] | [INFO] [stderr] 413 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:431:10 [INFO] [stderr] | [INFO] [stderr] 431 | / match path [INFO] [stderr] 432 | | { [INFO] [stderr] 433 | | Some(p) => self.direction = p, [INFO] [stderr] 434 | | None => (), [INFO] [stderr] 435 | | } [INFO] [stderr] | |__________^ help: try this: `if let Some(p) = path { self.direction = p }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variant `left` should have a camel case name such as `Left` [INFO] [stderr] --> src/game.rs:483:5 [INFO] [stderr] | [INFO] [stderr] 483 | left, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `up` should have a camel case name such as `Up` [INFO] [stderr] --> src/game.rs:484:5 [INFO] [stderr] | [INFO] [stderr] 484 | up, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant `right` should have a camel case name such as `Right` [INFO] [stderr] --> src/game.rs:485:5 [INFO] [stderr] | [INFO] [stderr] 485 | right, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `down` should have a camel case name such as `Down` [INFO] [stderr] --> src/game.rs:486:5 [INFO] [stderr] | [INFO] [stderr] 486 | down, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:500:20 [INFO] [stderr] | [INFO] [stderr] 500 | pub fn inverse(&self) -> Facing [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:21:46 [INFO] [stderr] | [INFO] [stderr] 21 | WindowSettings::new("snakegame", [((30 as f64 * 15.00) as u32), ((26 as f64 * 15.00) as u32)]) [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(30)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:21:76 [INFO] [stderr] | [INFO] [stderr] 21 | WindowSettings::new("snakegame", [((30 as f64 * 15.00) as u32), ((26 as f64 * 15.00) as u32)]) [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(26)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `"docker" "inspect" "8843ba1e302a47a5e8c6b1a783f9972a7a0a428b7806a7e3643d106d827359fa"` [INFO] running `"docker" "rm" "-f" "8843ba1e302a47a5e8c6b1a783f9972a7a0a428b7806a7e3643d106d827359fa"` [INFO] [stdout] 8843ba1e302a47a5e8c6b1a783f9972a7a0a428b7806a7e3643d106d827359fa