[INFO] updating cached repository vladimiriousIT/PongGameRUST [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vladimiriousIT/PongGameRUST [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vladimiriousIT/PongGameRUST" "work/ex/clippy-test-run/sources/stable/gh/vladimiriousIT/PongGameRUST"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vladimiriousIT/PongGameRUST'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vladimiriousIT/PongGameRUST" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vladimiriousIT/PongGameRUST"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vladimiriousIT/PongGameRUST'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 690285b618cc42cdb64655e752320e7e4ef710d3 [INFO] sha for GitHub repo vladimiriousIT/PongGameRUST: 690285b618cc42cdb64655e752320e7e4ef710d3 [INFO] validating manifest of vladimiriousIT/PongGameRUST on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vladimiriousIT/PongGameRUST on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vladimiriousIT/PongGameRUST [INFO] finished frobbing vladimiriousIT/PongGameRUST [INFO] frobbed toml for vladimiriousIT/PongGameRUST written to work/ex/clippy-test-run/sources/stable/gh/vladimiriousIT/PongGameRUST/Cargo.toml [INFO] started frobbing vladimiriousIT/PongGameRUST [INFO] finished frobbing vladimiriousIT/PongGameRUST [INFO] frobbed toml for vladimiriousIT/PongGameRUST written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vladimiriousIT/PongGameRUST/Cargo.toml [INFO] crate vladimiriousIT/PongGameRUST has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vladimiriousIT/PongGameRUST against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vladimiriousIT/PongGameRUST:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c60c0f8bddd1ae472009d34307b2384ba47b289d2753baa9eec1c4fdac89378 [INFO] running `"docker" "start" "-a" "7c60c0f8bddd1ae472009d34307b2384ba47b289d2753baa9eec1c4fdac89378"` [INFO] [stderr] Compiling bitflags v1.0.3 [INFO] [stderr] Compiling num-traits v0.2.4 [INFO] [stderr] Checking token_store v0.1.2 [INFO] [stderr] Compiling num-integer v0.1.38 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Compiling log v0.4.2 [INFO] [stderr] Compiling x11-dl v2.18.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Checking inflate v0.4.2 [INFO] [stderr] Checking stb_truetype v0.2.2 [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Checking gif v0.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking tempfile v3.0.2 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking PongGame v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: crate `PongGame` should have a snake case name such as `pong_game` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | let left_pos = self.left_pos as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.left_pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let right_pos = self.right_pos as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.right_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | let ball_x = self.ball_x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | let ball_y = self.ball_y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | c.transform.trans(args.width as f64 - 10.0, right_pos), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | fn update(&mut self, _args: &UpdateArgs){ [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 99 | | match key { [INFO] [stderr] 100 | | Key::Up =>{ [INFO] [stderr] 101 | | self.right_vel = -1; [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 118 | | match key { [INFO] [stderr] 119 | | Key::Up =>{ [INFO] [stderr] 120 | | self.right_vel = 0; [INFO] [stderr] ... | [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `PongGame` should have a snake case name such as `pong_game` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | let left_pos = self.left_pos as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.left_pos)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | let right_pos = self.right_pos as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.right_pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:22 [INFO] [stderr] | [INFO] [stderr] 40 | let ball_x = self.ball_x as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:22 [INFO] [stderr] | [INFO] [stderr] 41 | let ball_y = self.ball_y as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ball_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:49:35 [INFO] [stderr] | [INFO] [stderr] 49 | c.transform.trans(args.width as f64 - 10.0, right_pos), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | fn update(&mut self, _args: &UpdateArgs){ [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 99 | | match key { [INFO] [stderr] 100 | | Key::Up =>{ [INFO] [stderr] 101 | | self.right_vel = -1; [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / if let &Button::Keyboard(key) = args { [INFO] [stderr] 118 | | match key { [INFO] [stderr] 119 | | Key::Up =>{ [INFO] [stderr] 120 | | self.right_vel = 0; [INFO] [stderr] ... | [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | if let Button::Keyboard(key) = *args { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.94s [INFO] running `"docker" "inspect" "7c60c0f8bddd1ae472009d34307b2384ba47b289d2753baa9eec1c4fdac89378"` [INFO] running `"docker" "rm" "-f" "7c60c0f8bddd1ae472009d34307b2384ba47b289d2753baa9eec1c4fdac89378"` [INFO] [stdout] 7c60c0f8bddd1ae472009d34307b2384ba47b289d2753baa9eec1c4fdac89378