[INFO] updating cached repository vizee/tcpproxy-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vizee/tcpproxy-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vizee/tcpproxy-rs" "work/ex/clippy-test-run/sources/stable/gh/vizee/tcpproxy-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vizee/tcpproxy-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vizee/tcpproxy-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vizee/tcpproxy-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vizee/tcpproxy-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b05d331c9f338fdcbb229b76bb1b5c875e0039bc [INFO] sha for GitHub repo vizee/tcpproxy-rs: b05d331c9f338fdcbb229b76bb1b5c875e0039bc [INFO] validating manifest of vizee/tcpproxy-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vizee/tcpproxy-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vizee/tcpproxy-rs [INFO] finished frobbing vizee/tcpproxy-rs [INFO] frobbed toml for vizee/tcpproxy-rs written to work/ex/clippy-test-run/sources/stable/gh/vizee/tcpproxy-rs/Cargo.toml [INFO] started frobbing vizee/tcpproxy-rs [INFO] finished frobbing vizee/tcpproxy-rs [INFO] frobbed toml for vizee/tcpproxy-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vizee/tcpproxy-rs/Cargo.toml [INFO] crate vizee/tcpproxy-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vizee/tcpproxy-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vizee/tcpproxy-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c813e36ff913909bc96d5c1aa83bacc4feba9f434a97776670c1dd849f537b93 [INFO] running `"docker" "start" "-a" "c813e36ff913909bc96d5c1aa83bacc4feba9f434a97776670c1dd849f537b93"` [INFO] [stderr] Checking tcpproxy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | pfd: pfd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pfd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | pfd: pfd, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pfd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:364:17 [INFO] [stderr] | [INFO] [stderr] 364 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | s_addr: (ip[3] as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ip[3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | | (ip[2] as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ip[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | | (ip[1] as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ip[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | | (ip[0] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ip[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let r = match addr { [INFO] [stderr] | _____________^ [INFO] [stderr] 59 | | &net::SocketAddr::V4(sa) => { [INFO] [stderr] 60 | | let sin = sa_to_raw(&sa); [INFO] [stderr] 61 | | syscall!(libc::connect( [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | let r = match *addr { [INFO] [stderr] 59 | net::SocketAddr::V4(sa) => { [INFO] [stderr] 60 | let sin = sa_to_raw(&sa); [INFO] [stderr] 61 | syscall!(libc::connect( [INFO] [stderr] 62 | fd, [INFO] [stderr] 63 | &sin as *const _ as *const _, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | let r = match addr { [INFO] [stderr] | _____________^ [INFO] [stderr] 95 | | &net::SocketAddr::V4(sa) => { [INFO] [stderr] 96 | | let sin = sa_to_raw(&sa); [INFO] [stderr] 97 | | syscall!(libc::bind( [INFO] [stderr] ... | [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | let r = match *addr { [INFO] [stderr] 95 | net::SocketAddr::V4(sa) => { [INFO] [stderr] 96 | let sin = sa_to_raw(&sa); [INFO] [stderr] 97 | syscall!(libc::bind( [INFO] [stderr] 98 | fd, [INFO] [stderr] 99 | &sin as *const _ as *const _, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `events`. [INFO] [stderr] --> src/main.rs:404:18 [INFO] [stderr] | [INFO] [stderr] 404 | for i in 0..n as usize { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 404 | for in events.iter().take(n as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:364:17 [INFO] [stderr] | [INFO] [stderr] 364 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | s_addr: (ip[3] as u32) << 24 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ip[3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | | (ip[2] as u32) << 16 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ip[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | | (ip[1] as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ip[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | | (ip[0] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(ip[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | let r = match addr { [INFO] [stderr] | _____________^ [INFO] [stderr] 59 | | &net::SocketAddr::V4(sa) => { [INFO] [stderr] 60 | | let sin = sa_to_raw(&sa); [INFO] [stderr] 61 | | syscall!(libc::connect( [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | let r = match *addr { [INFO] [stderr] 59 | net::SocketAddr::V4(sa) => { [INFO] [stderr] 60 | let sin = sa_to_raw(&sa); [INFO] [stderr] 61 | syscall!(libc::connect( [INFO] [stderr] 62 | fd, [INFO] [stderr] 63 | &sin as *const _ as *const _, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | let r = match addr { [INFO] [stderr] | _____________^ [INFO] [stderr] 95 | | &net::SocketAddr::V4(sa) => { [INFO] [stderr] 96 | | let sin = sa_to_raw(&sa); [INFO] [stderr] 97 | | syscall!(libc::bind( [INFO] [stderr] ... | [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 94 | let r = match *addr { [INFO] [stderr] 95 | net::SocketAddr::V4(sa) => { [INFO] [stderr] 96 | let sin = sa_to_raw(&sa); [INFO] [stderr] 97 | syscall!(libc::bind( [INFO] [stderr] 98 | fd, [INFO] [stderr] 99 | &sin as *const _ as *const _, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `events`. [INFO] [stderr] --> src/main.rs:404:18 [INFO] [stderr] | [INFO] [stderr] 404 | for i in 0..n as usize { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 404 | for in events.iter().take(n as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "c813e36ff913909bc96d5c1aa83bacc4feba9f434a97776670c1dd849f537b93"` [INFO] running `"docker" "rm" "-f" "c813e36ff913909bc96d5c1aa83bacc4feba9f434a97776670c1dd849f537b93"` [INFO] [stdout] c813e36ff913909bc96d5c1aa83bacc4feba9f434a97776670c1dd849f537b93