[INFO] updating cached repository vivlim/rust-gallery-generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vivlim/rust-gallery-generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vivlim/rust-gallery-generator" "work/ex/clippy-test-run/sources/stable/gh/vivlim/rust-gallery-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vivlim/rust-gallery-generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vivlim/rust-gallery-generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vivlim/rust-gallery-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vivlim/rust-gallery-generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cc35acc56b7f2617e61b5c6743968c547b3e910c [INFO] sha for GitHub repo vivlim/rust-gallery-generator: cc35acc56b7f2617e61b5c6743968c547b3e910c [INFO] validating manifest of vivlim/rust-gallery-generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vivlim/rust-gallery-generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vivlim/rust-gallery-generator [INFO] finished frobbing vivlim/rust-gallery-generator [INFO] frobbed toml for vivlim/rust-gallery-generator written to work/ex/clippy-test-run/sources/stable/gh/vivlim/rust-gallery-generator/Cargo.toml [INFO] started frobbing vivlim/rust-gallery-generator [INFO] finished frobbing vivlim/rust-gallery-generator [INFO] frobbed toml for vivlim/rust-gallery-generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vivlim/rust-gallery-generator/Cargo.toml [INFO] crate vivlim/rust-gallery-generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vivlim/rust-gallery-generator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vivlim/rust-gallery-generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5d64dd7b67a10f82d2dd69f5a076dc31ae2cd26854cc2a4c516eb62c04ac2454 [INFO] running `"docker" "start" "-a" "5d64dd7b67a10f82d2dd69f5a076dc31ae2cd26854cc2a4c516eb62c04ac2454"` [INFO] [stderr] Compiling md5 v0.3.8 [INFO] [stderr] Compiling itertools v0.7.8 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Compiling nom v4.0.0 [INFO] [stderr] Checking rsass v0.9.4 [INFO] [stderr] Checking ructe v0.4.6 [INFO] [stderr] Compiling gallery v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | html_name: html_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `html_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/files.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | html_name: html_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `html_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/files.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return files.map(|f| load_file(f.unwrap())).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `files.map(|f| load_file(f.unwrap())).collect::>()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Write`, `self` [INFO] [stderr] --> src/handlers.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{self, Read, Write, Cursor}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{self, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_swf.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(feature="cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_page_base.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(feature="cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_fallback.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(feature="cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_index.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(feature="cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_swf.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(feature="cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/handlers.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let result = match file.extension.as_ref() { [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `content_dir` [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_index.rs:8:31 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn index(out: &mut Write, content_dir: &str, output_dir: &str, files: &Vec) [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_content_dir` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/files.rs:5:48 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn load_files_in_directory(directory_path: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/handlers.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | output.read_to_string(&mut output_string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | create_dir_all(output_dir); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | templates::index(&mut out_file, "input", "output", &handled_files); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | out_file.write_all(handled_file.output.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/files.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return files.map(|f| load_file(f.unwrap())).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `files.map(|f| load_file(f.unwrap())).collect::>()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Write`, `self` [INFO] [stderr] --> src/handlers.rs:2:15 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{self, Read, Write, Cursor}; [INFO] [stderr] | ^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self` [INFO] [stderr] --> src/main.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | use std::io::{self, Write}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_swf.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(feature="cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_page_base.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(feature="cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_fallback.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(feature="cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_index.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(feature="cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_index.rs:8:75 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn index(out: &mut Write, content_dir: &str, output_dir: &str, files: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[RenderedFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: lint name `useless_attribute` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_swf.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | #[cfg_attr(feature="cargo-clippy", allow(useless_attribute))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::useless_attribute` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `result` [INFO] [stderr] --> src/handlers.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | let result = match file.extension.as_ref() { [INFO] [stderr] | ^^^^^^ help: consider using `_result` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `content_dir` [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_index.rs:8:31 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn index(out: &mut Write, content_dir: &str, output_dir: &str, files: &Vec) [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_content_dir` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/files.rs:5:48 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn load_files_in_directory(directory_path: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/handlers.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | output.read_to_string(&mut output_string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | create_dir_all(output_dir); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | templates::index(&mut out_file, "input", "output", &handled_files); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | out_file.write_all(handled_file.output.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> /opt/crater/target/debug/build/gallery-db9c2b3bca827166/out/templates/template_index.rs:8:75 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn index(out: &mut Write, content_dir: &str, output_dir: &str, files: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[RenderedFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.38s [INFO] running `"docker" "inspect" "5d64dd7b67a10f82d2dd69f5a076dc31ae2cd26854cc2a4c516eb62c04ac2454"` [INFO] running `"docker" "rm" "-f" "5d64dd7b67a10f82d2dd69f5a076dc31ae2cd26854cc2a4c516eb62c04ac2454"` [INFO] [stdout] 5d64dd7b67a10f82d2dd69f5a076dc31ae2cd26854cc2a4c516eb62c04ac2454