[INFO] updating cached repository vittsjo/eriksync [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vittsjo/eriksync [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vittsjo/eriksync" "work/ex/clippy-test-run/sources/stable/gh/vittsjo/eriksync"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vittsjo/eriksync'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vittsjo/eriksync" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vittsjo/eriksync"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vittsjo/eriksync'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f9de935c144d6561f7c970c1d4c6b07e3873dcc9 [INFO] sha for GitHub repo vittsjo/eriksync: f9de935c144d6561f7c970c1d4c6b07e3873dcc9 [INFO] validating manifest of vittsjo/eriksync on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vittsjo/eriksync on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vittsjo/eriksync [INFO] finished frobbing vittsjo/eriksync [INFO] frobbed toml for vittsjo/eriksync written to work/ex/clippy-test-run/sources/stable/gh/vittsjo/eriksync/Cargo.toml [INFO] started frobbing vittsjo/eriksync [INFO] finished frobbing vittsjo/eriksync [INFO] frobbed toml for vittsjo/eriksync written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vittsjo/eriksync/Cargo.toml [INFO] crate vittsjo/eriksync has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vittsjo/eriksync against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vittsjo/eriksync:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 22ff6729044a74a1d086a32ca59c34fb651fb7dd97b5631d6ba1c0af9fc6d825 [INFO] running `"docker" "start" "-a" "22ff6729044a74a1d086a32ca59c34fb651fb7dd97b5631d6ba1c0af9fc6d825"` [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking xdg v2.1.0 [INFO] [stderr] Checking serde v1.0.15 [INFO] [stderr] Checking errln v0.1.0 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Compiling serde_derive_internals v0.16.0 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking app_dirs v1.1.1 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Compiling serde_derive v1.0.15 [INFO] [stderr] Checking serde_yaml v0.7.1 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking serde_json v1.0.3 [INFO] [stderr] Checking eriksync v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eriksync/config/node.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eriksync/config/target.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eriksync/config/target.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eriksync/config/node.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eriksync/config/target.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eriksync/config/target.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: variant `yaml` should have a camel case name such as `Yaml` [INFO] [stderr] --> src/eriksync/config/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | yaml, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `json` should have a camel case name such as `Json` [INFO] [stderr] --> src/eriksync/config/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | json, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `toml` should have a camel case name such as `Toml` [INFO] [stderr] --> src/eriksync/config/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | toml, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `eriksync::config::Config` [INFO] [stderr] --> src/eriksync/config/mod.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new() -> Self { [INFO] [stderr] 64 | | Config { [INFO] [stderr] 65 | | nodes: HashMap::new(), [INFO] [stderr] 66 | | targets: HashMap::new(), [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `toml::from_str` doesn't need a mutable reference [INFO] [stderr] --> src/eriksync/config/mod.rs:89:32 [INFO] [stderr] | [INFO] [stderr] 89 | toml::from_str(&mut buf).map_err(|e| e.to_string()) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eriksync/config/mod.rs:202:39 [INFO] [stderr] | [INFO] [stderr] 202 | pub fn get_node(&self, node_name: &String) -> Option<&Node> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eriksync/config/mod.rs:206:43 [INFO] [stderr] | [INFO] [stderr] 206 | pub fn get_target(&self, target_name: &String) -> Option<&Target> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eriksync/config/mod.rs:210:44 [INFO] [stderr] | [INFO] [stderr] 210 | pub fn contains_node(&self, node_name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eriksync/config/mod.rs:214:48 [INFO] [stderr] | [INFO] [stderr] 214 | pub fn contains_target(&self, target_name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rsync_command/mod.rs:15:32 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn show_commands(commands: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[RsyncCommand]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rsync_command/mod.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn run_commands(commands: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[RsyncCommand]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rsync_command/mod.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | node_name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rsync_command/mod.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | target_list: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/utils/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | String::from(std::env::var("HOME").unwrap_or_default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `std::env::var("HOME").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/utils/mod.rs:10:8 [INFO] [stderr] | [INFO] [stderr] 10 | if path_str.len() > 0 && path_str.chars().nth(0).unwrap() == '~' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | let mut iter = values.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: variant `yaml` should have a camel case name such as `Yaml` [INFO] [stderr] --> src/eriksync/config/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | yaml, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `json` should have a camel case name such as `Json` [INFO] [stderr] --> src/eriksync/config/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | json, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant `toml` should have a camel case name such as `Toml` [INFO] [stderr] --> src/eriksync/config/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | toml, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `eriksync::config::Config` [INFO] [stderr] --> src/eriksync/config/mod.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | / pub fn new() -> Self { [INFO] [stderr] 64 | | Config { [INFO] [stderr] 65 | | nodes: HashMap::new(), [INFO] [stderr] 66 | | targets: HashMap::new(), [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `toml::from_str` doesn't need a mutable reference [INFO] [stderr] --> src/eriksync/config/mod.rs:89:32 [INFO] [stderr] | [INFO] [stderr] 89 | toml::from_str(&mut buf).map_err(|e| e.to_string()) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eriksync/config/mod.rs:202:39 [INFO] [stderr] | [INFO] [stderr] 202 | pub fn get_node(&self, node_name: &String) -> Option<&Node> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eriksync/config/mod.rs:206:43 [INFO] [stderr] | [INFO] [stderr] 206 | pub fn get_target(&self, target_name: &String) -> Option<&Target> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eriksync/config/mod.rs:210:44 [INFO] [stderr] | [INFO] [stderr] 210 | pub fn contains_node(&self, node_name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/eriksync/config/mod.rs:214:48 [INFO] [stderr] | [INFO] [stderr] 214 | pub fn contains_target(&self, target_name: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rsync_command/mod.rs:15:32 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn show_commands(commands: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[RsyncCommand]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rsync_command/mod.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn run_commands(commands: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[RsyncCommand]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rsync_command/mod.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | node_name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/rsync_command/mod.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | target_list: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/utils/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | String::from(std::env::var("HOME").unwrap_or_default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `std::env::var("HOME").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/utils/mod.rs:10:8 [INFO] [stderr] | [INFO] [stderr] 10 | if path_str.len() > 0 && path_str.chars().nth(0).unwrap() == '~' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | let mut iter = values.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `values` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.02s [INFO] running `"docker" "inspect" "22ff6729044a74a1d086a32ca59c34fb651fb7dd97b5631d6ba1c0af9fc6d825"` [INFO] running `"docker" "rm" "-f" "22ff6729044a74a1d086a32ca59c34fb651fb7dd97b5631d6ba1c0af9fc6d825"` [INFO] [stdout] 22ff6729044a74a1d086a32ca59c34fb651fb7dd97b5631d6ba1c0af9fc6d825