[INFO] updating cached repository vittsjo/axdot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vittsjo/axdot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vittsjo/axdot" "work/ex/clippy-test-run/sources/stable/gh/vittsjo/axdot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vittsjo/axdot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vittsjo/axdot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vittsjo/axdot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vittsjo/axdot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a5877039a5c459b11add59797f6946abcf1d0e8f [INFO] sha for GitHub repo vittsjo/axdot: a5877039a5c459b11add59797f6946abcf1d0e8f [INFO] validating manifest of vittsjo/axdot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vittsjo/axdot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vittsjo/axdot [INFO] finished frobbing vittsjo/axdot [INFO] frobbed toml for vittsjo/axdot written to work/ex/clippy-test-run/sources/stable/gh/vittsjo/axdot/Cargo.toml [INFO] started frobbing vittsjo/axdot [INFO] finished frobbing vittsjo/axdot [INFO] frobbed toml for vittsjo/axdot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vittsjo/axdot/Cargo.toml [INFO] crate vittsjo/axdot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vittsjo/axdot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vittsjo/axdot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35c6b91a84e863be92bcf919d23596a73eeaad9a615046961a312226ef263b14 [INFO] running `"docker" "start" "-a" "35c6b91a84e863be92bcf919d23596a73eeaad9a615046961a312226ef263b14"` [INFO] [stderr] Compiling serde v1.0.57 [INFO] [stderr] Checking errln v0.1.0 [INFO] [stderr] Compiling syn v0.13.10 [INFO] [stderr] Checking copy_dir v0.1.2 [INFO] [stderr] Compiling serde_derive v1.0.57 [INFO] [stderr] Checking serde_yaml v0.7.4 [INFO] [stderr] Checking serde_json v1.0.17 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking axdot v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | return Err(format!("Failed to detect format from {:?} ", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Failed to detect format from {:?} ", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/utils.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / if path.exists() { [INFO] [stderr] 87 | | if replace || ask_user(format!("{:?} exist, delete it? [Y/n]", path)) { [INFO] [stderr] 88 | | return remove_all(dry, path); [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | if path.exists() && (replace || ask_user(format!("{:?} exist, delete it? [Y/n]", path))) { [INFO] [stderr] 87 | return remove_all(dry, path); [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | return Err(format!("Failed to detect format from {:?} ", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Failed to detect format from {:?} ", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/utils.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | / if path.exists() { [INFO] [stderr] 87 | | if replace || ask_user(format!("{:?} exist, delete it? [Y/n]", path)) { [INFO] [stderr] 88 | | return remove_all(dry, path); [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 86 | if path.exists() && (replace || ask_user(format!("{:?} exist, delete it? [Y/n]", path))) { [INFO] [stderr] 87 | return remove_all(dry, path); [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `toml::from_str` doesn't need a mutable reference [INFO] [stderr] --> src/config.rs:122:32 [INFO] [stderr] | [INFO] [stderr] 122 | toml::from_str(&mut buf).map_err(|e| e.to_string()) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/utils.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / for line in stdin.lock().lines() { [INFO] [stderr] 20 | | return line.unwrap().clone(); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/utils.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | String::from(std::env::var("HOME").unwrap_or_default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `std::env::var("HOME").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/utils.rs:44:8 [INFO] [stderr] | [INFO] [stderr] 44 | if path_str.len() > 0 && path_str.chars().nth(0).unwrap() == '~' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/utils.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | std::fs::remove_file(path.clone()).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 158 | std::fs::remove_file(&(*path).clone()).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 158 | std::fs::remove_file(&std::path::Path::clone(path)).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/utils.rs:164:33 [INFO] [stderr] | [INFO] [stderr] 164 | std::fs::remove_dir_all(path.clone()).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 164 | std::fs::remove_dir_all(&(*path).clone()).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 164 | std::fs::remove_dir_all(&std::path::Path::clone(path)).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:213:14 [INFO] [stderr] | [INFO] [stderr] 213 | command: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | let replace = matches.is_present("replace") || false; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches.is_present("replace")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | let replace = cmd.is_present("replace") || false; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cmd.is_present("replace")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `axdot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: The function/method `toml::from_str` doesn't need a mutable reference [INFO] [stderr] --> src/config.rs:122:32 [INFO] [stderr] | [INFO] [stderr] 122 | toml::from_str(&mut buf).map_err(|e| e.to_string()) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/utils.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | / for line in stdin.lock().lines() { [INFO] [stderr] 20 | | return line.unwrap().clone(); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/utils.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | String::from(std::env::var("HOME").unwrap_or_default()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `std::env::var("HOME").unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/utils.rs:44:8 [INFO] [stderr] | [INFO] [stderr] 44 | if path_str.len() > 0 && path_str.chars().nth(0).unwrap() == '~' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/utils.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | std::fs::remove_file(path.clone()).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 158 | std::fs::remove_file(&(*path).clone()).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 158 | std::fs::remove_file(&std::path::Path::clone(path)).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/utils.rs:164:33 [INFO] [stderr] | [INFO] [stderr] 164 | std::fs::remove_dir_all(path.clone()).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 164 | std::fs::remove_dir_all(&(*path).clone()).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 164 | std::fs::remove_dir_all(&std::path::Path::clone(path)).map(|_| ()).map_err( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:213:14 [INFO] [stderr] | [INFO] [stderr] 213 | command: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:26:19 [INFO] [stderr] | [INFO] [stderr] 26 | let replace = matches.is_present("replace") || false; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches.is_present("replace")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | let replace = cmd.is_present("replace") || false; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cmd.is_present("replace")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `axdot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "35c6b91a84e863be92bcf919d23596a73eeaad9a615046961a312226ef263b14"` [INFO] running `"docker" "rm" "-f" "35c6b91a84e863be92bcf919d23596a73eeaad9a615046961a312226ef263b14"` [INFO] [stdout] 35c6b91a84e863be92bcf919d23596a73eeaad9a615046961a312226ef263b14