[INFO] updating cached repository vitorhnn/sliding-puzzle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vitorhnn/sliding-puzzle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vitorhnn/sliding-puzzle" "work/ex/clippy-test-run/sources/stable/gh/vitorhnn/sliding-puzzle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vitorhnn/sliding-puzzle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vitorhnn/sliding-puzzle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitorhnn/sliding-puzzle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitorhnn/sliding-puzzle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 76ee6d9d5032c082a0ed87dfe9304a53bfea475a [INFO] sha for GitHub repo vitorhnn/sliding-puzzle: 76ee6d9d5032c082a0ed87dfe9304a53bfea475a [INFO] validating manifest of vitorhnn/sliding-puzzle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vitorhnn/sliding-puzzle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vitorhnn/sliding-puzzle [INFO] finished frobbing vitorhnn/sliding-puzzle [INFO] frobbed toml for vitorhnn/sliding-puzzle written to work/ex/clippy-test-run/sources/stable/gh/vitorhnn/sliding-puzzle/Cargo.toml [INFO] started frobbing vitorhnn/sliding-puzzle [INFO] finished frobbing vitorhnn/sliding-puzzle [INFO] frobbed toml for vitorhnn/sliding-puzzle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitorhnn/sliding-puzzle/Cargo.toml [INFO] crate vitorhnn/sliding-puzzle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vitorhnn/sliding-puzzle against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vitorhnn/sliding-puzzle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 59ab9ba482f878d34e7f3e0d8ce573f34c20565c48af5ea8633aa929282a3657 [INFO] running `"docker" "start" "-a" "59ab9ba482f878d34e7f3e0d8ce573f34c20565c48af5ea8633aa929282a3657"` [INFO] [stderr] Compiling matrixmultiply v0.1.14 [INFO] [stderr] Checking rawpointer v0.1.0 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Checking alga v0.5.3 [INFO] [stderr] Checking nalgebra v0.14.1 [INFO] [stderr] Checking slidepuzzle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | return sum; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `sum` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:157:42 [INFO] [stderr] | [INFO] [stderr] 157 | head.up(&goal).and_then(|x| Some(push_if_unique(x, &mut heap, &mut explored))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 157 | head.up(&goal).and_then(|x| Some(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:158:44 [INFO] [stderr] | [INFO] [stderr] 158 | head.down(&goal).and_then(|x| Some(push_if_unique(x, &mut heap, &mut explored))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 158 | head.down(&goal).and_then(|x| Some(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:159:44 [INFO] [stderr] | [INFO] [stderr] 159 | head.left(&goal).and_then(|x| Some(push_if_unique(x, &mut heap, &mut explored))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 159 | head.left(&goal).and_then(|x| Some(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:160:45 [INFO] [stderr] | [INFO] [stderr] 160 | head.right(&goal).and_then(|x| Some(push_if_unique(x, &mut heap, &mut explored))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 160 | head.right(&goal).and_then(|x| Some(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:157:42 [INFO] [stderr] | [INFO] [stderr] 157 | head.up(&goal).and_then(|x| Some(push_if_unique(x, &mut heap, &mut explored))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 157 | head.up(&goal).and_then(|x| Some(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:158:44 [INFO] [stderr] | [INFO] [stderr] 158 | head.down(&goal).and_then(|x| Some(push_if_unique(x, &mut heap, &mut explored))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 158 | head.down(&goal).and_then(|x| Some(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:159:44 [INFO] [stderr] | [INFO] [stderr] 159 | head.left(&goal).and_then(|x| Some(push_if_unique(x, &mut heap, &mut explored))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 159 | head.left(&goal).and_then(|x| Some(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/main.rs:160:45 [INFO] [stderr] | [INFO] [stderr] 160 | head.right(&goal).and_then(|x| Some(push_if_unique(x, &mut heap, &mut explored))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 160 | head.right(&goal).and_then(|x| Some(())); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.19s [INFO] running `"docker" "inspect" "59ab9ba482f878d34e7f3e0d8ce573f34c20565c48af5ea8633aa929282a3657"` [INFO] running `"docker" "rm" "-f" "59ab9ba482f878d34e7f3e0d8ce573f34c20565c48af5ea8633aa929282a3657"` [INFO] [stdout] 59ab9ba482f878d34e7f3e0d8ce573f34c20565c48af5ea8633aa929282a3657