[INFO] updating cached repository vitobasso/rust-synth
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/vitobasso/rust-synth
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/vitobasso/rust-synth" "work/ex/clippy-test-run/sources/stable/gh/vitobasso/rust-synth"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vitobasso/rust-synth'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/vitobasso/rust-synth" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitobasso/rust-synth"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitobasso/rust-synth'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] aa6eec88e9b7e76a3f3fc838b966088cf15d1e74
[INFO] sha for GitHub repo vitobasso/rust-synth: aa6eec88e9b7e76a3f3fc838b966088cf15d1e74
[INFO] validating manifest of vitobasso/rust-synth on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of vitobasso/rust-synth on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing vitobasso/rust-synth
[INFO] finished frobbing vitobasso/rust-synth
[INFO] frobbed toml for vitobasso/rust-synth written to work/ex/clippy-test-run/sources/stable/gh/vitobasso/rust-synth/Cargo.toml
[INFO] started frobbing vitobasso/rust-synth
[INFO] finished frobbing vitobasso/rust-synth
[INFO] frobbed toml for vitobasso/rust-synth written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitobasso/rust-synth/Cargo.toml
[INFO] crate vitobasso/rust-synth has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting vitobasso/rust-synth against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vitobasso/rust-synth:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e85ee0a1d3d59a144b052b61f377d264bca068d53b500f4bc01948e3baa7e8aa
[INFO] running `"docker" "start" "-a" "e85ee0a1d3d59a144b052b61f377d264bca068d53b500f4bc01948e3baa7e8aa"`
[INFO] [stderr]     Checking fixedbitset v0.1.9
[INFO] [stderr]     Checking find_folder v0.3.0
[INFO] [stderr]    Compiling alsa-sys v0.1.2
[INFO] [stderr]    Compiling proc-macro2 v0.3.8
[INFO] [stderr]     Checking stb_truetype v0.2.2
[INFO] [stderr]    Compiling quote v0.6.10
[INFO] [stderr]    Compiling glutin v0.17.0
[INFO] [stderr]    Compiling glium v0.22.0
[INFO] [stderr]     Checking ordered-float v0.5.2
[INFO] [stderr]     Checking petgraph v0.4.13
[INFO] [stderr]    Compiling syn v0.15.18
[INFO] [stderr]     Checking rusttype v0.5.2
[INFO] [stderr]     Checking winit v0.16.2
[INFO] [stderr]    Compiling quote v0.5.2
[INFO] [stderr]    Compiling syn v0.13.11
[INFO] [stderr]     Checking cpal v0.8.2
[INFO] [stderr]     Checking daggy v0.5.0
[INFO] [stderr]    Compiling serde_derive v1.0.80
[INFO] [stderr]    Compiling num-derive v0.2.3
[INFO] [stderr]    Compiling conrod_derive v0.1.2
[INFO] [stderr]     Checking pistoncore-input v0.21.0
[INFO] [stderr]     Checking conrod v0.61.1
[INFO] [stderr]     Checking rust-synth v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/gui/window.rs:33:23
[INFO] [stderr]    |
[INFO] [stderr] 33 |     const FONT_PATH: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/assets/fonts/VT323-Regular.ttf");
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/gui/window.rs:33:23
[INFO] [stderr]    |
[INFO] [stderr] 33 |     const FONT_PATH: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/assets/fonts/VT323-Regular.ttf");
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/audio_out.rs:51:18
[INFO] [stderr]    |
[INFO] [stderr] 51 |         (value * std::i16::MAX as f64) as i16
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(std::i16::MAX)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/audio_out.rs:56:32
[INFO] [stderr]    |
[INFO] [stderr] 56 |         ((value * 0.5 + 0.5) * std::u16::MAX as f64) as u16
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(std::u16::MAX)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/synth/controller.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 | /         match cmd_in.try_recv() {
[INFO] [stderr] 15 | |             Ok(command) => state.interpret(command),
[INFO] [stderr] 16 | |             _ => (),
[INFO] [stderr] 17 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Ok(command) = cmd_in.try_recv() { state.interpret(command) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/synth/controller.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         state.arpeggiator.as_mut()
[INFO] [stderr] 19 | |             .and_then(|arp| arp.next())
[INFO] [stderr] 20 | |             .map(|cmd| state.interpret(cmd));
[INFO] [stderr]    | |____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 |         if let Some(cmd) = state.arpeggiator.as_mut()
[INFO] [stderr] 19 |             .and_then(|arp| arp.next()) { state.interpret(cmd) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/synth/controller.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |            state.instrument.next_sample().map(|sample|
[INFO] [stderr]    |   _________^
[INFO] [stderr]    |  |_________|
[INFO] [stderr]    | ||
[INFO] [stderr] 23 | ||             signal_out.send(sample).expect("Failed to send a sample")
[INFO] [stderr] 24 | ||         );
[INFO] [stderr]    | ||_________^- help: try this: `if let Some(sample) = state.instrument.next_sample() { signal_out.send(sample).expect("Failed to send a sample") }`
[INFO] [stderr]    | |__________|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/synth/instrument.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 |         self.voice.as_mut().map(|v| v.release());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: try this: `if let Some(v) = self.voice.as_mut() { v.release() }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/audio_out.rs:51:18
[INFO] [stderr]    |
[INFO] [stderr] 51 |         (value * std::i16::MAX as f64) as i16
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(std::i16::MAX)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/audio_out.rs:56:32
[INFO] [stderr]    |
[INFO] [stderr] 56 |         ((value * 0.5 + 0.5) * std::u16::MAX as f64) as u16
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(std::u16::MAX)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/synth/controller.rs:14:9
[INFO] [stderr]    |
[INFO] [stderr] 14 | /         match cmd_in.try_recv() {
[INFO] [stderr] 15 | |             Ok(command) => state.interpret(command),
[INFO] [stderr] 16 | |             _ => (),
[INFO] [stderr] 17 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Ok(command) = cmd_in.try_recv() { state.interpret(command) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/synth/controller.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         state.arpeggiator.as_mut()
[INFO] [stderr] 19 | |             .and_then(|arp| arp.next())
[INFO] [stderr] 20 | |             .map(|cmd| state.interpret(cmd));
[INFO] [stderr]    | |____________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 18 |         if let Some(cmd) = state.arpeggiator.as_mut()
[INFO] [stderr] 19 |             .and_then(|arp| arp.next()) { state.interpret(cmd) }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/synth/controller.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |            state.instrument.next_sample().map(|sample|
[INFO] [stderr]    |   _________^
[INFO] [stderr]    |  |_________|
[INFO] [stderr]    | ||
[INFO] [stderr] 23 | ||             signal_out.send(sample).expect("Failed to send a sample")
[INFO] [stderr] 24 | ||         );
[INFO] [stderr]    | ||_________^- help: try this: `if let Some(sample) = state.instrument.next_sample() { signal_out.send(sample).expect("Failed to send a sample") }`
[INFO] [stderr]    | |__________|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/synth/instrument.rs:52:25
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let transpose = self.transpose.clone();
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.transpose`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/synth/instrument.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         self.transpose = self.transpose + value
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.transpose += value`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/synth/instrument.rs:123:9
[INFO] [stderr]     |
[INFO] [stderr] 123 |         self.clock = self.clock + 1.0;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.clock += 1.0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/synth/instrument.rs:42:9
[INFO] [stderr]    |
[INFO] [stderr] 42 |         self.voice.as_mut().map(|v| v.release());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: try this: `if let Some(v) = self.voice.as_mut() { v.release() }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/synth/instrument.rs:52:25
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let transpose = self.transpose.clone();
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.transpose`
[INFO] [stderr] error: useless lint attribute
[INFO] [stderr]  --> src/synth/pitch.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | #[derive(Clone, Copy, PartialEq, Debug, FromPrimitive)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::useless_attribute)] on by default
[INFO] [stderr] 
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/synth/instrument.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         self.transpose = self.transpose + value
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.transpose += value`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/synth/pitch.rs:24:35
[INFO] [stderr]    |
[INFO] [stderr] 24 |         PitchClass::from_index(i).expect(format!("Failed to get PitchClass for i={}", i).as_str())
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to get PitchClass for i={}", i))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr] 
[INFO] [stderr]    --> src/synth/instrument.rs:123:9
[INFO] [stderr]     |
[INFO] [stderr] 123 |         self.clock = self.clock + 1.0;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.clock += 1.0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: useless lint attribute
[INFO] [stderr]  --> src/synth/pitch.rs:9:1
[INFO] [stderr]   |
[INFO] [stderr] 9 | #[derive(Clone, Copy, PartialEq, Debug, FromPrimitive)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[deny(clippy::useless_attribute)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/synth/pitch.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn freq(&self) -> Hz {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/synth/pitch.rs:76:14
[INFO] [stderr]    |
[INFO] [stderr] 76 |     fn index(&self) -> usize{
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/synth/pitch.rs:77:29
[INFO] [stderr]    |
[INFO] [stderr] 77 |         (self.octave * 12 + self.class.clone() as i8) as usize
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.class`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/synth/pitch.rs:84:18
[INFO] [stderr]    |
[INFO] [stderr] 84 |                 .expect(format!("Failed to get PitchClass for i={}", i).as_str())
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to get PitchClass for i={}", i))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/synth/pitch.rs:24:35
[INFO] [stderr]    |
[INFO] [stderr] 24 |         PitchClass::from_index(i).expect(format!("Failed to get PitchClass for i={}", i).as_str())
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to get PitchClass for i={}", i))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/synth/pitch.rs:70:17
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn freq(&self) -> Hz {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/synth/pitch.rs:76:14
[INFO] [stderr]    |
[INFO] [stderr] 76 |     fn index(&self) -> usize{
[INFO] [stderr]    |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/synth/pitch.rs:77:29
[INFO] [stderr]    |
[INFO] [stderr] 77 |         (self.octave * 12 + self.class.clone() as i8) as usize
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.class`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/synth/pitch.rs:84:18
[INFO] [stderr]    |
[INFO] [stderr] 84 |                 .expect(format!("Failed to get PitchClass for i={}", i).as_str())
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to get PitchClass for i={}", i))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: useless lint attribute
[INFO] [stderr]  --> src/synth/diatonic_scale.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | #[derive(Clone, Copy, PartialEq, Debug, FromPrimitive)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/synth/diatonic_scale.rs:21:14
[INFO] [stderr]    |
[INFO] [stderr] 21 |             .expect(format!("Failed to get ScaleDegree for i={}", i).as_str())
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to get ScaleDegree for i={}", i))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: useless lint attribute
[INFO] [stderr]  --> src/synth/diatonic_scale.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | #[derive(Clone, Copy, PartialEq, Debug, FromPrimitive)]
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/synth/diatonic_scale.rs:21:14
[INFO] [stderr]    |
[INFO] [stderr] 21 |             .expect(format!("Failed to get ScaleDegree for i={}", i).as_str())
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Failed to get ScaleDegree for i={}", i))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/synth/arpeggiator.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 | /     pub fn next(&mut self) -> Option<Command> {
[INFO] [stderr] 39 | |         self.pulse.read()
[INFO] [stderr] 40 | |             .and_then(|_| self.next_event())
[INFO] [stderr] 41 | |             .and_then(|e| self.update_and_command(e))
[INFO] [stderr] 42 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
[INFO] [stderr]   --> src/synth/arpeggiator.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |         events.iter().nth(self.index).cloned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_nth)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/gui/window.rs:26:42
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build();
[INFO] [stderr]    |                                          ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/gui/window.rs:26:56
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build();
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/gui/keymap.rs:10:18
[INFO] [stderr]    |
[INFO] [stderr] 10 |                 .or(transpose(key))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| transpose(key))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]  --> src/gui/keymap.rs:9:18
[INFO] [stderr]   |
[INFO] [stderr] 9 |                 .or(patches(key))
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^ help: try this: `or_else(|| patches(key))`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/gui/keymap.rs:24:17
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn pitches(key: &input::Key) -> Option<Pitch> { //TODO shift => sharp pitches
[INFO] [stderr]    |                 ^^^^^^^^^^^ help: consider passing by value instead: `input::Key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/gui/keymap.rs:66:17
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn patches(key: &input::Key) -> Option<Command> {
[INFO] [stderr]    |                 ^^^^^^^^^^^ help: consider passing by value instead: `input::Key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/gui/keymap.rs:82:19
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn transpose(key: &input::Key) -> Option<Command> {
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: consider passing by value instead: `input::Key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:18:23
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let sample_rate = format.sample_rate.0 as Hz;
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(format.sample_rate.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]   --> src/synth/arpeggiator.rs:38:5
[INFO] [stderr]    |
[INFO] [stderr] 38 | /     pub fn next(&mut self) -> Option<Command> {
[INFO] [stderr] 39 | |         self.pulse.read()
[INFO] [stderr] 40 | |             .and_then(|_| self.next_event())
[INFO] [stderr] 41 | |             .and_then(|e| self.update_and_command(e))
[INFO] [stderr] 42 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
[INFO] [stderr]   --> src/synth/arpeggiator.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |         events.iter().nth(self.index).cloned()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_nth)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/gui/window.rs:26:42
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build();
[INFO] [stderr]    |                                          ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/gui/window.rs:26:56
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]).build();
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust-synth`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]   --> src/gui/keymap.rs:10:18
[INFO] [stderr]    |
[INFO] [stderr] 10 |                 .or(transpose(key))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| transpose(key))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]  --> src/gui/keymap.rs:9:18
[INFO] [stderr]   |
[INFO] [stderr] 9 |                 .or(patches(key))
[INFO] [stderr]   |                  ^^^^^^^^^^^^^^^^ help: try this: `or_else(|| patches(key))`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/gui/keymap.rs:24:17
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn pitches(key: &input::Key) -> Option<Pitch> { //TODO shift => sharp pitches
[INFO] [stderr]    |                 ^^^^^^^^^^^ help: consider passing by value instead: `input::Key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/gui/keymap.rs:66:17
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn patches(key: &input::Key) -> Option<Command> {
[INFO] [stderr]    |                 ^^^^^^^^^^^ help: consider passing by value instead: `input::Key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/gui/keymap.rs:82:19
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn transpose(key: &input::Key) -> Option<Command> {
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: consider passing by value instead: `input::Key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:18:23
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let sample_rate = format.sample_rate.0 as Hz;
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(format.sample_rate.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rust-synth`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "e85ee0a1d3d59a144b052b61f377d264bca068d53b500f4bc01948e3baa7e8aa"`
[INFO] running `"docker" "rm" "-f" "e85ee0a1d3d59a144b052b61f377d264bca068d53b500f4bc01948e3baa7e8aa"`
[INFO] [stdout] e85ee0a1d3d59a144b052b61f377d264bca068d53b500f4bc01948e3baa7e8aa