[INFO] updating cached repository vitberget/diceware-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vitberget/diceware-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vitberget/diceware-rust" "work/ex/clippy-test-run/sources/stable/gh/vitberget/diceware-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vitberget/diceware-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vitberget/diceware-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitberget/diceware-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitberget/diceware-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 04a4f7bd33e8fad013b33520cc343dc5e4cd6017 [INFO] sha for GitHub repo vitberget/diceware-rust: 04a4f7bd33e8fad013b33520cc343dc5e4cd6017 [INFO] validating manifest of vitberget/diceware-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vitberget/diceware-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vitberget/diceware-rust [INFO] finished frobbing vitberget/diceware-rust [INFO] frobbed toml for vitberget/diceware-rust written to work/ex/clippy-test-run/sources/stable/gh/vitberget/diceware-rust/Cargo.toml [INFO] started frobbing vitberget/diceware-rust [INFO] finished frobbing vitberget/diceware-rust [INFO] frobbed toml for vitberget/diceware-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vitberget/diceware-rust/Cargo.toml [INFO] crate vitberget/diceware-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vitberget/diceware-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vitberget/diceware-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7166d47936b8b8d132d7f93f25b15be34f1efaa749ed9d73b010a502c622c73a [INFO] running `"docker" "start" "-a" "7166d47936b8b8d132d7f93f25b15be34f1efaa749ed9d73b010a502c622c73a"` [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking diceware-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/diceit/dice.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return rand::thread_rng().gen_range(1, 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rand::thread_rng().gen_range(1, 7)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/diceit/dice.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return rand::thread_rng().gen_range(1, 7); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `rand::thread_rng().gen_range(1, 7)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/diceit/dice.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/diceit/replace_char.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return w2; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `w2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/diceit/mod.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return word_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `word_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/diceit/dice.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return v; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/diceit/replace_char.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return w2; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `w2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/diceit/mod.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return word_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `word_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diceit/dice.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/diceit/replace_char.rs:3:31 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn replace_char(the_word: &String, r2: u8, r3: u8, r4: u8) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diceit/replace_char.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/diceit/mod.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | let key = String::from(*split.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&split[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/diceit/mod.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let val = String::from(*split.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&split[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/diceit/mod.rs:73:44 [INFO] [stderr] | [INFO] [stderr] 73 | print!(" ({:.1} bits of entropy)", (word_count as f32) * 12.9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(word_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diceit/mod.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/diceit/mod.rs:100:44 [INFO] [stderr] | [INFO] [stderr] 100 | print!(" ({:.1} bits of entropy)", (word_count as f32) * 12.9 + 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(word_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/diceit/mod.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | .map(|w| w.len()) [INFO] [stderr] | __________________________^ [INFO] [stderr] 108 | | .fold(0, |a, s| a + s); [INFO] [stderr] | |______________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/diceit/mod.rs:118:58 [INFO] [stderr] | [INFO] [stderr] 118 | let rolls_words: Vec<&String> = rolls.iter().map(|r| words.get(r).unwrap()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&words[r]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diceit/dice.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/diceit/replace_char.rs:3:31 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn replace_char(the_word: &String, r2: u8, r3: u8, r4: u8) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diceit/replace_char.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/diceit/mod.rs:39:33 [INFO] [stderr] | [INFO] [stderr] 39 | let key = String::from(*split.get(0).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&split[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/diceit/mod.rs:42:37 [INFO] [stderr] | [INFO] [stderr] 42 | let val = String::from(*split.get(1).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&split[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/diceit/mod.rs:73:44 [INFO] [stderr] | [INFO] [stderr] 73 | print!(" ({:.1} bits of entropy)", (word_count as f32) * 12.9); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(word_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/diceit/mod.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/diceit/mod.rs:100:44 [INFO] [stderr] | [INFO] [stderr] 100 | print!(" ({:.1} bits of entropy)", (word_count as f32) * 12.9 + 10.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(word_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/diceit/mod.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | .map(|w| w.len()) [INFO] [stderr] | __________________________^ [INFO] [stderr] 108 | | .fold(0, |a, s| a + s); [INFO] [stderr] | |______________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/diceit/mod.rs:118:58 [INFO] [stderr] | [INFO] [stderr] 118 | let rolls_words: Vec<&String> = rolls.iter().map(|r| words.get(r).unwrap()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&words[r]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.94s [INFO] running `"docker" "inspect" "7166d47936b8b8d132d7f93f25b15be34f1efaa749ed9d73b010a502c622c73a"` [INFO] running `"docker" "rm" "-f" "7166d47936b8b8d132d7f93f25b15be34f1efaa749ed9d73b010a502c622c73a"` [INFO] [stdout] 7166d47936b8b8d132d7f93f25b15be34f1efaa749ed9d73b010a502c622c73a