[INFO] updating cached repository vishusandy/passgen
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/vishusandy/passgen
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/vishusandy/passgen" "work/ex/clippy-test-run/sources/stable/gh/vishusandy/passgen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vishusandy/passgen'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/vishusandy/passgen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/passgen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/passgen'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 767b9c1246d1b416dc735b42cd4a7a5b68039919
[INFO] sha for GitHub repo vishusandy/passgen: 767b9c1246d1b416dc735b42cd4a7a5b68039919
[INFO] validating manifest of vishusandy/passgen on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of vishusandy/passgen on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing vishusandy/passgen
[INFO] finished frobbing vishusandy/passgen
[INFO] frobbed toml for vishusandy/passgen written to work/ex/clippy-test-run/sources/stable/gh/vishusandy/passgen/Cargo.toml
[INFO] started frobbing vishusandy/passgen
[INFO] finished frobbing vishusandy/passgen
[INFO] frobbed toml for vishusandy/passgen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vishusandy/passgen/Cargo.toml
[INFO] crate vishusandy/passgen has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting vishusandy/passgen against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vishusandy/passgen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dcaec94b890e3cae3a5f492c56006cd50d78ccb614f4b0fb57d33f68193654e3
[INFO] running `"docker" "start" "-a" "dcaec94b890e3cae3a5f492c56006cd50d78ccb614f4b0fb57d33f68193654e3"`
[INFO] [stderr]     Checking libc v0.2.26
[INFO] [stderr]     Checking serde v1.0.10
[INFO] [stderr]     Checking num-complex v0.1.40
[INFO] [stderr]     Checking rmp v0.8.6
[INFO] [stderr]     Checking rand v0.3.15
[INFO] [stderr]     Checking time v0.1.38
[INFO] [stderr]     Checking num-bigint v0.1.40
[INFO] [stderr]     Checking num-rational v0.1.39
[INFO] [stderr]     Checking num v0.1.40
[INFO] [stderr]     Checking rmp-serde v0.13.4
[INFO] [stderr]     Checking passgen v0.7.5 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `Zero`
[INFO] [stderr]  --> src/dict_helpers.rs:7:16
[INFO] [stderr]   |
[INFO] [stderr] 7 | use num::{Num, Zero, One};
[INFO] [stderr]   |                ^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ops::Add`
[INFO] [stderr]  --> src/dict_helpers.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::ops::Add;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/dict_helpers.rs:54:24
[INFO] [stderr]    |
[INFO] [stderr] 54 |                   } else {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 55 | |                     if w == word {
[INFO] [stderr] 56 | |                         return true;
[INFO] [stderr] 57 | |                     }
[INFO] [stderr] 58 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 54 |                 } else if w == word {
[INFO] [stderr] 55 |     return true;
[INFO] [stderr] 56 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/dict_helpers.rs:49:28
[INFO] [stderr]    |
[INFO] [stderr] 49 |                       } else {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 50 | |                         if &w[..t-1] == word {
[INFO] [stderr] 51 | |                             return true;
[INFO] [stderr] 52 | |                         }
[INFO] [stderr] 53 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 49 |                     } else if &w[..t-1] == word {
[INFO] [stderr] 50 |     return true;
[INFO] [stderr] 51 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/passwords.rs:76:17
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 step3
[INFO] [stderr]    |                 ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/passwords.rs:69:29
[INFO] [stderr]    |
[INFO] [stderr] 69 |                   let step3 = match punclen > 0 {
[INFO] [stderr]    |  _____________________________^
[INFO] [stderr] 70 | |                     true if nums && numlen > 0 => 
[INFO] [stderr] 71 | |                         add_punctuation(&add_numbers(&step2, numlen), punclen, special), //add numbers to ensure at least one number
[INFO] [stderr] 72 | |                     true => 
[INFO] [stderr] 73 | |                         add_punctuation(&step2, punclen, special), // add just punctuation to ensure a punctuation character
[INFO] [stderr] 74 | |                     false => step2, // nothing to add
[INFO] [stderr] 75 | |                 };
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/passwords.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 |         step4
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/passwords.rs:102:21
[INFO] [stderr]     |
[INFO] [stderr] 102 |           let step4 = if nums && numlen > 0 {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 103 | |             add_numbers(&step3, numlen)
[INFO] [stderr] 104 | |         } else {
[INFO] [stderr] 105 | |             step3
[INFO] [stderr] 106 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/passwords.rs:161:17
[INFO] [stderr]     |
[INFO] [stderr] 161 |                 step3
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/passwords.rs:154:29
[INFO] [stderr]     |
[INFO] [stderr] 154 |                   let step3 = match punclen > 0 {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 155 | |                     true if nums && numlen > 0 => 
[INFO] [stderr] 156 | |                         add_punctuation(&add_numbers(&step2, numlen), punclen, special), //add numbers to ensure at least one number
[INFO] [stderr] 157 | |                     true => 
[INFO] [stderr] 158 | |                         add_punctuation(&step2, punclen, special), // add just punctuation to ensure a punctuation character
[INFO] [stderr] 159 | |                     false => step2, // nothing to add
[INFO] [stderr] 160 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/passwords.rs:191:9
[INFO] [stderr]     |
[INFO] [stderr] 191 |         step4
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/passwords.rs:186:21
[INFO] [stderr]     |
[INFO] [stderr] 186 |           let step4 = if nums && numlen > 0 {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 187 | |             add_numbers(&step3, numlen)
[INFO] [stderr] 188 | |         } else {
[INFO] [stderr] 189 | |             step3
[INFO] [stderr] 190 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/passwords.rs:263:32
[INFO] [stderr]     |
[INFO] [stderr] 263 |                             && ( (i < word.len()-1 && !is_basic_vowel(&word[i+1..i+2])) /* || i == word.len()-1 */ ) // next letter is a consonant, do not check if end of word because that was already checked
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Zero`
[INFO] [stderr]  --> src/dict_helpers.rs:7:16
[INFO] [stderr]   |
[INFO] [stderr] 7 | use num::{Num, Zero, One};
[INFO] [stderr]   |                ^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ops::Add`
[INFO] [stderr]  --> src/dict_helpers.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::ops::Add;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/dict_helpers.rs:54:24
[INFO] [stderr]    |
[INFO] [stderr] 54 |                   } else {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 55 | |                     if w == word {
[INFO] [stderr] 56 | |                         return true;
[INFO] [stderr] 57 | |                     }
[INFO] [stderr] 58 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 54 |                 } else if w == word {
[INFO] [stderr] 55 |     return true;
[INFO] [stderr] 56 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/dict_helpers.rs:49:28
[INFO] [stderr]    |
[INFO] [stderr] 49 |                       } else {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 50 | |                         if &w[..t-1] == word {
[INFO] [stderr] 51 | |                             return true;
[INFO] [stderr] 52 | |                         }
[INFO] [stderr] 53 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 49 |                     } else if &w[..t-1] == word {
[INFO] [stderr] 50 |     return true;
[INFO] [stderr] 51 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/passwords.rs:76:17
[INFO] [stderr]    |
[INFO] [stderr] 76 |                 step3
[INFO] [stderr]    |                 ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/passwords.rs:69:29
[INFO] [stderr]    |
[INFO] [stderr] 69 |                   let step3 = match punclen > 0 {
[INFO] [stderr]    |  _____________________________^
[INFO] [stderr] 70 | |                     true if nums && numlen > 0 => 
[INFO] [stderr] 71 | |                         add_punctuation(&add_numbers(&step2, numlen), punclen, special), //add numbers to ensure at least one number
[INFO] [stderr] 72 | |                     true => 
[INFO] [stderr] 73 | |                         add_punctuation(&step2, punclen, special), // add just punctuation to ensure a punctuation character
[INFO] [stderr] 74 | |                     false => step2, // nothing to add
[INFO] [stderr] 75 | |                 };
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/passwords.rs:107:9
[INFO] [stderr]     |
[INFO] [stderr] 107 |         step4
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/passwords.rs:102:21
[INFO] [stderr]     |
[INFO] [stderr] 102 |           let step4 = if nums && numlen > 0 {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 103 | |             add_numbers(&step3, numlen)
[INFO] [stderr] 104 | |         } else {
[INFO] [stderr] 105 | |             step3
[INFO] [stderr] 106 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/passwords.rs:161:17
[INFO] [stderr]     |
[INFO] [stderr] 161 |                 step3
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/passwords.rs:154:29
[INFO] [stderr]     |
[INFO] [stderr] 154 |                   let step3 = match punclen > 0 {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 155 | |                     true if nums && numlen > 0 => 
[INFO] [stderr] 156 | |                         add_punctuation(&add_numbers(&step2, numlen), punclen, special), //add numbers to ensure at least one number
[INFO] [stderr] 157 | |                     true => 
[INFO] [stderr] 158 | |                         add_punctuation(&step2, punclen, special), // add just punctuation to ensure a punctuation character
[INFO] [stderr] 159 | |                     false => step2, // nothing to add
[INFO] [stderr] 160 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/passwords.rs:191:9
[INFO] [stderr]     |
[INFO] [stderr] 191 |         step4
[INFO] [stderr]     |         ^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/passwords.rs:186:21
[INFO] [stderr]     |
[INFO] [stderr] 186 |           let step4 = if nums && numlen > 0 {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 187 | |             add_numbers(&step3, numlen)
[INFO] [stderr] 188 | |         } else {
[INFO] [stderr] 189 | |             step3
[INFO] [stderr] 190 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/passwords.rs:263:32
[INFO] [stderr]     |
[INFO] [stderr] 263 |                             && ( (i < word.len()-1 && !is_basic_vowel(&word[i+1..i+2])) /* || i == word.len()-1 */ ) // next letter is a consonant, do not check if end of word because that was already checked
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `One`
[INFO] [stderr]  --> src/dict_helpers.rs:7:22
[INFO] [stderr]   |
[INFO] [stderr] 7 | use num::{Num, Zero, One};
[INFO] [stderr]   |                      ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `One`
[INFO] [stderr]  --> src/dict_helpers.rs:7:22
[INFO] [stderr]   |
[INFO] [stderr] 7 | use num::{Num, Zero, One};
[INFO] [stderr]   |                      ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ns`
[INFO] [stderr]    --> src/passwords.rs:208:13
[INFO] [stderr]     |
[INFO] [stderr] 208 |     let mut ns: [usize; 50] = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49];
[INFO] [stderr]     |             ^^ help: consider using `_ns` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `ns`
[INFO] [stderr]    --> src/passwords.rs:208:13
[INFO] [stderr]     |
[INFO] [stderr] 208 |     let mut ns: [usize; 50] = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49];
[INFO] [stderr]     |             ^^ help: consider using `_ns` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/passwords.rs:208:9
[INFO] [stderr]     |
[INFO] [stderr] 208 |     let mut ns: [usize; 50] = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49];
[INFO] [stderr]     |         ----^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `find_plurals`
[INFO] [stderr]    --> src/dict_helpers.rs:254:1
[INFO] [stderr]     |
[INFO] [stderr] 254 | pub fn find_plurals(savefile: &str) -> Vec<&'static str> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/passwords.rs:208:9
[INFO] [stderr]     |
[INFO] [stderr] 208 |     let mut ns: [usize; 50] = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49];
[INFO] [stderr]     |         ----^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `find_plurals`
[INFO] [stderr]    --> src/dict_helpers.rs:254:1
[INFO] [stderr]     |
[INFO] [stderr] 254 | pub fn find_plurals(savefile: &str) -> Vec<&'static str> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `version`.
[INFO] [stderr]   --> src/dict_helpers.rs:31:14
[INFO] [stderr]    |
[INFO] [stderr] 31 |     for i in 0..version.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 31 |     for <item> in &version {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `v`.
[INFO] [stderr]   --> src/dict_helpers.rs:43:22
[INFO] [stderr]    |
[INFO] [stderr] 43 |             for i in 0..v.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 43 |             for <item> in &v {
[INFO] [stderr]    |                 ^^^^^^    ^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/dict_helpers.rs:81:16
[INFO] [stderr]    |
[INFO] [stderr] 81 |             if &DICT_A_LIST[DICT_A_INDEXES[i].1 .0 .. DICT_A_INDEXES[i].1 .1].len() != &(DICT_A_INDEXES[i].1 .1 - DICT_A_INDEXES[i].1 .0) {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 81 |             if DICT_A_LIST[DICT_A_INDEXES[i].1 .0 .. DICT_A_INDEXES[i].1 .1].len() != (DICT_A_INDEXES[i].1 .1 - DICT_A_INDEXES[i].1 .0) {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/dict_helpers.rs:97:16
[INFO] [stderr]    |
[INFO] [stderr] 97 |             if &DICT_NP_LIST[DICT_NP_INDEXES[i].1 .0 .. DICT_NP_INDEXES[i].1 .1].len() != &(DICT_NP_INDEXES[i].1 .1 - DICT_NP_INDEXES[i].1 .0) {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 97 |             if DICT_NP_LIST[DICT_NP_INDEXES[i].1 .0 .. DICT_NP_INDEXES[i].1 .1].len() != (DICT_NP_INDEXES[i].1 .1 - DICT_NP_INDEXES[i].1 .0) {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `v`.
[INFO] [stderr]    --> src/dict_helpers.rs:221:22
[INFO] [stderr]     |
[INFO] [stderr] 221 |             for i in 0..v.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 221 |             for <item> in &v {
[INFO] [stderr]     |                 ^^^^^^    ^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `PLURALS`.
[INFO] [stderr]    --> src/dict_helpers.rs:227:18
[INFO] [stderr]     |
[INFO] [stderr] 227 |         for i in 0..PLURALS.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 227 |         for <item> in &PLURALS {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `DICT_A_LIST`.
[INFO] [stderr]    --> src/dict_helpers.rs:238:22
[INFO] [stderr]     |
[INFO] [stderr] 238 |             for i in v.0 .. v.1+1 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 238 |             for <item> in DICT_A_LIST.iter().take(v.1+1).skip(v.0) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/dict_helpers.rs:238:22
[INFO] [stderr]     |
[INFO] [stderr] 238 |             for i in v.0 .. v.1+1 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^ help: use: `v.0..=v.1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `a` is only used to index `DICT_A_LIST`.
[INFO] [stderr]    --> src/dict_helpers.rs:261:14
[INFO] [stderr]     |
[INFO] [stderr] 261 |     for a in 0..DICT_A_LIST.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 261 |     for <item> in &DICT_A_LIST {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `plurals`.
[INFO] [stderr]    --> src/dict_helpers.rs:269:14
[INFO] [stderr]     |
[INFO] [stderr] 269 |     for i in 0..plurals.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 269 |     for <item> in &plurals {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/dict_helpers.rs:272:9
[INFO] [stderr]     |
[INFO] [stderr] 272 |         f.write(plurals[i].as_bytes());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/dict_helpers.rs:274:9
[INFO] [stderr]     |
[INFO] [stderr] 274 |         f.write(b"\n");
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `version`.
[INFO] [stderr]   --> src/dict_helpers.rs:31:14
[INFO] [stderr]    |
[INFO] [stderr] 31 |     for i in 0..version.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 31 |     for <item> in &version {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `v`.
[INFO] [stderr]   --> src/dict_helpers.rs:43:22
[INFO] [stderr]    |
[INFO] [stderr] 43 |             for i in 0..v.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 43 |             for <item> in &v {
[INFO] [stderr]    |                 ^^^^^^    ^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/dict_helpers.rs:81:16
[INFO] [stderr]    |
[INFO] [stderr] 81 |             if &DICT_A_LIST[DICT_A_INDEXES[i].1 .0 .. DICT_A_INDEXES[i].1 .1].len() != &(DICT_A_INDEXES[i].1 .1 - DICT_A_INDEXES[i].1 .0) {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 81 |             if DICT_A_LIST[DICT_A_INDEXES[i].1 .0 .. DICT_A_INDEXES[i].1 .1].len() != (DICT_A_INDEXES[i].1 .1 - DICT_A_INDEXES[i].1 .0) {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]   --> src/dict_helpers.rs:97:16
[INFO] [stderr]    |
[INFO] [stderr] 97 |             if &DICT_NP_LIST[DICT_NP_INDEXES[i].1 .0 .. DICT_NP_INDEXES[i].1 .1].len() != &(DICT_NP_INDEXES[i].1 .1 - DICT_NP_INDEXES[i].1 .0) {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]    |
[INFO] [stderr] 97 |             if DICT_NP_LIST[DICT_NP_INDEXES[i].1 .0 .. DICT_NP_INDEXES[i].1 .1].len() != (DICT_NP_INDEXES[i].1 .1 - DICT_NP_INDEXES[i].1 .0) {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `v`.
[INFO] [stderr]    --> src/dict_helpers.rs:221:22
[INFO] [stderr]     |
[INFO] [stderr] 221 |             for i in 0..v.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 221 |             for <item> in &v {
[INFO] [stderr]     |                 ^^^^^^    ^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `PLURALS`.
[INFO] [stderr]    --> src/dict_helpers.rs:227:18
[INFO] [stderr]     |
[INFO] [stderr] 227 |         for i in 0..PLURALS.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 227 |         for <item> in &PLURALS {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `DICT_A_LIST`.
[INFO] [stderr]    --> src/dict_helpers.rs:238:22
[INFO] [stderr]     |
[INFO] [stderr] 238 |             for i in v.0 .. v.1+1 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 238 |             for <item> in DICT_A_LIST.iter().take(v.1+1).skip(v.0) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/dict_helpers.rs:238:22
[INFO] [stderr]     |
[INFO] [stderr] 238 |             for i in v.0 .. v.1+1 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^ help: use: `v.0..=v.1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `a` is only used to index `DICT_A_LIST`.
[INFO] [stderr]    --> src/dict_helpers.rs:261:14
[INFO] [stderr]     |
[INFO] [stderr] 261 |     for a in 0..DICT_A_LIST.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 261 |     for <item> in &DICT_A_LIST {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `plurals`.
[INFO] [stderr]    --> src/dict_helpers.rs:269:14
[INFO] [stderr]     |
[INFO] [stderr] 269 |     for i in 0..plurals.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 269 |     for <item> in &plurals {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/dict_helpers.rs:272:9
[INFO] [stderr]     |
[INFO] [stderr] 272 |         f.write(plurals[i].as_bytes());
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/dict_helpers.rs:274:9
[INFO] [stderr]     |
[INFO] [stderr] 274 |         f.write(b"\n");
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/passwords.rs:27:1
[INFO] [stderr]     |
[INFO] [stderr] 27  | / pub fn transform2(dict: &HashMap<u8, &'static [&'static str]>, testword: bool, length: u8, caps: bool, nums: bool, leet: bool, punc: bool, special: &str) -> String {
[INFO] [stderr] 28  | |     // leet_speak numbers punctuation 
[INFO] [stderr] 29  | |     // let words = Vec::<String>::new();
[INFO] [stderr] 30  | |     let minword = 2;
[INFO] [stderr] ...   |
[INFO] [stderr] 108 | |     }
[INFO] [stderr] 109 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/passwords.rs:37:39
[INFO] [stderr]    |
[INFO] [stderr] 37 |       } else if punc && len < minword+1 {
[INFO] [stderr]    |  _______________________________________^
[INFO] [stderr] 38 | |         len = minword+1;
[INFO] [stderr] 39 | |     } else if len < minword {
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/passwords.rs:35:39
[INFO] [stderr]    |
[INFO] [stderr] 35 |       } else if nums && len < minword+1 {
[INFO] [stderr]    |  _______________________________________^
[INFO] [stderr] 36 | |         len = minword+1;
[INFO] [stderr] 37 | |     } else if punc && len < minword+1 {
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/passwords.rs:65:29
[INFO] [stderr]    |
[INFO] [stderr] 65 |                   let step2 = match caps {
[INFO] [stderr]    |  _____________________________^
[INFO] [stderr] 66 | |                     true => capitalize(&w),
[INFO] [stderr] 67 | |                     false => w,
[INFO] [stderr] 68 | |                 };
[INFO] [stderr]    | |_________________^ help: consider using an if/else expression: `if caps { capitalize(&w) } else { w }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/passwords.rs:69:29
[INFO] [stderr]    |
[INFO] [stderr] 69 |                   let step3 = match punclen > 0 {
[INFO] [stderr]    |  _____________________________^
[INFO] [stderr] 70 | |                     true if nums && numlen > 0 => 
[INFO] [stderr] 71 | |                         add_punctuation(&add_numbers(&step2, numlen), punclen, special), //add numbers to ensure at least one number
[INFO] [stderr] 72 | |                     true => 
[INFO] [stderr] 73 | |                         add_punctuation(&step2, punclen, special), // add just punctuation to ensure a punctuation character
[INFO] [stderr] 74 | |                     false => step2, // nothing to add
[INFO] [stderr] 75 | |                 };
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/passwords.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 | /         let mut checkword: bool = testword;
[INFO] [stderr] 82 | |         if nums || punc {
[INFO] [stderr] 83 | |             checkword = false;
[INFO] [stderr] 84 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> checkword = if nums || punc { false } else { testword };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/passwords.rs:93:21
[INFO] [stderr]    |
[INFO] [stderr] 93 |           let step2 = match caps {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 94 | |             true => capitalize(&step1),
[INFO] [stderr] 95 | |             false => step1,
[INFO] [stderr] 96 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if caps { capitalize(&step1) } else { step1 }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/passwords.rs:112:1
[INFO] [stderr]     |
[INFO] [stderr] 112 | / pub fn transform(dict: &HashMap<u8, (usize, usize)>, testword: bool, length: u8, caps: bool, nums: bool, leet: bool, punc: bool, special: &str) -> String {
[INFO] [stderr] 113 | |     // leet_speak numbers punctuation 
[INFO] [stderr] 114 | |     // let words = Vec::<String>::new();
[INFO] [stderr] 115 | |     let minword = 2;
[INFO] [stderr] ...   |
[INFO] [stderr] 192 | |     }
[INFO] [stderr] 193 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/passwords.rs:122:39
[INFO] [stderr]     |
[INFO] [stderr] 122 |       } else if punc && len < minword+1 {
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 123 | |         len = minword+1;
[INFO] [stderr] 124 | |     } else if len < minword {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/passwords.rs:120:39
[INFO] [stderr]     |
[INFO] [stderr] 120 |       } else if nums && len < minword+1 {
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 121 | |         len = minword+1;
[INFO] [stderr] 122 | |     } else if punc && len < minword+1 {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/passwords.rs:150:29
[INFO] [stderr]     |
[INFO] [stderr] 150 |                   let step2 = match caps {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 151 | |                     true => capitalize(&w),
[INFO] [stderr] 152 | |                     false => w,
[INFO] [stderr] 153 | |                 };
[INFO] [stderr]     | |_________________^ help: consider using an if/else expression: `if caps { capitalize(&w) } else { w }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/passwords.rs:154:29
[INFO] [stderr]     |
[INFO] [stderr] 154 |                   let step3 = match punclen > 0 {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 155 | |                     true if nums && numlen > 0 => 
[INFO] [stderr] 156 | |                         add_punctuation(&add_numbers(&step2, numlen), punclen, special), //add numbers to ensure at least one number
[INFO] [stderr] 157 | |                     true => 
[INFO] [stderr] 158 | |                         add_punctuation(&step2, punclen, special), // add just punctuation to ensure a punctuation character
[INFO] [stderr] 159 | |                     false => step2, // nothing to add
[INFO] [stderr] 160 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/passwords.rs:166:9
[INFO] [stderr]     |
[INFO] [stderr] 166 | /         let mut checkword: bool = testword;
[INFO] [stderr] 167 | |         if nums || punc {
[INFO] [stderr] 168 | |             checkword = false;
[INFO] [stderr] 169 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> checkword = if nums || punc { false } else { testword };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/passwords.rs:177:21
[INFO] [stderr]     |
[INFO] [stderr] 177 |           let step2 = match caps {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 178 | |             true => capitalize(&step1),
[INFO] [stderr] 179 | |             false => step1,
[INFO] [stderr] 180 | |         };
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if caps { capitalize(&step1) } else { step1 }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `letters`.
[INFO] [stderr]    --> src/passwords.rs:217:14
[INFO] [stderr]     |
[INFO] [stderr] 217 |     for i in 0..num {
[INFO] [stderr]     |              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 217 |     for <item> in letters.iter().take(num) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:237:28
[INFO] [stderr]     |
[INFO] [stderr] 237 |         let letter = &word[i..i+1];
[INFO] [stderr]     |                            ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:272:42
[INFO] [stderr]     |
[INFO] [stderr] 272 |                       && !is_vowel(&word[i..i+1]) // not necessary in most situations
[INFO] [stderr]     |                                          ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:342:32
[INFO] [stderr]     |
[INFO] [stderr] 342 |             new.push_str(&word[l..l+1].to_uppercase());
[INFO] [stderr]     |                                ^^^^^^ help: use: `l..=l`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:344:32
[INFO] [stderr]     |
[INFO] [stderr] 344 |             new.push_str(&word[l..l+1]);
[INFO] [stderr]     |                                ^^^^^^ help: use: `l..=l`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:358:21
[INFO] [stderr]     |
[INFO] [stderr] 358 |         match &word[i..i+1] {
[INFO] [stderr]     |                     ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/passwords.rs:367:8
[INFO] [stderr]     |
[INFO] [stderr] 367 |     if idxs.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!idxs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `idxs`.
[INFO] [stderr]    --> src/passwords.rs:371:18
[INFO] [stderr]     |
[INFO] [stderr] 371 |         for i in 0..num {
[INFO] [stderr]     |                  ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 371 |         for <item> in idxs.iter().take(num) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:382:37
[INFO] [stderr]     |
[INFO] [stderr] 382 |                 let c = match &word[i..i+1] {
[INFO] [stderr]     |                                     ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:398:36
[INFO] [stderr]     |
[INFO] [stderr] 398 |                 new.push_str(&word[i..i+1]);
[INFO] [stderr]     |                                    ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:470:43
[INFO] [stderr]     |
[INFO] [stderr] 470 |         new = random_insert(&new, &pchars[ins..ins+1])
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: use: `ins..=ins`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `passgen`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/passwords.rs:27:1
[INFO] [stderr]     |
[INFO] [stderr] 27  | / pub fn transform2(dict: &HashMap<u8, &'static [&'static str]>, testword: bool, length: u8, caps: bool, nums: bool, leet: bool, punc: bool, special: &str) -> String {
[INFO] [stderr] 28  | |     // leet_speak numbers punctuation 
[INFO] [stderr] 29  | |     // let words = Vec::<String>::new();
[INFO] [stderr] 30  | |     let minword = 2;
[INFO] [stderr] ...   |
[INFO] [stderr] 108 | |     }
[INFO] [stderr] 109 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/passwords.rs:37:39
[INFO] [stderr]    |
[INFO] [stderr] 37 |       } else if punc && len < minword+1 {
[INFO] [stderr]    |  _______________________________________^
[INFO] [stderr] 38 | |         len = minword+1;
[INFO] [stderr] 39 | |     } else if len < minword {
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/passwords.rs:35:39
[INFO] [stderr]    |
[INFO] [stderr] 35 |       } else if nums && len < minword+1 {
[INFO] [stderr]    |  _______________________________________^
[INFO] [stderr] 36 | |         len = minword+1;
[INFO] [stderr] 37 | |     } else if punc && len < minword+1 {
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/passwords.rs:65:29
[INFO] [stderr]    |
[INFO] [stderr] 65 |                   let step2 = match caps {
[INFO] [stderr]    |  _____________________________^
[INFO] [stderr] 66 | |                     true => capitalize(&w),
[INFO] [stderr] 67 | |                     false => w,
[INFO] [stderr] 68 | |                 };
[INFO] [stderr]    | |_________________^ help: consider using an if/else expression: `if caps { capitalize(&w) } else { w }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/passwords.rs:69:29
[INFO] [stderr]    |
[INFO] [stderr] 69 |                   let step3 = match punclen > 0 {
[INFO] [stderr]    |  _____________________________^
[INFO] [stderr] 70 | |                     true if nums && numlen > 0 => 
[INFO] [stderr] 71 | |                         add_punctuation(&add_numbers(&step2, numlen), punclen, special), //add numbers to ensure at least one number
[INFO] [stderr] 72 | |                     true => 
[INFO] [stderr] 73 | |                         add_punctuation(&step2, punclen, special), // add just punctuation to ensure a punctuation character
[INFO] [stderr] 74 | |                     false => step2, // nothing to add
[INFO] [stderr] 75 | |                 };
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/passwords.rs:81:9
[INFO] [stderr]    |
[INFO] [stderr] 81 | /         let mut checkword: bool = testword;
[INFO] [stderr] 82 | |         if nums || punc {
[INFO] [stderr] 83 | |             checkword = false;
[INFO] [stderr] 84 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> checkword = if nums || punc { false } else { testword };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/passwords.rs:93:21
[INFO] [stderr]    |
[INFO] [stderr] 93 |           let step2 = match caps {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 94 | |             true => capitalize(&step1),
[INFO] [stderr] 95 | |             false => step1,
[INFO] [stderr] 96 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if caps { capitalize(&step1) } else { step1 }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/passwords.rs:112:1
[INFO] [stderr]     |
[INFO] [stderr] 112 | / pub fn transform(dict: &HashMap<u8, (usize, usize)>, testword: bool, length: u8, caps: bool, nums: bool, leet: bool, punc: bool, special: &str) -> String {
[INFO] [stderr] 113 | |     // leet_speak numbers punctuation 
[INFO] [stderr] 114 | |     // let words = Vec::<String>::new();
[INFO] [stderr] 115 | |     let minword = 2;
[INFO] [stderr] ...   |
[INFO] [stderr] 192 | |     }
[INFO] [stderr] 193 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/passwords.rs:122:39
[INFO] [stderr]     |
[INFO] [stderr] 122 |       } else if punc && len < minword+1 {
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 123 | |         len = minword+1;
[INFO] [stderr] 124 | |     } else if len < minword {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/passwords.rs:120:39
[INFO] [stderr]     |
[INFO] [stderr] 120 |       } else if nums && len < minword+1 {
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 121 | |         len = minword+1;
[INFO] [stderr] 122 | |     } else if punc && len < minword+1 {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/passwords.rs:150:29
[INFO] [stderr]     |
[INFO] [stderr] 150 |                   let step2 = match caps {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 151 | |                     true => capitalize(&w),
[INFO] [stderr] 152 | |                     false => w,
[INFO] [stderr] 153 | |                 };
[INFO] [stderr]     | |_________________^ help: consider using an if/else expression: `if caps { capitalize(&w) } else { w }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/passwords.rs:154:29
[INFO] [stderr]     |
[INFO] [stderr] 154 |                   let step3 = match punclen > 0 {
[INFO] [stderr]     |  _____________________________^
[INFO] [stderr] 155 | |                     true if nums && numlen > 0 => 
[INFO] [stderr] 156 | |                         add_punctuation(&add_numbers(&step2, numlen), punclen, special), //add numbers to ensure at least one number
[INFO] [stderr] 157 | |                     true => 
[INFO] [stderr] 158 | |                         add_punctuation(&step2, punclen, special), // add just punctuation to ensure a punctuation character
[INFO] [stderr] 159 | |                     false => step2, // nothing to add
[INFO] [stderr] 160 | |                 };
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/passwords.rs:166:9
[INFO] [stderr]     |
[INFO] [stderr] 166 | /         let mut checkword: bool = testword;
[INFO] [stderr] 167 | |         if nums || punc {
[INFO] [stderr] 168 | |             checkword = false;
[INFO] [stderr] 169 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> checkword = if nums || punc { false } else { testword };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/passwords.rs:177:21
[INFO] [stderr]     |
[INFO] [stderr] 177 |           let step2 = match caps {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 178 | |             true => capitalize(&step1),
[INFO] [stderr] 179 | |             false => step1,
[INFO] [stderr] 180 | |         };
[INFO] [stderr]     | |_________^ help: consider using an if/else expression: `if caps { capitalize(&step1) } else { step1 }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `letters`.
[INFO] [stderr]    --> src/passwords.rs:217:14
[INFO] [stderr]     |
[INFO] [stderr] 217 |     for i in 0..num {
[INFO] [stderr]     |              ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 217 |     for <item> in letters.iter().take(num) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:237:28
[INFO] [stderr]     |
[INFO] [stderr] 237 |         let letter = &word[i..i+1];
[INFO] [stderr]     |                            ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:272:42
[INFO] [stderr]     |
[INFO] [stderr] 272 |                       && !is_vowel(&word[i..i+1]) // not necessary in most situations
[INFO] [stderr]     |                                          ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:342:32
[INFO] [stderr]     |
[INFO] [stderr] 342 |             new.push_str(&word[l..l+1].to_uppercase());
[INFO] [stderr]     |                                ^^^^^^ help: use: `l..=l`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:344:32
[INFO] [stderr]     |
[INFO] [stderr] 344 |             new.push_str(&word[l..l+1]);
[INFO] [stderr]     |                                ^^^^^^ help: use: `l..=l`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:358:21
[INFO] [stderr]     |
[INFO] [stderr] 358 |         match &word[i..i+1] {
[INFO] [stderr]     |                     ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/passwords.rs:367:8
[INFO] [stderr]     |
[INFO] [stderr] 367 |     if idxs.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!idxs.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `idxs`.
[INFO] [stderr]    --> src/passwords.rs:371:18
[INFO] [stderr]     |
[INFO] [stderr] 371 |         for i in 0..num {
[INFO] [stderr]     |                  ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 371 |         for <item> in idxs.iter().take(num) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:382:37
[INFO] [stderr]     |
[INFO] [stderr] 382 |                 let c = match &word[i..i+1] {
[INFO] [stderr]     |                                     ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:398:36
[INFO] [stderr]     |
[INFO] [stderr] 398 |                 new.push_str(&word[i..i+1]);
[INFO] [stderr]     |                                    ^^^^^^ help: use: `i..=i`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/passwords.rs:470:43
[INFO] [stderr]     |
[INFO] [stderr] 470 |         new = random_insert(&new, &pchars[ins..ins+1])
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: use: `ins..=ins`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `passgen`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "dcaec94b890e3cae3a5f492c56006cd50d78ccb614f4b0fb57d33f68193654e3"`
[INFO] running `"docker" "rm" "-f" "dcaec94b890e3cae3a5f492c56006cd50d78ccb614f4b0fb57d33f68193654e3"`
[INFO] [stdout] dcaec94b890e3cae3a5f492c56006cd50d78ccb614f4b0fb57d33f68193654e3