[INFO] updating cached repository viperscape/interstratis [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/viperscape/interstratis [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/viperscape/interstratis" "work/ex/clippy-test-run/sources/stable/gh/viperscape/interstratis"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/viperscape/interstratis'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/viperscape/interstratis" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/viperscape/interstratis"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/viperscape/interstratis'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb6d373e418a4089561eb1e57c1d2a212b8f7b3b [INFO] sha for GitHub repo viperscape/interstratis: cb6d373e418a4089561eb1e57c1d2a212b8f7b3b [INFO] validating manifest of viperscape/interstratis on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of viperscape/interstratis on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing viperscape/interstratis [INFO] finished frobbing viperscape/interstratis [INFO] frobbed toml for viperscape/interstratis written to work/ex/clippy-test-run/sources/stable/gh/viperscape/interstratis/Cargo.toml [INFO] started frobbing viperscape/interstratis [INFO] finished frobbing viperscape/interstratis [INFO] frobbed toml for viperscape/interstratis written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/viperscape/interstratis/Cargo.toml [INFO] crate viperscape/interstratis has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting viperscape/interstratis against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/viperscape/interstratis:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9373c80b5169935d54b3716173a395ff91ae5abbdd27ac317a05ffcb3093bcec [INFO] running `"docker" "start" "-a" "9373c80b5169935d54b3716173a395ff91ae5abbdd27ac317a05ffcb3093bcec"` [INFO] [stderr] Checking groupable v0.2.0 [INFO] [stderr] Checking lichen v0.3.7 [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking mustache v0.8.1 [INFO] [stderr] Checking cookie v0.9.1 [INFO] [stderr] Checking hyper v0.10.12 [INFO] [stderr] Checking nickel v0.10.0 [INFO] [stderr] Checking interstratis v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | stories: stories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `stories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | stories: stories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `stories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | const SERVER_ADDR: &'static str = "0.0.0.0:6060"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/samples.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | assert!(paths.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!paths.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> tests/samples.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | if let Ok(_) = r.read_to_string(&mut src) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 39 | | match Parser::parse_blocks(&src) { [INFO] [stderr] 40 | | Ok(b) => { [INFO] [stderr] 41 | | let mut env = b.into_env(); [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | else { panic!("ERROR: Unable to parse source, {:?}", p) } [INFO] [stderr] | |_____________________________________________________________________- help: try this: `if r.read_to_string(&mut src).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/samples.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | assert!(env.src.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!env.src.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/samples.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | assert!(vars.len() > 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vars.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:231:24 [INFO] [stderr] | [INFO] [stderr] 231 | if vars.len() > 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vars.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:232:25 [INFO] [stderr] | [INFO] [stderr] 232 | nexts.len() > 0 { break } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!nexts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:237:20 [INFO] [stderr] | [INFO] [stderr] 237 | if vars.len() < 1 && nexts.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vars.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:237:38 [INFO] [stderr] | [INFO] [stderr] 237 | if vars.len() < 1 && nexts.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nexts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:242:20 [INFO] [stderr] | [INFO] [stderr] 242 | if nexts.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nexts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/lifecycle.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / match r { [INFO] [stderr] 25 | | Err(e) => { println!("ERR:{:?}",e) } [INFO] [stderr] 26 | | _ => {} [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = r { println!("ERR:{:?}",e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/lifecycle.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if key == &key_ { [INFO] [stderr] | ^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `key_` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:21 [INFO] [stderr] | [INFO] [stderr] 27 | const SERVER_ADDR: &'static str = "0.0.0.0:6060"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:231:24 [INFO] [stderr] | [INFO] [stderr] 231 | if vars.len() > 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vars.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:232:25 [INFO] [stderr] | [INFO] [stderr] 232 | nexts.len() > 0 { break } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!nexts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:237:20 [INFO] [stderr] | [INFO] [stderr] 237 | if vars.len() < 1 && nexts.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vars.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:237:38 [INFO] [stderr] | [INFO] [stderr] 237 | if vars.len() < 1 && nexts.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nexts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:242:20 [INFO] [stderr] | [INFO] [stderr] 242 | if nexts.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `nexts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/lifecycle.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / match r { [INFO] [stderr] 25 | | Err(e) => { println!("ERR:{:?}",e) } [INFO] [stderr] 26 | | _ => {} [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = r { println!("ERR:{:?}",e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/lifecycle.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if key == &key_ { [INFO] [stderr] | ^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `key_` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.31s [INFO] running `"docker" "inspect" "9373c80b5169935d54b3716173a395ff91ae5abbdd27ac317a05ffcb3093bcec"` [INFO] running `"docker" "rm" "-f" "9373c80b5169935d54b3716173a395ff91ae5abbdd27ac317a05ffcb3093bcec"` [INFO] [stdout] 9373c80b5169935d54b3716173a395ff91ae5abbdd27ac317a05ffcb3093bcec