[INFO] updating cached repository viperscape/capsule [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/viperscape/capsule [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/viperscape/capsule" "work/ex/clippy-test-run/sources/stable/gh/viperscape/capsule"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/viperscape/capsule'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/viperscape/capsule" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/viperscape/capsule"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/viperscape/capsule'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2022f83a24e7fcae37a9be65f15f259d11ac6e08 [INFO] sha for GitHub repo viperscape/capsule: 2022f83a24e7fcae37a9be65f15f259d11ac6e08 [INFO] validating manifest of viperscape/capsule on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of viperscape/capsule on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing viperscape/capsule [INFO] finished frobbing viperscape/capsule [INFO] frobbed toml for viperscape/capsule written to work/ex/clippy-test-run/sources/stable/gh/viperscape/capsule/Cargo.toml [INFO] started frobbing viperscape/capsule [INFO] finished frobbing viperscape/capsule [INFO] frobbed toml for viperscape/capsule written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/viperscape/capsule/Cargo.toml [INFO] crate viperscape/capsule has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting viperscape/capsule against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/viperscape/capsule:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 82737a0c085a253ca78a24647ac8a1ce6995b933672048de7ce2467238313474 [INFO] running `"docker" "start" "-a" "82737a0c085a253ca78a24647ac8a1ce6995b933672048de7ce2467238313474"` [INFO] [stderr] Checking nom v2.2.1 [INFO] [stderr] Checking groupable v0.2.0 [INFO] [stderr] Checking base64 v0.5.2 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking mustache v0.8.0 [INFO] [stderr] Checking cookie v0.9.1 [INFO] [stderr] Checking url v1.5.1 [INFO] [stderr] Checking tokio-uds v0.1.5 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking tokio-uds-proto v0.1.0 [INFO] [stderr] Checking plugin v0.2.6 [INFO] [stderr] Checking hyper v0.10.12 [INFO] [stderr] Checking lber v0.1.5 [INFO] [stderr] Checking ldap3 v0.5.0 [INFO] [stderr] Checking nickel v0.10.0 [INFO] [stderr] Checking capsule v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ldap.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | host:host, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | server:server, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | ad:ad, [INFO] [stderr] | ^^^^^ help: replace it with: `ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ldap.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | host:host, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | server:server, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | ad:ad, [INFO] [stderr] | ^^^^^ help: replace it with: `ad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/server.rs:78:37 [INFO] [stderr] | [INFO] [stderr] 78 | / if !username.is_empty() && [INFO] [stderr] 79 | | !password.is_empty() { [INFO] [stderr] 80 | | if ad.auth(&username,&password) { [INFO] [stderr] 81 | | if let Ok(mut clients) = clients.lock() { [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | if !username.is_empty() && [INFO] [stderr] 79 | !password.is_empty() && ad.auth(&username,&password) { [INFO] [stderr] 80 | if let Ok(mut clients) = clients.lock() { [INFO] [stderr] 81 | let sid = random::() .to_string(); [INFO] [stderr] 82 | let cookie_sid = Cookie::new("sid", sid.clone()).to_string(); [INFO] [stderr] 83 | let cookie_username = Cookie::new("username", username.clone()).to_string(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/server.rs:153:29 [INFO] [stderr] | [INFO] [stderr] 153 | / if c.sid == sid { [INFO] [stderr] 154 | | if c.session.elapsed() < Duration::from_secs(max_age) { [INFO] [stderr] 155 | | return true [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 153 | if c.sid == sid && c.session.elapsed() < Duration::from_secs(max_age) { [INFO] [stderr] 154 | return true [INFO] [stderr] 155 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/server.rs:78:37 [INFO] [stderr] | [INFO] [stderr] 78 | / if !username.is_empty() && [INFO] [stderr] 79 | | !password.is_empty() { [INFO] [stderr] 80 | | if ad.auth(&username,&password) { [INFO] [stderr] 81 | | if let Ok(mut clients) = clients.lock() { [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | if !username.is_empty() && [INFO] [stderr] 79 | !password.is_empty() && ad.auth(&username,&password) { [INFO] [stderr] 80 | if let Ok(mut clients) = clients.lock() { [INFO] [stderr] 81 | let sid = random::() .to_string(); [INFO] [stderr] 82 | let cookie_sid = Cookie::new("sid", sid.clone()).to_string(); [INFO] [stderr] 83 | let cookie_username = Cookie::new("username", username.clone()).to_string(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/server.rs:153:29 [INFO] [stderr] | [INFO] [stderr] 153 | / if c.sid == sid { [INFO] [stderr] 154 | | if c.session.elapsed() < Duration::from_secs(max_age) { [INFO] [stderr] 155 | | return true [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 153 | if c.sid == sid && c.session.elapsed() < Duration::from_secs(max_age) { [INFO] [stderr] 154 | return true [INFO] [stderr] 155 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/server.rs:53:30 [INFO] [stderr] | [INFO] [stderr] 53 | self.server.get("/", middleware! [INFO] [stderr] | ______________________________^ [INFO] [stderr] 54 | | { |req, res| [INFO] [stderr] 55 | | if Server::is_auth(req, &clients, max_age) { [INFO] [stderr] 56 | | return res.redirect("/special") [INFO] [stderr] ... | [INFO] [stderr] 59 | | return res.redirect("/login") [INFO] [stderr] 60 | | }); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/server.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | self.server.get("/login", middleware! [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 63 | | { |_rq, res| [INFO] [stderr] 64 | | let mut data = HashMap::new(); [INFO] [stderr] 65 | | data.insert("target","/auth"); [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | return res.render("views/login.html", &data) [INFO] [stderr] 68 | | }); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/server.rs:71:35 [INFO] [stderr] | [INFO] [stderr] 71 | self.server.post("/auth", middleware! [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 72 | | { |req, mut res| [INFO] [stderr] 73 | | let form_data = try_with!(res, req.form_body()); [INFO] [stderr] 74 | | if let Some(username) = form_data.get("username") { [INFO] [stderr] ... | [INFO] [stderr] 102 | | return res.render("views/invalid.html", &data) [INFO] [stderr] 103 | | }); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/server.rs:53:30 [INFO] [stderr] | [INFO] [stderr] 53 | self.server.get("/", middleware! [INFO] [stderr] | ______________________________^ [INFO] [stderr] 54 | | { |req, res| [INFO] [stderr] 55 | | if Server::is_auth(req, &clients, max_age) { [INFO] [stderr] 56 | | return res.redirect("/special") [INFO] [stderr] ... | [INFO] [stderr] 59 | | return res.redirect("/login") [INFO] [stderr] 60 | | }); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/server.rs:62:35 [INFO] [stderr] | [INFO] [stderr] 62 | self.server.get("/login", middleware! [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 63 | | { |_rq, res| [INFO] [stderr] 64 | | let mut data = HashMap::new(); [INFO] [stderr] 65 | | data.insert("target","/auth"); [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | return res.render("views/login.html", &data) [INFO] [stderr] 68 | | }); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/server.rs:71:35 [INFO] [stderr] | [INFO] [stderr] 71 | self.server.post("/auth", middleware! [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 72 | | { |req, mut res| [INFO] [stderr] 73 | | let form_data = try_with!(res, req.form_body()); [INFO] [stderr] 74 | | if let Some(username) = form_data.get("username") { [INFO] [stderr] ... | [INFO] [stderr] 102 | | return res.render("views/invalid.html", &data) [INFO] [stderr] 103 | | }); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ldap.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / let mut host; [INFO] [stderr] 14 | | [INFO] [stderr] 15 | | if config.domain.secure { host = "ldaps://".to_owned(); } [INFO] [stderr] 16 | | else { host = "ldap://".to_owned(); } [INFO] [stderr] | |_____________________________________________^ help: it is more idiomatic to write: `let host = if config.domain.secure { "ldaps://".to_owned() } else { "ldap://".to_owned() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ldap.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | if !username.contains("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ldap.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | / let mut host; [INFO] [stderr] 14 | | [INFO] [stderr] 15 | | if config.domain.secure { host = "ldaps://".to_owned(); } [INFO] [stderr] 16 | | else { host = "ldap://".to_owned(); } [INFO] [stderr] | |_____________________________________________^ help: it is more idiomatic to write: `let host = if config.domain.secure { "ldaps://".to_owned() } else { "ldap://".to_owned() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/ldap.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | if !username.contains("@") { [INFO] [stderr] | ^^^ help: try using a char instead: `'@'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.06s [INFO] running `"docker" "inspect" "82737a0c085a253ca78a24647ac8a1ce6995b933672048de7ce2467238313474"` [INFO] running `"docker" "rm" "-f" "82737a0c085a253ca78a24647ac8a1ce6995b933672048de7ce2467238313474"` [INFO] [stdout] 82737a0c085a253ca78a24647ac8a1ce6995b933672048de7ce2467238313474