[INFO] updating cached repository vincentisambart/parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vincentisambart/parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vincentisambart/parser" "work/ex/clippy-test-run/sources/stable/gh/vincentisambart/parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vincentisambart/parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vincentisambart/parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vincentisambart/parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vincentisambart/parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 67794892048e4a8f1a63f30706172827dfa35e06 [INFO] sha for GitHub repo vincentisambart/parser: 67794892048e4a8f1a63f30706172827dfa35e06 [INFO] validating manifest of vincentisambart/parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vincentisambart/parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vincentisambart/parser [INFO] finished frobbing vincentisambart/parser [INFO] frobbed toml for vincentisambart/parser written to work/ex/clippy-test-run/sources/stable/gh/vincentisambart/parser/Cargo.toml [INFO] started frobbing vincentisambart/parser [INFO] finished frobbing vincentisambart/parser [INFO] frobbed toml for vincentisambart/parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vincentisambart/parser/Cargo.toml [INFO] crate vincentisambart/parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vincentisambart/parser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vincentisambart/parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 23b2d9705206531445d046fd9fda048ef2f8342f2e5516a27e7292cf41d54af3 [INFO] running `"docker" "start" "-a" "23b2d9705206531445d046fd9fda048ef2f8342f2e5516a27e7292cf41d54af3"` [INFO] [stderr] Checking parser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/failable.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | peeked: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/lex.rs:617:5 [INFO] [stderr] | [INFO] [stderr] 617 | / fn read_punctuator(&mut self) -> Result { [INFO] [stderr] 618 | | let punc = match self [INFO] [stderr] 619 | | .scanner [INFO] [stderr] 620 | | .next() [INFO] [stderr] ... | [INFO] [stderr] 807 | | Ok(Token::Punctuator(punc)) [INFO] [stderr] 808 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/mod.rs:426:50 [INFO] [stderr] | [INFO] [stderr] 426 | && params.iter().all(|param| { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 427 | | let FuncParam(name, derivs) = param; [INFO] [stderr] 428 | | name.is_some() && derivs.is_none() [INFO] [stderr] 429 | | }) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser/mod.rs:900:23 [INFO] [stderr] | [INFO] [stderr] 900 | fn is_before_type(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parser/mod.rs:1105:38 [INFO] [stderr] | [INFO] [stderr] 1105 | fn read_declarator(&mut self) -> Result<(Option<(String, Position)>, Vec), ParseError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/failable.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | peeked: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/lex.rs:617:5 [INFO] [stderr] | [INFO] [stderr] 617 | / fn read_punctuator(&mut self) -> Result { [INFO] [stderr] 618 | | let punc = match self [INFO] [stderr] 619 | | .scanner [INFO] [stderr] 620 | | .next() [INFO] [stderr] ... | [INFO] [stderr] 807 | | Ok(Token::Punctuator(punc)) [INFO] [stderr] 808 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lex.rs:1002:16 [INFO] [stderr] | [INFO] [stderr] 1002 | if let Some(_) = iter.next().unwrap() { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 1003 | | panic!("Multiple tokens found in {:}", code); [INFO] [stderr] 1004 | | } [INFO] [stderr] | |_________- help: try this: `if iter.next().unwrap().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/parser/mod.rs:426:50 [INFO] [stderr] | [INFO] [stderr] 426 | && params.iter().all(|param| { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 427 | | let FuncParam(name, derivs) = param; [INFO] [stderr] 428 | | name.is_some() && derivs.is_none() [INFO] [stderr] 429 | | }) { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser/mod.rs:900:23 [INFO] [stderr] | [INFO] [stderr] 900 | fn is_before_type(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parser/mod.rs:1105:38 [INFO] [stderr] | [INFO] [stderr] 1105 | fn read_declarator(&mut self) -> Result<(Option<(String, Position)>, Vec), ParseError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.31s [INFO] running `"docker" "inspect" "23b2d9705206531445d046fd9fda048ef2f8342f2e5516a27e7292cf41d54af3"` [INFO] running `"docker" "rm" "-f" "23b2d9705206531445d046fd9fda048ef2f8342f2e5516a27e7292cf41d54af3"` [INFO] [stdout] 23b2d9705206531445d046fd9fda048ef2f8342f2e5516a27e7292cf41d54af3