[INFO] updating cached repository victorhsieh/sternhalma [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/victorhsieh/sternhalma [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/victorhsieh/sternhalma" "work/ex/clippy-test-run/sources/stable/gh/victorhsieh/sternhalma"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/victorhsieh/sternhalma'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/victorhsieh/sternhalma" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/victorhsieh/sternhalma"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/victorhsieh/sternhalma'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8cc66d13d5d459bf25228411df09c61f63b19b52 [INFO] sha for GitHub repo victorhsieh/sternhalma: 8cc66d13d5d459bf25228411df09c61f63b19b52 [INFO] validating manifest of victorhsieh/sternhalma on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of victorhsieh/sternhalma on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing victorhsieh/sternhalma [INFO] finished frobbing victorhsieh/sternhalma [INFO] frobbed toml for victorhsieh/sternhalma written to work/ex/clippy-test-run/sources/stable/gh/victorhsieh/sternhalma/Cargo.toml [INFO] started frobbing victorhsieh/sternhalma [INFO] finished frobbing victorhsieh/sternhalma [INFO] frobbed toml for victorhsieh/sternhalma written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/victorhsieh/sternhalma/Cargo.toml [INFO] crate victorhsieh/sternhalma has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting victorhsieh/sternhalma against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/victorhsieh/sternhalma:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 277442e1992fc41f5165b27d645acbac24a07d5eb2a1b3ef3a74c2d6e8c8bc81 [INFO] running `"docker" "start" "-a" "277442e1992fc41f5165b27d645acbac24a07d5eb2a1b3ef3a74c2d6e8c8bc81"` [INFO] [stderr] Checking colored v1.6.1 [INFO] [stderr] Checking sternhalma v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | for y in -offset_y..offset_y+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `-offset_y..=offset_y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | for x in -offset_x..offset_x+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `-offset_x..=offset_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `map`. [INFO] [stderr] --> src/main.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for i in 0..map.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for in &map { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | for y in -offset_y..offset_y+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `-offset_y..=offset_y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | for x in -offset_x..offset_x+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `-offset_x..=offset_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `map`. [INFO] [stderr] --> src/main.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | for i in 0..map.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for in &map { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.68s [INFO] running `"docker" "inspect" "277442e1992fc41f5165b27d645acbac24a07d5eb2a1b3ef3a74c2d6e8c8bc81"` [INFO] running `"docker" "rm" "-f" "277442e1992fc41f5165b27d645acbac24a07d5eb2a1b3ef3a74c2d6e8c8bc81"` [INFO] [stdout] 277442e1992fc41f5165b27d645acbac24a07d5eb2a1b3ef3a74c2d6e8c8bc81