[INFO] updating cached repository venoma333/rwebserver
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/venoma333/rwebserver
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/venoma333/rwebserver" "work/ex/clippy-test-run/sources/stable/gh/venoma333/rwebserver"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/venoma333/rwebserver'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/venoma333/rwebserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/venoma333/rwebserver"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/venoma333/rwebserver'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 056fb5d143a308ccedab06aeef30737a35a3ab58
[INFO] sha for GitHub repo venoma333/rwebserver: 056fb5d143a308ccedab06aeef30737a35a3ab58
[INFO] validating manifest of venoma333/rwebserver on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of venoma333/rwebserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing venoma333/rwebserver
[INFO] finished frobbing venoma333/rwebserver
[INFO] frobbed toml for venoma333/rwebserver written to work/ex/clippy-test-run/sources/stable/gh/venoma333/rwebserver/Cargo.toml
[INFO] started frobbing venoma333/rwebserver
[INFO] finished frobbing venoma333/rwebserver
[INFO] frobbed toml for venoma333/rwebserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/venoma333/rwebserver/Cargo.toml
[INFO] crate venoma333/rwebserver has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting venoma333/rwebserver against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/venoma333/rwebserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 87b3b3d4ab3352d369a5d6aeec8fd59210b8f68a2dd096a9fe0f9e5cb6b45e83
[INFO] running `"docker" "start" "-a" "87b3b3d4ab3352d369a5d6aeec8fd59210b8f68a2dd096a9fe0f9e5cb6b45e83"`
[INFO] [stderr]     Checking libc v0.2.40
[INFO] [stderr]     Checking memchr v2.0.1
[INFO] [stderr]     Checking aho-corasick v0.6.4
[INFO] [stderr]     Checking regex v1.0.0
[INFO] [stderr]     Checking rwebserver v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/lib.rs:86:56
[INFO] [stderr]    |
[INFO] [stderr] 86 |     fn handle_client(&mut self, mut stream: TcpStream) -> () {
[INFO] [stderr]    |                                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/lib.rs:86:56
[INFO] [stderr]    |
[INFO] [stderr] 86 |     fn handle_client(&mut self, mut stream: TcpStream) -> () {
[INFO] [stderr]    |                                                        ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/lib.rs:56:16
[INFO] [stderr]    |
[INFO] [stderr] 56 |           if let None = self.matched_path {
[INFO] [stderr]    |  _________-      ^^^^
[INFO] [stderr] 57 | |             None
[INFO] [stderr] 58 | |         } else {
[INFO] [stderr] 59 | |             let mut params = None;
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |             }
[INFO] [stderr] 71 | |         }
[INFO] [stderr]    | |_________- help: try this: `if self.matched_path.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Server`
[INFO] [stderr]    --> src/lib.rs:134:5
[INFO] [stderr]     |
[INFO] [stderr] 134 | /     pub fn new() -> Server {
[INFO] [stderr] 135 | |         Server {
[INFO] [stderr] 136 | |             routes: Arc::new(Mutex::new(Routes {
[INFO] [stderr] 137 | |                 get: Vec::new(),
[INFO] [stderr] ...   |
[INFO] [stderr] 141 | |         }
[INFO] [stderr] 142 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 85  | impl Default for Server {
[INFO] [stderr] 86  |     fn default() -> Self {
[INFO] [stderr] 87  |         Self::new()
[INFO] [stderr] 88  |     }
[INFO] [stderr] 89  | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/lib.rs:56:16
[INFO] [stderr]    |
[INFO] [stderr] 56 |           if let None = self.matched_path {
[INFO] [stderr]    |  _________-      ^^^^
[INFO] [stderr] 57 | |             None
[INFO] [stderr] 58 | |         } else {
[INFO] [stderr] 59 | |             let mut params = None;
[INFO] [stderr] ...  |
[INFO] [stderr] 70 | |             }
[INFO] [stderr] 71 | |         }
[INFO] [stderr]    | |_________- help: try this: `if self.matched_path.is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `Server`
[INFO] [stderr]    --> src/lib.rs:134:5
[INFO] [stderr]     |
[INFO] [stderr] 134 | /     pub fn new() -> Server {
[INFO] [stderr] 135 | |         Server {
[INFO] [stderr] 136 | |             routes: Arc::new(Mutex::new(Routes {
[INFO] [stderr] 137 | |                 get: Vec::new(),
[INFO] [stderr] ...   |
[INFO] [stderr] 141 | |         }
[INFO] [stderr] 142 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 85  | impl Default for Server {
[INFO] [stderr] 86  |     fn default() -> Self {
[INFO] [stderr] 87  |         Self::new()
[INFO] [stderr] 88  |     }
[INFO] [stderr] 89  | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:96:9
[INFO] [stderr]     |
[INFO] [stderr] 96  | /         let mut res: Option<Response> = None;
[INFO] [stderr] 97  | |         if self.request_cache.contains_key(path) {
[INFO] [stderr] 98  | |             res = Some(self.request_cache.get(path).unwrap().clone());
[INFO] [stderr] 99  | |         } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 122 | |             }
[INFO] [stderr] 123 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> res = if self.request_cache.contains_key(path) { Some(self.request_cache.get(path).unwrap().clone()) } else { ..; None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/lib.rs:88:9
[INFO] [stderr]    |
[INFO] [stderr] 88 |         stream.read(&mut buf).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/lib.rs:98:24
[INFO] [stderr]    |
[INFO] [stderr] 98 |             res = Some(self.request_cache.get(path).unwrap().clone());
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.request_cache[path]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:96:9
[INFO] [stderr]     |
[INFO] [stderr] 96  | /         let mut res: Option<Response> = None;
[INFO] [stderr] 97  | |         if self.request_cache.contains_key(path) {
[INFO] [stderr] 98  | |             res = Some(self.request_cache.get(path).unwrap().clone());
[INFO] [stderr] 99  | |         } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 122 | |             }
[INFO] [stderr] 123 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> res = if self.request_cache.contains_key(path) { Some(self.request_cache.get(path).unwrap().clone()) } else { ..; None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/lib.rs:88:9
[INFO] [stderr]    |
[INFO] [stderr] 88 |         stream.read(&mut buf).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/lib.rs:98:24
[INFO] [stderr]    |
[INFO] [stderr] 98 |             res = Some(self.request_cache.get(path).unwrap().clone());
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.request_cache[path]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/lib.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             stream.write(format!("HTTP/1.1 {} OK\r\n\r\n{}", r.status, r.body).as_bytes()).unwrap();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/lib.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             stream.write(format!("HTTP/1.1 {} OK\r\n\r\n{}", r.status, r.body).as_bytes()).unwrap();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/lib.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 |             stream.write(format!("HTTP/1.1 404 Not Found\r\n\r\nNot Found").as_bytes()).unwrap();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/lib.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 |             stream.write(format!("HTTP/1.1 404 Not Found\r\n\r\nNot Found").as_bytes()).unwrap();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:130:26
[INFO] [stderr]     |
[INFO] [stderr] 130 |             stream.write(format!("HTTP/1.1 404 Not Found\r\n\r\nNot Found").as_bytes()).unwrap();
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"HTTP/1.1 404 Not Found\r\n\r\nNot Found".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/lib.rs:130:26
[INFO] [stderr]     |
[INFO] [stderr] 130 |             stream.write(format!("HTTP/1.1 404 Not Found\r\n\r\nNot Found").as_bytes()).unwrap();
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"HTTP/1.1 404 Not Found\r\n\r\nNot Found".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rwebserver`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rwebserver`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "87b3b3d4ab3352d369a5d6aeec8fd59210b8f68a2dd096a9fe0f9e5cb6b45e83"`
[INFO] running `"docker" "rm" "-f" "87b3b3d4ab3352d369a5d6aeec8fd59210b8f68a2dd096a9fe0f9e5cb6b45e83"`
[INFO] [stdout] 87b3b3d4ab3352d369a5d6aeec8fd59210b8f68a2dd096a9fe0f9e5cb6b45e83