[INFO] updating cached repository varkor/metasub [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/varkor/metasub [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/varkor/metasub" "work/ex/clippy-test-run/sources/stable/gh/varkor/metasub"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/varkor/metasub'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/varkor/metasub" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varkor/metasub"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varkor/metasub'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 223fb77cb9866a58013d7eb7afab2d2711224d12 [INFO] sha for GitHub repo varkor/metasub: 223fb77cb9866a58013d7eb7afab2d2711224d12 [INFO] validating manifest of varkor/metasub on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of varkor/metasub on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing varkor/metasub [INFO] finished frobbing varkor/metasub [INFO] frobbed toml for varkor/metasub written to work/ex/clippy-test-run/sources/stable/gh/varkor/metasub/Cargo.toml [INFO] started frobbing varkor/metasub [INFO] finished frobbing varkor/metasub [INFO] frobbed toml for varkor/metasub written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varkor/metasub/Cargo.toml [INFO] crate varkor/metasub has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting varkor/metasub against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/varkor/metasub:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d5546ec59acace66817d135893a6d0ef88abae31d6db6b145433e30a315f25f [INFO] running `"docker" "start" "-a" "7d5546ec59acace66817d135893a6d0ef88abae31d6db6b145433e30a315f25f"` [INFO] [stderr] Checking num-integer v0.1.36 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking metasub v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/term_verifier.rs:284:21 [INFO] [stderr] | [INFO] [stderr] 284 | start = "\x1b[31;1m", [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/term_verifier.rs:284:21 [INFO] [stderr] | [INFO] [stderr] 284 | start = "\x1b[31;1m", [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/term_verifier.rs:285:19 [INFO] [stderr] | [INFO] [stderr] 285 | end = "\x1b[0m") [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/term_verifier.rs:285:19 [INFO] [stderr] | [INFO] [stderr] 285 | end = "\x1b[0m") [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/term_verifier.rs:264:52 [INFO] [stderr] | [INFO] [stderr] 264 | let (prehint, posthint): (&str, &str) = if spaces >= hint.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 264 | let (prehint, posthint): (&str, &str) = if spaces > hint.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like an `else if` but the `else` is missing [INFO] [stderr] --> src/term_verifier.rs:571:18 [INFO] [stderr] | [INFO] [stderr] 571 | } if let Ok(var) = self.eat_var() { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/term_verifier.rs:264:52 [INFO] [stderr] | [INFO] [stderr] 264 | let (prehint, posthint): (&str, &str) = if spaces >= hint.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 264 | let (prehint, posthint): (&str, &str) = if spaces > hint.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like an `else if` but the `else` is missing [INFO] [stderr] --> src/term_verifier.rs:571:18 [INFO] [stderr] | [INFO] [stderr] 571 | } if let Ok(var) = self.eat_var() { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/term_verifier.rs:73:30 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn escape_name(name: &String) -> String { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 73 | pub fn escape_name(name: &str) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.clone()` to [INFO] [stderr] | [INFO] [stderr] 79 | name.to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/term_verifier.rs:73:30 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn escape_name(name: &String) -> String { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 73 | pub fn escape_name(name: &str) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.clone()` to [INFO] [stderr] | [INFO] [stderr] 79 | name.to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/term_verifier.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | let required = format!("\ [INFO] [stderr] | ________________________^ [INFO] [stderr] 144 | | Require Import UniMath.Foundations.PartD.\ [INFO] [stderr] 145 | | "); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 143 | let required = "\ [INFO] [stderr] 144 | Require Import UniMath.Foundations.PartD.\ [INFO] [stderr] 145 | ".to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/term_verifier.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | let required = format!("\ [INFO] [stderr] | ________________________^ [INFO] [stderr] 144 | | Require Import UniMath.Foundations.PartD.\ [INFO] [stderr] 145 | | "); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 143 | let required = "\ [INFO] [stderr] 144 | Require Import UniMath.Foundations.PartD.\ [INFO] [stderr] 145 | ".to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/term_verifier.rs:470:23 [INFO] [stderr] | [INFO] [stderr] 470 | return if vars.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vars.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/term_verifier.rs:470:23 [INFO] [stderr] | [INFO] [stderr] 470 | return if vars.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!vars.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/term_verifier.rs:566:20 [INFO] [stderr] | [INFO] [stderr] 566 | if let Err(_) = eat_arrow { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 567 | | if Regex::new(&format!("^>")).unwrap().is_match(&self.s) || [INFO] [stderr] 568 | | Regex::new(&format!("^-")).unwrap().is_match(&self.s) { [INFO] [stderr] 569 | | Err::<(), ParseError>(self.error_hint("you probably meant `->`")) [INFO] [stderr] ... | [INFO] [stderr] 583 | | } [INFO] [stderr] 584 | | } [INFO] [stderr] | |_____________- help: try this: `if eat_arrow.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/term_verifier.rs:567:32 [INFO] [stderr] | [INFO] [stderr] 567 | if Regex::new(&format!("^>")).unwrap().is_match(&self.s) || [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"^>".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/term_verifier.rs:568:32 [INFO] [stderr] | [INFO] [stderr] 568 | Regex::new(&format!("^-")).unwrap().is_match(&self.s) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"^-".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/term_verifier.rs:566:20 [INFO] [stderr] | [INFO] [stderr] 566 | if let Err(_) = eat_arrow { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 567 | | if Regex::new(&format!("^>")).unwrap().is_match(&self.s) || [INFO] [stderr] 568 | | Regex::new(&format!("^-")).unwrap().is_match(&self.s) { [INFO] [stderr] 569 | | Err::<(), ParseError>(self.error_hint("you probably meant `->`")) [INFO] [stderr] ... | [INFO] [stderr] 583 | | } [INFO] [stderr] 584 | | } [INFO] [stderr] | |_____________- help: try this: `if eat_arrow.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/term_verifier.rs:567:32 [INFO] [stderr] | [INFO] [stderr] 567 | if Regex::new(&format!("^>")).unwrap().is_match(&self.s) || [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"^>".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/term_verifier.rs:568:32 [INFO] [stderr] | [INFO] [stderr] 568 | Regex::new(&format!("^-")).unwrap().is_match(&self.s) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using .to_string(): `"^-".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/term_verifier.rs:609:5 [INFO] [stderr] | [INFO] [stderr] 609 | / let mut terms: Vec = vec![]; [INFO] [stderr] 610 | | if !interactive { [INFO] [stderr] 611 | | // Load terms from a file. [INFO] [stderr] 612 | | let mut f = File::open(filename).expect("the file could not be found"); [INFO] [stderr] ... | [INFO] [stderr] 623 | | }).collect(); [INFO] [stderr] 624 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 609 | let terms = if !interactive { ..; lines.filter_map(|s| { [INFO] [stderr] 610 | let s = s.trim(); [INFO] [stderr] 611 | if s.is_empty() || re_comment.is_match(s) { [INFO] [stderr] 612 | return None; [INFO] [stderr] 613 | } [INFO] [stderr] 614 | Some(s.to_string()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/term_verifier.rs:615:36 [INFO] [stderr] | [INFO] [stderr] 615 | let lines = contents.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/term_verifier.rs:609:5 [INFO] [stderr] | [INFO] [stderr] 609 | / let mut terms: Vec = vec![]; [INFO] [stderr] 610 | | if !interactive { [INFO] [stderr] 611 | | // Load terms from a file. [INFO] [stderr] 612 | | let mut f = File::open(filename).expect("the file could not be found"); [INFO] [stderr] ... | [INFO] [stderr] 623 | | }).collect(); [INFO] [stderr] 624 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 609 | let terms = if !interactive { ..; lines.filter_map(|s| { [INFO] [stderr] 610 | let s = s.trim(); [INFO] [stderr] 611 | if s.is_empty() || re_comment.is_match(s) { [INFO] [stderr] 612 | return None; [INFO] [stderr] 613 | } [INFO] [stderr] 614 | Some(s.to_string()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/term_verifier.rs:615:36 [INFO] [stderr] | [INFO] [stderr] 615 | let lines = contents.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | let lines = contents.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | let comps: Vec<_> = s.split(": ").into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.split(": ")` [INFO] [stderr] | [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | let lines = contents.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | let comps: Vec<_> = s.split(": ").into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.split(": ")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:58:33 [INFO] [stderr] | [INFO] [stderr] 58 | let comps: Vec<_> = s.split(": ").into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.split(": ")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | / if gen_vars.is_none() { [INFO] [stderr] 68 | | let capt = re_varset.captures_iter(s).next().unwrap()[1].to_string(); [INFO] [stderr] 69 | | let vars: Vec = capt.split(", ").filter_map(|v| { [INFO] [stderr] 70 | | if !v.is_empty() { [INFO] [stderr] ... | [INFO] [stderr] 79 | | panic!("declared V twice"); [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `gen_vars?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | let output = template.split("\n").filter_map(|line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | let matches: Vec<_> = re_cmd.captures_iter(line).into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `re_cmd.captures_iter(line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | let comps: Vec<_> = s.split(": ").into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.split(": ")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | let comps: Vec<_> = s.split(": ").into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.split(": ")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:58:33 [INFO] [stderr] | [INFO] [stderr] 58 | let comps: Vec<_> = s.split(": ").into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `s.split(": ")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/main.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | / if gen_vars.is_none() { [INFO] [stderr] 68 | | let capt = re_varset.captures_iter(s).next().unwrap()[1].to_string(); [INFO] [stderr] 69 | | let vars: Vec = capt.split(", ").filter_map(|v| { [INFO] [stderr] 70 | | if !v.is_empty() { [INFO] [stderr] ... | [INFO] [stderr] 79 | | panic!("declared V twice"); [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `gen_vars?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | let output = template.split("\n").filter_map(|line| { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | let matches: Vec<_> = re_cmd.captures_iter(line).into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `re_cmd.captures_iter(line)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.45s [INFO] running `"docker" "inspect" "7d5546ec59acace66817d135893a6d0ef88abae31d6db6b145433e30a315f25f"` [INFO] running `"docker" "rm" "-f" "7d5546ec59acace66817d135893a6d0ef88abae31d6db6b145433e30a315f25f"` [INFO] [stdout] 7d5546ec59acace66817d135893a6d0ef88abae31d6db6b145433e30a315f25f