[INFO] updating cached repository varjolintu/r9wm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/varjolintu/r9wm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/varjolintu/r9wm" "work/ex/clippy-test-run/sources/stable/gh/varjolintu/r9wm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/varjolintu/r9wm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/varjolintu/r9wm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varjolintu/r9wm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varjolintu/r9wm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dbcb7622a562f799062bffcd45bf0d3ce8e179b8 [INFO] sha for GitHub repo varjolintu/r9wm: dbcb7622a562f799062bffcd45bf0d3ce8e179b8 [INFO] validating manifest of varjolintu/r9wm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of varjolintu/r9wm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing varjolintu/r9wm [INFO] finished frobbing varjolintu/r9wm [INFO] frobbed toml for varjolintu/r9wm written to work/ex/clippy-test-run/sources/stable/gh/varjolintu/r9wm/Cargo.toml [INFO] started frobbing varjolintu/r9wm [INFO] finished frobbing varjolintu/r9wm [INFO] frobbed toml for varjolintu/r9wm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varjolintu/r9wm/Cargo.toml [INFO] crate varjolintu/r9wm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting varjolintu/r9wm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/varjolintu/r9wm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b672c941d5baa8a22d7bec8adaf59999277d1cbc6ca5f71b13e89d5bd4264c6 [INFO] running `"docker" "start" "-a" "1b672c941d5baa8a22d7bec8adaf59999277d1cbc6ca5f71b13e89d5bd4264c6"` [INFO] [stderr] Compiling x11 v2.18.1 [INFO] [stderr] Checking r9wm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match Command::new(process).spawn() { [INFO] [stderr] 23 | | Err(e) => eprintln!("couldn't spawn: {}", e.description()), [INFO] [stderr] 24 | | _ => {} [INFO] [stderr] 25 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = Command::new(process).spawn() { eprintln!("couldn't spawn: {}", e.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: The function/method `XOpenDisplay` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:30:56 [INFO] [stderr] | [INFO] [stderr] 30 | let display : *mut Display = unsafe { XOpenDisplay(&mut arg0) }; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:44:31 [INFO] [stderr] | [INFO] [stderr] 44 | XGrabKey(display, XKeysymToKeycode(display, key.into()) as c_int, Mod1Mask, XDefaultRootWindow(display), true as c_int, GrabModeAsync, GrabModeAsync); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(XKeysymToKeycode(display, key.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | match Command::new("rofi").args(&["-show", "run"]).spawn() { [INFO] [stderr] | _________________________^ [INFO] [stderr] 86 | | Err(e) => eprintln!("couldn't spawn: {}", e.description()), [INFO] [stderr] 87 | | _ => {} [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_________________________^ help: try this: `if let Err(e) = Command::new("rofi").args(&["-show", "run"]).spawn() { eprintln!("couldn't spawn: {}", e.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match Command::new(process).spawn() { [INFO] [stderr] 23 | | Err(e) => eprintln!("couldn't spawn: {}", e.description()), [INFO] [stderr] 24 | | _ => {} [INFO] [stderr] 25 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = Command::new(process).spawn() { eprintln!("couldn't spawn: {}", e.description()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: The function/method `XOpenDisplay` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:30:56 [INFO] [stderr] | [INFO] [stderr] 30 | let display : *mut Display = unsafe { XOpenDisplay(&mut arg0) }; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:44:31 [INFO] [stderr] | [INFO] [stderr] 44 | XGrabKey(display, XKeysymToKeycode(display, key.into()) as c_int, Mod1Mask, XDefaultRootWindow(display), true as c_int, GrabModeAsync, GrabModeAsync); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(XKeysymToKeycode(display, key.into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:85:16 [INFO] [stderr] | [INFO] [stderr] 85 | match Command::new("rofi").args(&["-show", "run"]).spawn() { [INFO] [stderr] | _________________________^ [INFO] [stderr] 86 | | Err(e) => eprintln!("couldn't spawn: {}", e.description()), [INFO] [stderr] 87 | | _ => {} [INFO] [stderr] 88 | | }; [INFO] [stderr] | |_________________________^ help: try this: `if let Err(e) = Command::new("rofi").args(&["-show", "run"]).spawn() { eprintln!("couldn't spawn: {}", e.description()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.70s [INFO] running `"docker" "inspect" "1b672c941d5baa8a22d7bec8adaf59999277d1cbc6ca5f71b13e89d5bd4264c6"` [INFO] running `"docker" "rm" "-f" "1b672c941d5baa8a22d7bec8adaf59999277d1cbc6ca5f71b13e89d5bd4264c6"` [INFO] [stdout] 1b672c941d5baa8a22d7bec8adaf59999277d1cbc6ca5f71b13e89d5bd4264c6