[INFO] updating cached repository varjolintu/keepassxc-proxy-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/varjolintu/keepassxc-proxy-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/varjolintu/keepassxc-proxy-rust" "work/ex/clippy-test-run/sources/stable/gh/varjolintu/keepassxc-proxy-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/varjolintu/keepassxc-proxy-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/varjolintu/keepassxc-proxy-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varjolintu/keepassxc-proxy-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varjolintu/keepassxc-proxy-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 211ae91e360782d78d32724eab072f8f1585c9de [INFO] sha for GitHub repo varjolintu/keepassxc-proxy-rust: 211ae91e360782d78d32724eab072f8f1585c9de [INFO] validating manifest of varjolintu/keepassxc-proxy-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of varjolintu/keepassxc-proxy-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing varjolintu/keepassxc-proxy-rust [INFO] finished frobbing varjolintu/keepassxc-proxy-rust [INFO] frobbed toml for varjolintu/keepassxc-proxy-rust written to work/ex/clippy-test-run/sources/stable/gh/varjolintu/keepassxc-proxy-rust/Cargo.toml [INFO] started frobbing varjolintu/keepassxc-proxy-rust [INFO] finished frobbing varjolintu/keepassxc-proxy-rust [INFO] frobbed toml for varjolintu/keepassxc-proxy-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/varjolintu/keepassxc-proxy-rust/Cargo.toml [INFO] crate varjolintu/keepassxc-proxy-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting varjolintu/keepassxc-proxy-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/varjolintu/keepassxc-proxy-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8781cbfa54289664d3722f5a2f3ec0c22e03d98c3516a9cb38c3cea25fb817df [INFO] running `"docker" "start" "-a" "8781cbfa54289664d3722f5a2f3ec0c22e03d98c3516a9cb38c3cea25fb817df"` [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking keepassxc-proxy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:2 [INFO] [stderr] | [INFO] [stderr] 17 | return length > 0 && length <= BUFFER_SIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `length > 0 && length <= BUFFER_SIZE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:2 [INFO] [stderr] | [INFO] [stderr] 17 | return length > 0 && length <= BUFFER_SIZE; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `length > 0 && length <= BUFFER_SIZE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | if let Ok(_) = handle.read_exact(&mut buffer) { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 35 | | if valid_length(length) { [INFO] [stderr] 36 | | socket.write(&buffer).unwrap(); [INFO] [stderr] 37 | | socket.flush().unwrap(); [INFO] [stderr] 38 | | read_response(socket); [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____- help: try this: `if handle.read_exact(&mut buffer).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:36:4 [INFO] [stderr] | [INFO] [stderr] 36 | socket.write(&buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:55:2 [INFO] [stderr] | [INFO] [stderr] 55 | out.write(buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ui_res =` [INFO] [stderr] --> src/main.rs:70:2 [INFO] [stderr] | [INFO] [stderr] 70 | let _ui_res = ui.join().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `keepassxc-proxy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | if let Ok(_) = handle.read_exact(&mut buffer) { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 35 | | if valid_length(length) { [INFO] [stderr] 36 | | socket.write(&buffer).unwrap(); [INFO] [stderr] 37 | | socket.flush().unwrap(); [INFO] [stderr] 38 | | read_response(socket); [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____- help: try this: `if handle.read_exact(&mut buffer).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:36:4 [INFO] [stderr] | [INFO] [stderr] 36 | socket.write(&buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:55:2 [INFO] [stderr] | [INFO] [stderr] 55 | out.write(buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ui_res =` [INFO] [stderr] --> src/main.rs:70:2 [INFO] [stderr] | [INFO] [stderr] 70 | let _ui_res = ui.join().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `keepassxc-proxy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8781cbfa54289664d3722f5a2f3ec0c22e03d98c3516a9cb38c3cea25fb817df"` [INFO] running `"docker" "rm" "-f" "8781cbfa54289664d3722f5a2f3ec0c22e03d98c3516a9cb38c3cea25fb817df"` [INFO] [stdout] 8781cbfa54289664d3722f5a2f3ec0c22e03d98c3516a9cb38c3cea25fb817df