[INFO] updating cached repository valarauca/xmltool [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/valarauca/xmltool [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/valarauca/xmltool" "work/ex/clippy-test-run/sources/stable/gh/valarauca/xmltool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/valarauca/xmltool'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/valarauca/xmltool" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/valarauca/xmltool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/valarauca/xmltool'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b18f3998024f2380d186c95ba7bd56818f221919 [INFO] sha for GitHub repo valarauca/xmltool: b18f3998024f2380d186c95ba7bd56818f221919 [INFO] validating manifest of valarauca/xmltool on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of valarauca/xmltool on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing valarauca/xmltool [INFO] finished frobbing valarauca/xmltool [INFO] frobbed toml for valarauca/xmltool written to work/ex/clippy-test-run/sources/stable/gh/valarauca/xmltool/Cargo.toml [INFO] started frobbing valarauca/xmltool [INFO] finished frobbing valarauca/xmltool [INFO] frobbed toml for valarauca/xmltool written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/valarauca/xmltool/Cargo.toml [INFO] crate valarauca/xmltool has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting valarauca/xmltool against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/valarauca/xmltool:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b59a49e15a02655836cf361a309470cb76fc9f796e03d20873570a198acee9d [INFO] running `"docker" "start" "-a" "0b59a49e15a02655836cf361a309470cb76fc9f796e03d20873570a198acee9d"` [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking xml-rs v0.6.1 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking xmltool v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cli/formatter/writer.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | Option::Some("CRLF") | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `declare_format` [INFO] [stderr] --> src/cli/formatter/formatter_cli.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn declare_format<'a,'b>() -> App<'a,'b> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_parser_config` [INFO] [stderr] --> src/cli/formatter/reader.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn build_parser_config(arg: &ArgMatches) -> ParserConfig { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `to_line_sep` [INFO] [stderr] --> src/cli/formatter/writer.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn to_line_sep(arg: &ArgMatches) -> Cow<'static, str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `to_indent` [INFO] [stderr] --> src/cli/formatter/writer.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | fn to_indent(arg: &ArgMatches) -> Cow<'static, str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `perform_indents` [INFO] [stderr] --> src/cli/formatter/writer.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | fn perform_indents(arg: &ArgMatches) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_emitter_config` [INFO] [stderr] --> src/cli/formatter/writer.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn build_emitter_config(arg: &ArgMatches) -> EmitterConfig { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `GenReader` [INFO] [stderr] --> src/cli/formatter/fsutil.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub enum GenReader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cli/formatter/fsutil.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(arg: &ArgMatches) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `GenWriter` [INFO] [stderr] --> src/cli/formatter/fsutil.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | pub enum GenWriter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cli/formatter/fsutil.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn new(arg: &ArgMatches) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `do_reformat` [INFO] [stderr] --> src/cli/formatter/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn do_reformat(arg: &ArgMatches) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli/formatter/fsutil.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &mut GenReader::FileR(ref mut reader) => reader.read(buf), [INFO] [stderr] 31 | | &mut GenReader::StdIn(ref mut reader) => reader.read(buf), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | GenReader::FileR(ref mut reader) => reader.read(buf), [INFO] [stderr] 31 | GenReader::StdIn(ref mut reader) => reader.read(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli/formatter/fsutil.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match self { [INFO] [stderr] 59 | | &mut GenWriter::FileW(ref mut w) => w.write(buf), [INFO] [stderr] 60 | | &mut GenWriter::StdOut(ref mut w) => w.write(buf), [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | match *self { [INFO] [stderr] 59 | GenWriter::FileW(ref mut w) => w.write(buf), [INFO] [stderr] 60 | GenWriter::StdOut(ref mut w) => w.write(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli/formatter/fsutil.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self { [INFO] [stderr] 65 | | &mut GenWriter::FileW(ref mut w) => w.flush(), [INFO] [stderr] 66 | | &mut GenWriter::StdOut(ref mut w) => w.flush(), [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *self { [INFO] [stderr] 65 | GenWriter::FileW(ref mut w) => w.flush(), [INFO] [stderr] 66 | GenWriter::StdOut(ref mut w) => w.flush(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/cli/formatter/writer.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | Option::Some("CRLF") | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `declare_format` [INFO] [stderr] --> src/cli/formatter/formatter_cli.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn declare_format<'a,'b>() -> App<'a,'b> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_parser_config` [INFO] [stderr] --> src/cli/formatter/reader.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn build_parser_config(arg: &ArgMatches) -> ParserConfig { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `to_line_sep` [INFO] [stderr] --> src/cli/formatter/writer.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | fn to_line_sep(arg: &ArgMatches) -> Cow<'static, str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `to_indent` [INFO] [stderr] --> src/cli/formatter/writer.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | fn to_indent(arg: &ArgMatches) -> Cow<'static, str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `perform_indents` [INFO] [stderr] --> src/cli/formatter/writer.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | fn perform_indents(arg: &ArgMatches) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `build_emitter_config` [INFO] [stderr] --> src/cli/formatter/writer.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn build_emitter_config(arg: &ArgMatches) -> EmitterConfig { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `GenReader` [INFO] [stderr] --> src/cli/formatter/fsutil.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub enum GenReader { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cli/formatter/fsutil.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn new(arg: &ArgMatches) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `GenWriter` [INFO] [stderr] --> src/cli/formatter/fsutil.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | pub enum GenWriter { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/cli/formatter/fsutil.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn new(arg: &ArgMatches) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `do_reformat` [INFO] [stderr] --> src/cli/formatter/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn do_reformat(arg: &ArgMatches) -> io::Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli/formatter/fsutil.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &mut GenReader::FileR(ref mut reader) => reader.read(buf), [INFO] [stderr] 31 | | &mut GenReader::StdIn(ref mut reader) => reader.read(buf), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | GenReader::FileR(ref mut reader) => reader.read(buf), [INFO] [stderr] 31 | GenReader::StdIn(ref mut reader) => reader.read(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli/formatter/fsutil.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match self { [INFO] [stderr] 59 | | &mut GenWriter::FileW(ref mut w) => w.write(buf), [INFO] [stderr] 60 | | &mut GenWriter::StdOut(ref mut w) => w.write(buf), [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | match *self { [INFO] [stderr] 59 | GenWriter::FileW(ref mut w) => w.write(buf), [INFO] [stderr] 60 | GenWriter::StdOut(ref mut w) => w.write(buf), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli/formatter/fsutil.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self { [INFO] [stderr] 65 | | &mut GenWriter::FileW(ref mut w) => w.flush(), [INFO] [stderr] 66 | | &mut GenWriter::StdOut(ref mut w) => w.flush(), [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 64 | match *self { [INFO] [stderr] 65 | GenWriter::FileW(ref mut w) => w.flush(), [INFO] [stderr] 66 | GenWriter::StdOut(ref mut w) => w.flush(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.26s [INFO] running `"docker" "inspect" "0b59a49e15a02655836cf361a309470cb76fc9f796e03d20873570a198acee9d"` [INFO] running `"docker" "rm" "-f" "0b59a49e15a02655836cf361a309470cb76fc9f796e03d20873570a198acee9d"` [INFO] [stdout] 0b59a49e15a02655836cf361a309470cb76fc9f796e03d20873570a198acee9d