[INFO] updating cached repository valarauca/sse [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/valarauca/sse [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/valarauca/sse" "work/ex/clippy-test-run/sources/stable/gh/valarauca/sse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/valarauca/sse'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/valarauca/sse" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/valarauca/sse"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/valarauca/sse'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 81b0d2685e5652790fd3b12c83997c134b6e3f87 [INFO] sha for GitHub repo valarauca/sse: 81b0d2685e5652790fd3b12c83997c134b6e3f87 [INFO] validating manifest of valarauca/sse on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of valarauca/sse on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing valarauca/sse [INFO] finished frobbing valarauca/sse [INFO] frobbed toml for valarauca/sse written to work/ex/clippy-test-run/sources/stable/gh/valarauca/sse/Cargo.toml [INFO] started frobbing valarauca/sse [INFO] finished frobbing valarauca/sse [INFO] frobbed toml for valarauca/sse written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/valarauca/sse/Cargo.toml [INFO] crate valarauca/sse has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting valarauca/sse against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/valarauca/sse:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c38139e15fc799a6a66a86c73113ae672a34f89fd52253e8720e3fc8a037548f [INFO] running `"docker" "start" "-a" "c38139e15fc799a6a66a86c73113ae672a34f89fd52253e8720e3fc8a037548f"` [INFO] [stderr] Checking winapi v0.2.7 [INFO] [stderr] Checking libc v0.2.13 [INFO] [stderr] Checking regex-syntax v0.3.3 [INFO] [stderr] Checking kernel32-sys v0.2.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking thread_local v0.2.6 [INFO] [stderr] Checking aho-corasick v0.5.2 [INFO] [stderr] Checking regex v0.1.71 [INFO] [stderr] Checking sse v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | const WRONG_ARGS: &'static str = "Was expecting an additional arg. Use sse -h for help."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | const HELP: &'static str = "Use sse -h for help."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | const VERS: &'static str = "0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | const MSG: &'static str =" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:9:20 [INFO] [stderr] | [INFO] [stderr] 9 | const WRONG_ARGS: &'static str = "Was expecting an additional arg. Use sse -h for help."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:10:14 [INFO] [stderr] | [INFO] [stderr] 10 | const HELP: &'static str = "Use sse -h for help."; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | const VERS: &'static str = "0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | const MSG: &'static str =" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / fn new() -> Ops { [INFO] [stderr] 108 | | let mut args: Vec = args().skip(1).collect(); [INFO] [stderr] 109 | | args.reverse(); [INFO] [stderr] 110 | | if args.len() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 199 | | } [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:110:12 [INFO] [stderr] | [INFO] [stderr] 110 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / match self { [INFO] [stderr] 205 | | &Ops::I(ref r,ref s,nice) => { [INFO] [stderr] 206 | | let stdin = io::stdin(); [INFO] [stderr] 207 | | for line in stdin.lock().lines() { [INFO] [stderr] ... | [INFO] [stderr] 299 | | } [INFO] [stderr] 300 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 204 | match *self { [INFO] [stderr] 205 | Ops::I(ref r,ref s,nice) => { [INFO] [stderr] 206 | let stdin = io::stdin(); [INFO] [stderr] 207 | for line in stdin.lock().lines() { [INFO] [stderr] 208 | match line { [INFO] [stderr] 209 | Ok(ref x) => match r.captures(&x) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / fn new() -> Ops { [INFO] [stderr] 108 | | let mut args: Vec = args().skip(1).collect(); [INFO] [stderr] 109 | | args.reverse(); [INFO] [stderr] 110 | | if args.len() == 0 { [INFO] [stderr] ... | [INFO] [stderr] 199 | | } [INFO] [stderr] 200 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:110:12 [INFO] [stderr] | [INFO] [stderr] 110 | if args.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / match self { [INFO] [stderr] 205 | | &Ops::I(ref r,ref s,nice) => { [INFO] [stderr] 206 | | let stdin = io::stdin(); [INFO] [stderr] 207 | | for line in stdin.lock().lines() { [INFO] [stderr] ... | [INFO] [stderr] 299 | | } [INFO] [stderr] 300 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 204 | match *self { [INFO] [stderr] 205 | Ops::I(ref r,ref s,nice) => { [INFO] [stderr] 206 | let stdin = io::stdin(); [INFO] [stderr] 207 | for line in stdin.lock().lines() { [INFO] [stderr] 208 | match line { [INFO] [stderr] 209 | Ok(ref x) => match r.captures(&x) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.56s [INFO] running `"docker" "inspect" "c38139e15fc799a6a66a86c73113ae672a34f89fd52253e8720e3fc8a037548f"` [INFO] running `"docker" "rm" "-f" "c38139e15fc799a6a66a86c73113ae672a34f89fd52253e8720e3fc8a037548f"` [INFO] [stdout] c38139e15fc799a6a66a86c73113ae672a34f89fd52253e8720e3fc8a037548f