[INFO] updating cached repository vakabus/rumipsem [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/vakabus/rumipsem [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/vakabus/rumipsem" "work/ex/clippy-test-run/sources/stable/gh/vakabus/rumipsem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/vakabus/rumipsem'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/vakabus/rumipsem" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vakabus/rumipsem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vakabus/rumipsem'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5eb40604e61a63db9ae12679df0a39052f3d65c2 [INFO] sha for GitHub repo vakabus/rumipsem: 5eb40604e61a63db9ae12679df0a39052f3d65c2 [INFO] validating manifest of vakabus/rumipsem on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of vakabus/rumipsem on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing vakabus/rumipsem [INFO] finished frobbing vakabus/rumipsem [INFO] frobbed toml for vakabus/rumipsem written to work/ex/clippy-test-run/sources/stable/gh/vakabus/rumipsem/Cargo.toml [INFO] started frobbing vakabus/rumipsem [INFO] finished frobbing vakabus/rumipsem [INFO] frobbed toml for vakabus/rumipsem written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/vakabus/rumipsem/Cargo.toml [INFO] crate vakabus/rumipsem has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting vakabus/rumipsem against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/vakabus/rumipsem:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1483428d59b698f51ec34fb13a304fa2926d0b473739945a6334f0d8524c014a [INFO] running `"docker" "start" "-a" "1483428d59b698f51ec34fb13a304fa2926d0b473739945a6334f0d8524c014a"` [INFO] [stderr] Checking scroll v0.7.0 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking num-integer v0.1.38 [INFO] [stderr] Compiling scroll_derive v0.7.0 [INFO] [stderr] Checking serde_json v1.0.19 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking chrono v0.4.3 [INFO] [stderr] Checking goblin v0.0.11 [INFO] [stderr] Checking simplelog v0.5.2 [INFO] [stderr] Checking rumipsem v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/instructions.rs:962:5 [INFO] [stderr] | [INFO] [stderr] 962 | return result_cpu_event; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result_cpu_event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | 0b000000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | 0b000100 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | 0b000110 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | 0b000010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | 0b100000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | 0b100001 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | 0b100011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | 0b100101 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | 0b100111 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | 0b000011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | 0b000111 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cpu/instructions.rs:962:5 [INFO] [stderr] | [INFO] [stderr] 962 | return result_cpu_event; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result_cpu_event` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | 0b000000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | 0b000100 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | 0b000110 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | 0b000010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | 0b100000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:126:17 [INFO] [stderr] | [INFO] [stderr] 126 | 0b100001 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | 0b100011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | 0b100101 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | 0b100111 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:203:17 [INFO] [stderr] | [INFO] [stderr] 203 | 0b100100 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | 0b100110 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | 0b000011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | 0b001001 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | 0b000111 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:239:17 [INFO] [stderr] | [INFO] [stderr] 239 | 0b001000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | 0b101010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:203:17 [INFO] [stderr] | [INFO] [stderr] 203 | 0b100100 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:257:17 [INFO] [stderr] | [INFO] [stderr] 257 | 0b101011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | 0b100110 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:263:17 [INFO] [stderr] | [INFO] [stderr] 263 | 0b001011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | 0b001001 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:278:17 [INFO] [stderr] | [INFO] [stderr] 278 | 0b001010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:239:17 [INFO] [stderr] | [INFO] [stderr] 239 | 0b001000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:245:17 [INFO] [stderr] | [INFO] [stderr] 245 | 0b101010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:257:17 [INFO] [stderr] | [INFO] [stderr] 257 | 0b101011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | 0b011000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:263:17 [INFO] [stderr] | [INFO] [stderr] 263 | 0b001011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:278:17 [INFO] [stderr] | [INFO] [stderr] 278 | 0b001010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | 0b011000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1000` [INFO] [stderr] --> src/cpu/instructions.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | 0b011001 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1001` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | 0b011010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:371:17 [INFO] [stderr] | [INFO] [stderr] 371 | 0b011011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | 0b011001 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:390:17 [INFO] [stderr] | [INFO] [stderr] 390 | 0b110100 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | 0b011010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:400:17 [INFO] [stderr] | [INFO] [stderr] 400 | 0b010000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:371:17 [INFO] [stderr] | [INFO] [stderr] 371 | 0b011011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:409:17 [INFO] [stderr] | [INFO] [stderr] 409 | 0b010010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:390:17 [INFO] [stderr] | [INFO] [stderr] 390 | 0b110100 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:419:17 [INFO] [stderr] | [INFO] [stderr] 419 | 0b001100 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:423:17 [INFO] [stderr] | [INFO] [stderr] 423 | 0b001111 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:427:17 [INFO] [stderr] | [INFO] [stderr] 427 | 0b001101 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:400:17 [INFO] [stderr] | [INFO] [stderr] 400 | 0b010000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:409:17 [INFO] [stderr] | [INFO] [stderr] 409 | 0b010010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:419:17 [INFO] [stderr] | [INFO] [stderr] 419 | 0b001100 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:509:29 [INFO] [stderr] | [INFO] [stderr] 509 | } else if rt == 0b000001 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:423:17 [INFO] [stderr] | [INFO] [stderr] 423 | 0b001111 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:427:17 [INFO] [stderr] | [INFO] [stderr] 427 | 0b001101 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:509:29 [INFO] [stderr] | [INFO] [stderr] 509 | } else if rt == 0b000001 { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:835:17 [INFO] [stderr] | [INFO] [stderr] 835 | 0b000010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:860:17 [INFO] [stderr] | [INFO] [stderr] 860 | 0b100000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:869:17 [INFO] [stderr] | [INFO] [stderr] 869 | 0b111011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:878:58 [INFO] [stderr] | [INFO] [stderr] 878 | registers.write_register(rt, 0x58e950); // this value was copied from gdb on real HW [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0058_e950` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:896:17 [INFO] [stderr] | [INFO] [stderr] 896 | 0b000000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:944:17 [INFO] [stderr] | [INFO] [stderr] 944 | 0b000000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cpu/watchdog.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cpu/watchdog.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | let res = Some(read_trace(tracefile)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cpu/watchdog.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 143 | | if !self.trace_gap { [INFO] [stderr] 144 | | panic!( [INFO] [stderr] 145 | | "Execution diverged from real execution trace - upcoming instruction is at address 0x{:x}, but 0x{:x} was expected. One of the executed instructions must be implemented differently.", [INFO] [stderr] ... | [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | } else if !self.trace_gap { [INFO] [stderr] 143 | panic!( [INFO] [stderr] 144 | "Execution diverged from real execution trace - upcoming instruction is at address 0x{:x}, but 0x{:x} was expected. One of the executed instructions must be implemented differently.", [INFO] [stderr] 145 | register_file.get_pc(), [INFO] [stderr] 146 | instruction_record.address [INFO] [stderr] 147 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cpu/watchdog.rs:170:28 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 171 | | if register_file.read_register(*reg) != *val { [INFO] [stderr] 172 | | warn!( [INFO] [stderr] 173 | | "Initial register values in trace are different. Overwriting register {}!!!", [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if register_file.read_register(*reg) != *val { [INFO] [stderr] 171 | warn!( [INFO] [stderr] 172 | "Initial register values in trace are different. Overwriting register {}!!!", [INFO] [stderr] 173 | get_register_name(*reg) [INFO] [stderr] 174 | ); [INFO] [stderr] 175 | register_file.write_register(*reg, *val); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:835:17 [INFO] [stderr] | [INFO] [stderr] 835 | 0b000010 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | 0b000000 => InstructionOpcode::SPECIAL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | 0b000001 => InstructionOpcode::REGIMM, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | 0b000010 => InstructionOpcode::J, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | 0b000011 => InstructionOpcode::JAL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | 0b000100 => InstructionOpcode::BEQ, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | 0b000101 => InstructionOpcode::BNE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | 0b000110 => InstructionOpcode::BLEZ, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | 0b000111 => InstructionOpcode::BGTZ, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | 0b001000 => InstructionOpcode::ADDI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | 0b001001 => InstructionOpcode::ADDIU, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | 0b001010 => InstructionOpcode::SLTI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | 0b001011 => InstructionOpcode::SLTIU, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | 0b001100 => InstructionOpcode::ANDI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | 0b001101 => InstructionOpcode::ORI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | 0b001110 => InstructionOpcode::XORI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | 0b001111 => InstructionOpcode::AUI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | 0b010000 => InstructionOpcode::COP0, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | 0b010001 => InstructionOpcode::COP1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | 0b010010 => InstructionOpcode::COP2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | 0b010011 => InstructionOpcode::COP1X, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | 0b010100 => InstructionOpcode::BEQL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | 0b010101 => InstructionOpcode::BNEL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | 0b010110 => InstructionOpcode::BLEZL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | 0b010111 => InstructionOpcode::BGTZL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | 0b011100 => InstructionOpcode::SPECIAL2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | 0b011101 => InstructionOpcode::JALX, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | 0b011111 => InstructionOpcode::SPECIAL3, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | 0b100000 => InstructionOpcode::LB, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | 0b100001 => InstructionOpcode::LH, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | 0b100010 => InstructionOpcode::LWL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | 0b100011 => InstructionOpcode::LW, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:860:17 [INFO] [stderr] | [INFO] [stderr] 860 | 0b100000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:869:17 [INFO] [stderr] | [INFO] [stderr] 869 | 0b111011 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:878:58 [INFO] [stderr] | [INFO] [stderr] 878 | registers.write_register(rt, 0x58e950); // this value was copied from gdb on real HW [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0058_e950` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:896:17 [INFO] [stderr] | [INFO] [stderr] 896 | 0b000000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | 0b100100 => InstructionOpcode::LBU, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | 0b100101 => InstructionOpcode::LHU, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | 0b100110 => InstructionOpcode::LWR, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | 0b101000 => InstructionOpcode::SB, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | 0b101001 => InstructionOpcode::SH, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | 0b101010 => InstructionOpcode::SWL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | 0b101011 => InstructionOpcode::SW, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | 0b101110 => InstructionOpcode::SWR, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | 0b101111 => InstructionOpcode::CACHE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | 0b110000 => InstructionOpcode::LL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | 0b110001 => InstructionOpcode::LWC1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | 0b110010 => InstructionOpcode::BC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | 0b110011 => InstructionOpcode::PREF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | 0b110101 => InstructionOpcode::LDC1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | 0b110110 => InstructionOpcode::LDC2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | 0b111000 => InstructionOpcode::SC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | 0b111001 => InstructionOpcode::SWC1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | 0b111010 => InstructionOpcode::BALC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | 0b111011 => InstructionOpcode::PCREL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | 0b111101 => InstructionOpcode::SDC1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | 0b111110 => InstructionOpcode::SDC2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions.rs:944:17 [INFO] [stderr] | [INFO] [stderr] 944 | 0b000000 => { [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cpu/watchdog.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cpu/watchdog.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | let res = Some(read_trace(tracefile)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:211:44 [INFO] [stderr] | [INFO] [stderr] 211 | if address + (data.len() as u32) < 0x70000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cpu/watchdog.rs:142:20 [INFO] [stderr] | [INFO] [stderr] 142 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 143 | | if !self.trace_gap { [INFO] [stderr] 144 | | panic!( [INFO] [stderr] 145 | | "Execution diverged from real execution trace - upcoming instruction is at address 0x{:x}, but 0x{:x} was expected. One of the executed instructions must be implemented differently.", [INFO] [stderr] ... | [INFO] [stderr] 149 | | } [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 142 | } else if !self.trace_gap { [INFO] [stderr] 143 | panic!( [INFO] [stderr] 144 | "Execution diverged from real execution trace - upcoming instruction is at address 0x{:x}, but 0x{:x} was expected. One of the executed instructions must be implemented differently.", [INFO] [stderr] 145 | register_file.get_pc(), [INFO] [stderr] 146 | instruction_record.address [INFO] [stderr] 147 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/cpu/watchdog.rs:170:28 [INFO] [stderr] | [INFO] [stderr] 170 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 171 | | if register_file.read_register(*reg) != *val { [INFO] [stderr] 172 | | warn!( [INFO] [stderr] 173 | | "Initial register values in trace are different. Overwriting register {}!!!", [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 170 | } else if register_file.read_register(*reg) != *val { [INFO] [stderr] 171 | warn!( [INFO] [stderr] 172 | "Initial register values in trace are different. Overwriting register {}!!!", [INFO] [stderr] 173 | get_register_name(*reg) [INFO] [stderr] 174 | ); [INFO] [stderr] 175 | register_file.write_register(*reg, *val); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | 0b000000 => InstructionOpcode::SPECIAL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | 0b000001 => InstructionOpcode::REGIMM, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | 0b000010 => InstructionOpcode::J, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | 0b000011 => InstructionOpcode::JAL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | 0b000100 => InstructionOpcode::BEQ, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | 0b000101 => InstructionOpcode::BNE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | 0b000110 => InstructionOpcode::BLEZ, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | 0b000111 => InstructionOpcode::BGTZ, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | 0b001000 => InstructionOpcode::ADDI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | 0b001001 => InstructionOpcode::ADDIU, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:71:9 [INFO] [stderr] | [INFO] [stderr] 71 | 0b001010 => InstructionOpcode::SLTI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | 0b001011 => InstructionOpcode::SLTIU, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | 0b001100 => InstructionOpcode::ANDI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | 0b001101 => InstructionOpcode::ORI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | 0b001110 => InstructionOpcode::XORI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | 0b001111 => InstructionOpcode::AUI, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | 0b010000 => InstructionOpcode::COP0, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | 0b010001 => InstructionOpcode::COP1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | 0b010010 => InstructionOpcode::COP2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | 0b010011 => InstructionOpcode::COP1X, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | 0b010100 => InstructionOpcode::BEQL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | 0b010101 => InstructionOpcode::BNEL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | 0b010110 => InstructionOpcode::BLEZL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | 0b010111 => InstructionOpcode::BGTZL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | 0b011100 => InstructionOpcode::SPECIAL2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | 0b011101 => InstructionOpcode::JALX, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | 0b011111 => InstructionOpcode::SPECIAL3, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | 0b100000 => InstructionOpcode::LB, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | 0b100001 => InstructionOpcode::LH, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | 0b100010 => InstructionOpcode::LWL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | 0b100011 => InstructionOpcode::LW, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | 0b100100 => InstructionOpcode::LBU, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | 0b100101 => InstructionOpcode::LHU, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | 0b100110 => InstructionOpcode::LWR, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | 0b101000 => InstructionOpcode::SB, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | 0b101001 => InstructionOpcode::SH, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | 0b101010 => InstructionOpcode::SWL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | 0b101011 => InstructionOpcode::SW, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | 0b101110 => InstructionOpcode::SWR, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | 0b101111 => InstructionOpcode::CACHE, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | 0b110000 => InstructionOpcode::LL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | 0b110001 => InstructionOpcode::LWC1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | 0b110010 => InstructionOpcode::BC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | 0b110011 => InstructionOpcode::PREF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | 0b110101 => InstructionOpcode::LDC1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | 0b110110 => InstructionOpcode::LDC2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | 0b111000 => InstructionOpcode::SC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | 0b111001 => InstructionOpcode::SWC1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | 0b111010 => InstructionOpcode::BALC, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | 0b111011 => InstructionOpcode::PCREL, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | 0b111101 => InstructionOpcode::SDC1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instructions_constants.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | 0b111110 => InstructionOpcode::SDC2, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/syscalls.rs:145:25 [INFO] [stderr] | [INFO] [stderr] 145 | const SA_ONSTACK: u32 = 0x08000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/syscalls.rs:146:25 [INFO] [stderr] | [INFO] [stderr] 146 | const SA_RESTART: u32 = 0x10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/syscalls.rs:147:25 [INFO] [stderr] | [INFO] [stderr] 147 | const SA_NODEFER: u32 = 0x40000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/syscalls.rs:148:27 [INFO] [stderr] | [INFO] [stderr] 148 | const SA_RESETHAND: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/syscalls.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | const SA_RESTORER: u32 = 0x04000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/memory.rs:211:44 [INFO] [stderr] | [INFO] [stderr] 211 | if address + (data.len() as u32) < 0x70000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/syscalls.rs:869:13 [INFO] [stderr] | [INFO] [stderr] 869 | return exit; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `exit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/syscalls.rs:145:25 [INFO] [stderr] | [INFO] [stderr] 145 | const SA_ONSTACK: u32 = 0x08000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0800_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/syscalls.rs:146:25 [INFO] [stderr] | [INFO] [stderr] 146 | const SA_RESTART: u32 = 0x10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/syscalls.rs:147:25 [INFO] [stderr] | [INFO] [stderr] 147 | const SA_NODEFER: u32 = 0x40000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/syscalls.rs:148:27 [INFO] [stderr] | [INFO] [stderr] 148 | const SA_RESETHAND: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/syscalls.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | const SA_RESTORER: u32 = 0x04000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0400_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/syscalls.rs:869:13 [INFO] [stderr] | [INFO] [stderr] 869 | return exit; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `exit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | let stack_pointer = 0x7ffffe50; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_fe50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | let stack_pointer = 0x7ffffe50; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_fe50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FlowChangeImmediate` [INFO] [stderr] --> src/cpu/event.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | FlowChangeImmediate(u32), // this is here to support compact branch [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RETURN_ADDRESS` [INFO] [stderr] --> src/cpu/registers.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const RETURN_ADDRESS: u32 = 31; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_instruction_number` [INFO] [stderr] --> src/cpu/watchdog.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn get_instruction_number(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `disable_trace_checking` [INFO] [stderr] --> src/cpu/watchdog.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn disable_trace_checking(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/args.rs:110:8 [INFO] [stderr] | [INFO] [stderr] 110 | if args.executable.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.executable.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(instruction & 0x00_00_00_3F)` [INFO] [stderr] --> src/cpu/bitutils.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | (instruction & 0x00_00_00_3F) >> 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/bitutils.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | word.overflowing_add(((offset as i16) as i32) as u32).0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((offset as i16))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/bitutils.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | ((word as i32) + (((immediate as u32) << 16) as i32)) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(immediate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cpu/control.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | if program_counter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program_counter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cpu/control.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | if program_counter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program_counter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cpu/control.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | if program_counter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program_counter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cpu/control.rs:207:24 [INFO] [stderr] | [INFO] [stderr] 207 | if program_counter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program_counter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cpu/control.rs:213:24 [INFO] [stderr] | [INFO] [stderr] 213 | if program_counter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program_counter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/cpu/control.rs:229:30 [INFO] [stderr] | [INFO] [stderr] 229 | if buf[0] != ('\n' as u8) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 128 [INFO] [stderr] --> src/cpu/instructions.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn eval_instruction( [INFO] [stderr] 13 | | instruction: u32, [INFO] [stderr] 14 | | registers: &mut RegisterFile, [INFO] [stderr] 15 | | memory: &mut Memory, [INFO] [stderr] ... | [INFO] [stderr] 963 | | //println!(" instruction=0x{:08x}", instruction); [INFO] [stderr] 964 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FlowChangeImmediate` [INFO] [stderr] --> src/cpu/event.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | FlowChangeImmediate(u32), // this is here to support compact branch [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RETURN_ADDRESS` [INFO] [stderr] --> src/cpu/registers.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub const RETURN_ADDRESS: u32 = 31; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_instruction_number` [INFO] [stderr] --> src/cpu/watchdog.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn get_instruction_number(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `disable_trace_checking` [INFO] [stderr] --> src/cpu/watchdog.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn disable_trace_checking(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/args.rs:110:8 [INFO] [stderr] | [INFO] [stderr] 110 | if args.executable.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.executable.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(instruction & 0x00_00_00_3F)` [INFO] [stderr] --> src/cpu/bitutils.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | (instruction & 0x00_00_00_3F) >> 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/bitutils.rs:32:26 [INFO] [stderr] | [INFO] [stderr] 32 | word.overflowing_add(((offset as i16) as i32) as u32).0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((offset as i16))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/bitutils.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | ((word as i32) + (((immediate as u32) << 16) as i32)) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(immediate)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cpu/control.rs:158:24 [INFO] [stderr] | [INFO] [stderr] 158 | if program_counter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program_counter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cpu/control.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | if program_counter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program_counter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cpu/control.rs:170:24 [INFO] [stderr] | [INFO] [stderr] 170 | if program_counter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program_counter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cpu/control.rs:207:24 [INFO] [stderr] | [INFO] [stderr] 207 | if program_counter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program_counter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cpu/control.rs:213:24 [INFO] [stderr] | [INFO] [stderr] 213 | if program_counter.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `program_counter.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/cpu/control.rs:229:30 [INFO] [stderr] | [INFO] [stderr] 229 | if buf[0] != ('\n' as u8) { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 128 [INFO] [stderr] --> src/cpu/instructions.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn eval_instruction( [INFO] [stderr] 13 | | instruction: u32, [INFO] [stderr] 14 | | registers: &mut RegisterFile, [INFO] [stderr] 15 | | memory: &mut Memory, [INFO] [stderr] ... | [INFO] [stderr] 963 | | //println!(" instruction=0x{:08x}", instruction); [INFO] [stderr] 964 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:297:38 [INFO] [stderr] | [INFO] [stderr] 297 | let v1 = (registers.read_register(rs) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rs) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:298:38 [INFO] [stderr] | [INFO] [stderr] 298 | let v2 = (registers.read_register(rt) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rt) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:310:38 [INFO] [stderr] | [INFO] [stderr] 310 | let v1 = (registers.read_register(rs) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rs) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:311:38 [INFO] [stderr] | [INFO] [stderr] 311 | let v2 = (registers.read_register(rt) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rt) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:324:38 [INFO] [stderr] | [INFO] [stderr] 324 | let v1 = (registers.read_register(rs) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rs) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:325:38 [INFO] [stderr] | [INFO] [stderr] 325 | let v2 = (registers.read_register(rt) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rt) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:460:51 [INFO] [stderr] | [INFO] [stderr] 460 | let r = registers.read_register(rs) & (get_offset(instruction) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:471:51 [INFO] [stderr] | [INFO] [stderr] 471 | let r = registers.read_register(rs) ^ (get_offset(instruction) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:482:51 [INFO] [stderr] | [INFO] [stderr] 482 | let r = registers.read_register(rs) | (get_offset(instruction) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cpu/instructions.rs:522:13 [INFO] [stderr] | [INFO] [stderr] 522 | / let mut jumped = false; [INFO] [stderr] 523 | | [INFO] [stderr] 524 | | if (lower && val < 0) || (equal && val == 0) || (higher && val > 0) { [INFO] [stderr] 525 | | if link { [INFO] [stderr] ... | [INFO] [stderr] 529 | | jumped = true; [INFO] [stderr] 530 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let jumped = if (lower && val < 0) || (equal && val == 0) || (higher && val > 0) { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:521:46 [INFO] [stderr] | [INFO] [stderr] 521 | (pc as i32 + 4 + sign_extend((get_offset(instruction) as u32) << 2, 18)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:542:45 [INFO] [stderr] | [INFO] [stderr] 542 | let target_offset = sign_extend((get_offset(instruction) as u32) << 2, 18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:557:45 [INFO] [stderr] | [INFO] [stderr] 557 | let target_offset = sign_extend((get_offset(instruction) as u32) << 2, 18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:573:45 [INFO] [stderr] | [INFO] [stderr] 573 | let target_offset = sign_extend((get_offset(instruction) as u32) << 2, 18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:583:45 [INFO] [stderr] | [INFO] [stderr] 583 | let target_offset = sign_extend((get_offset(instruction) as u32) << 2, 18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:297:38 [INFO] [stderr] | [INFO] [stderr] 297 | let v1 = (registers.read_register(rs) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rs) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:298:38 [INFO] [stderr] | [INFO] [stderr] 298 | let v2 = (registers.read_register(rt) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rt) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:310:38 [INFO] [stderr] | [INFO] [stderr] 310 | let v1 = (registers.read_register(rs) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rs) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:311:38 [INFO] [stderr] | [INFO] [stderr] 311 | let v2 = (registers.read_register(rt) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rt) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:324:38 [INFO] [stderr] | [INFO] [stderr] 324 | let v1 = (registers.read_register(rs) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rs) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:325:38 [INFO] [stderr] | [INFO] [stderr] 325 | let v2 = (registers.read_register(rt) as i32) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((registers.read_register(rt) as i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:781:51 [INFO] [stderr] | [INFO] [stderr] 781 | let a = registers.read_register(rs) < (get_offset(instruction) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:800:30 [INFO] [stderr] | [INFO] [stderr] 800 | (sign_extend(get_offset(instruction) as u32, 16) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:805:29 [INFO] [stderr] | [INFO] [stderr] 805 | sign_extend(get_offset(instruction) as u32, 16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:807:30 [INFO] [stderr] | [INFO] [stderr] 807 | (sign_extend(get_offset(instruction) as u32, 16) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:824:33 [INFO] [stderr] | [INFO] [stderr] 824 | (((get_offset(instruction) as u32) << 16) as i32)) as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:460:51 [INFO] [stderr] | [INFO] [stderr] 460 | let r = registers.read_register(rs) & (get_offset(instruction) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:471:51 [INFO] [stderr] | [INFO] [stderr] 471 | let r = registers.read_register(rs) ^ (get_offset(instruction) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:482:51 [INFO] [stderr] | [INFO] [stderr] 482 | let r = registers.read_register(rs) | (get_offset(instruction) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cpu/instructions.rs:522:13 [INFO] [stderr] | [INFO] [stderr] 522 | / let mut jumped = false; [INFO] [stderr] 523 | | [INFO] [stderr] 524 | | if (lower && val < 0) || (equal && val == 0) || (higher && val > 0) { [INFO] [stderr] 525 | | if link { [INFO] [stderr] ... | [INFO] [stderr] 529 | | jumped = true; [INFO] [stderr] 530 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let jumped = if (lower && val < 0) || (equal && val == 0) || (higher && val > 0) { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:521:46 [INFO] [stderr] | [INFO] [stderr] 521 | (pc as i32 + 4 + sign_extend((get_offset(instruction) as u32) << 2, 18)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:542:45 [INFO] [stderr] | [INFO] [stderr] 542 | let target_offset = sign_extend((get_offset(instruction) as u32) << 2, 18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:557:45 [INFO] [stderr] | [INFO] [stderr] 557 | let target_offset = sign_extend((get_offset(instruction) as u32) << 2, 18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:573:45 [INFO] [stderr] | [INFO] [stderr] 573 | let target_offset = sign_extend((get_offset(instruction) as u32) << 2, 18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:583:45 [INFO] [stderr] | [INFO] [stderr] 583 | let target_offset = sign_extend((get_offset(instruction) as u32) << 2, 18); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:781:51 [INFO] [stderr] | [INFO] [stderr] 781 | let a = registers.read_register(rs) < (get_offset(instruction) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/cpu/instructions_constants.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | _ => panic!("Unknown opcode {:06b}."), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:800:30 [INFO] [stderr] | [INFO] [stderr] 800 | (sign_extend(get_offset(instruction) as u32, 16) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/float.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | ((((registers.read_fpr(id + 1) as u32) as u64) << 32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((registers.read_fpr(id + 1) as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:805:29 [INFO] [stderr] | [INFO] [stderr] 805 | sign_extend(get_offset(instruction) as u32, 16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/float.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | (registers.read_fpr(id) as u32) as u64) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((registers.read_fpr(id) as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:807:30 [INFO] [stderr] | [INFO] [stderr] 807 | (sign_extend(get_offset(instruction) as u32, 16) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/float.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | ((((registers.read_fpr(id + 1) as u32) as u64) << 32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((registers.read_fpr(id + 1) as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/float.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | (registers.read_fpr(id) as u32) as u64) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((registers.read_fpr(id) as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/cpu/instructions.rs:824:33 [INFO] [stderr] | [INFO] [stderr] 824 | (((get_offset(instruction) as u32) << 16) as i32)) as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(get_offset(instruction))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | self.data[address as usize] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[address as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:44:41 [INFO] [stderr] | [INFO] [stderr] 44 | Endianness::LittleEndian => LittleEndian::read_u16(self.read_slice(address, 2)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(LittleEndian::read_u16(self.read_slice(address, 2)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:45:38 [INFO] [stderr] | [INFO] [stderr] 45 | Endianness::BigEndian => BigEndian::read_u16(self.read_slice(address, 2)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BigEndian::read_u16(self.read_slice(address, 2)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:67:46 [INFO] [stderr] | [INFO] [stderr] 67 | self.write_byte(address + 1, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | self.write_byte(address + 0, value >> 8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:71:33 [INFO] [stderr] | [INFO] [stderr] 71 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:71:46 [INFO] [stderr] | [INFO] [stderr] 71 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:80:46 [INFO] [stderr] | [INFO] [stderr] 80 | self.write_byte(address + 3, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:83:33 [INFO] [stderr] | [INFO] [stderr] 83 | self.write_byte(address + 0, value >> 24); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:86:33 [INFO] [stderr] | [INFO] [stderr] 86 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:86:46 [INFO] [stderr] | [INFO] [stderr] 86 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:103:51 [INFO] [stderr] | [INFO] [stderr] 103 | self.write_byte(addr + 3, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `addr` [INFO] [stderr] --> src/memory.rs:106:41 [INFO] [stderr] | [INFO] [stderr] 106 | self.write_byte(addr + 0, value >> 24); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:138:51 [INFO] [stderr] | [INFO] [stderr] 138 | self.write_byte(addr + 3, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `addr` [INFO] [stderr] --> src/memory.rs:141:41 [INFO] [stderr] | [INFO] [stderr] 141 | self.write_byte(addr + 0, value >> 24); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:158:41 [INFO] [stderr] | [INFO] [stderr] 158 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:158:54 [INFO] [stderr] | [INFO] [stderr] 158 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:161:41 [INFO] [stderr] | [INFO] [stderr] 161 | self.write_byte(address + 0, value >> 8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:162:54 [INFO] [stderr] | [INFO] [stderr] 162 | self.write_byte(address + 1, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:165:41 [INFO] [stderr] | [INFO] [stderr] 165 | self.write_byte(address + 0, value >> 16); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:167:54 [INFO] [stderr] | [INFO] [stderr] 167 | self.write_byte(address + 2, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:170:41 [INFO] [stderr] | [INFO] [stderr] 170 | self.write_byte(address + 0, value >> 24); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:173:54 [INFO] [stderr] | [INFO] [stderr] 173 | self.write_byte(address + 3, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:181:41 [INFO] [stderr] | [INFO] [stderr] 181 | self.write_byte(address + 0, value >> 24); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:184:54 [INFO] [stderr] | [INFO] [stderr] 184 | self.write_byte(address + 3, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:187:41 [INFO] [stderr] | [INFO] [stderr] 187 | self.write_byte(address + 0, value >> 16); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:189:54 [INFO] [stderr] | [INFO] [stderr] 189 | self.write_byte(address + 2, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:192:41 [INFO] [stderr] | [INFO] [stderr] 192 | self.write_byte(address + 0, value >> 8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:193:54 [INFO] [stderr] | [INFO] [stderr] 193 | self.write_byte(address + 1, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:196:41 [INFO] [stderr] | [INFO] [stderr] 196 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:196:54 [INFO] [stderr] | [INFO] [stderr] 196 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/memory.rs:205:12 [INFO] [stderr] | [INFO] [stderr] 205 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/memory.rs:219:12 [INFO] [stderr] | [INFO] [stderr] 219 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/memory.rs:230:20 [INFO] [stderr] | [INFO] [stderr] 230 | return 0 as *const u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/memory.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | return 0 as *mut u8; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:273:47 [INFO] [stderr] | [INFO] [stderr] 273 | self.write_byte(data_address, c as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:292:47 [INFO] [stderr] | [INFO] [stderr] 292 | self.write_byte(data_address, c as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:298:47 [INFO] [stderr] | [INFO] [stderr] 298 | self.write_byte(data_address, c as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/cpu/instructions_constants.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | _ => panic!("Unknown opcode {:06b}."), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/float.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | ((((registers.read_fpr(id + 1) as u32) as u64) << 32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((registers.read_fpr(id + 1) as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/float.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | (registers.read_fpr(id) as u32) as u64) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((registers.read_fpr(id) as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/float.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | ((((registers.read_fpr(id + 1) as u32) as u64) << 32) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((registers.read_fpr(id + 1) as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/float.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | (registers.read_fpr(id) as u32) as u64) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((registers.read_fpr(id) as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | self.data[address as usize] as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[address as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:44:41 [INFO] [stderr] | [INFO] [stderr] 44 | Endianness::LittleEndian => LittleEndian::read_u16(self.read_slice(address, 2)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(LittleEndian::read_u16(self.read_slice(address, 2)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:45:38 [INFO] [stderr] | [INFO] [stderr] 45 | Endianness::BigEndian => BigEndian::read_u16(self.read_slice(address, 2)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BigEndian::read_u16(self.read_slice(address, 2)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:67:46 [INFO] [stderr] | [INFO] [stderr] 67 | self.write_byte(address + 1, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:68:33 [INFO] [stderr] | [INFO] [stderr] 68 | self.write_byte(address + 0, value >> 8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:71:33 [INFO] [stderr] | [INFO] [stderr] 71 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:71:46 [INFO] [stderr] | [INFO] [stderr] 71 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:80:46 [INFO] [stderr] | [INFO] [stderr] 80 | self.write_byte(address + 3, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:83:33 [INFO] [stderr] | [INFO] [stderr] 83 | self.write_byte(address + 0, value >> 24); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:86:33 [INFO] [stderr] | [INFO] [stderr] 86 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:86:46 [INFO] [stderr] | [INFO] [stderr] 86 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:103:51 [INFO] [stderr] | [INFO] [stderr] 103 | self.write_byte(addr + 3, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `addr` [INFO] [stderr] --> src/memory.rs:106:41 [INFO] [stderr] | [INFO] [stderr] 106 | self.write_byte(addr + 0, value >> 24); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:138:51 [INFO] [stderr] | [INFO] [stderr] 138 | self.write_byte(addr + 3, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `addr` [INFO] [stderr] --> src/memory.rs:141:41 [INFO] [stderr] | [INFO] [stderr] 141 | self.write_byte(addr + 0, value >> 24); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:158:41 [INFO] [stderr] | [INFO] [stderr] 158 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:158:54 [INFO] [stderr] | [INFO] [stderr] 158 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:161:41 [INFO] [stderr] | [INFO] [stderr] 161 | self.write_byte(address + 0, value >> 8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:162:54 [INFO] [stderr] | [INFO] [stderr] 162 | self.write_byte(address + 1, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:165:41 [INFO] [stderr] | [INFO] [stderr] 165 | self.write_byte(address + 0, value >> 16); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:167:54 [INFO] [stderr] | [INFO] [stderr] 167 | self.write_byte(address + 2, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:170:41 [INFO] [stderr] | [INFO] [stderr] 170 | self.write_byte(address + 0, value >> 24); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:173:54 [INFO] [stderr] | [INFO] [stderr] 173 | self.write_byte(address + 3, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:181:41 [INFO] [stderr] | [INFO] [stderr] 181 | self.write_byte(address + 0, value >> 24); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:184:54 [INFO] [stderr] | [INFO] [stderr] 184 | self.write_byte(address + 3, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:187:41 [INFO] [stderr] | [INFO] [stderr] 187 | self.write_byte(address + 0, value >> 16); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:189:54 [INFO] [stderr] | [INFO] [stderr] 189 | self.write_byte(address + 2, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:192:41 [INFO] [stderr] | [INFO] [stderr] 192 | self.write_byte(address + 0, value >> 8); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:193:54 [INFO] [stderr] | [INFO] [stderr] 193 | self.write_byte(address + 1, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `address` [INFO] [stderr] --> src/memory.rs:196:41 [INFO] [stderr] | [INFO] [stderr] 196 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `value` [INFO] [stderr] --> src/memory.rs:196:54 [INFO] [stderr] | [INFO] [stderr] 196 | self.write_byte(address + 0, value >> 0); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/memory.rs:205:12 [INFO] [stderr] | [INFO] [stderr] 205 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/memory.rs:219:12 [INFO] [stderr] | [INFO] [stderr] 219 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/memory.rs:230:20 [INFO] [stderr] | [INFO] [stderr] 230 | return 0 as *const u8; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/memory.rs:238:20 [INFO] [stderr] | [INFO] [stderr] 238 | return 0 as *mut u8; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 100 [INFO] [stderr] --> src/syscalls.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn eval_syscall( [INFO] [stderr] 206 | | &mut self, [INFO] [stderr] 207 | | _inst: u32, [INFO] [stderr] 208 | | registers: &mut RegisterFile, [INFO] [stderr] ... | [INFO] [stderr] 870 | | } [INFO] [stderr] 871 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:273:47 [INFO] [stderr] | [INFO] [stderr] 273 | self.write_byte(data_address, c as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:292:47 [INFO] [stderr] | [INFO] [stderr] 292 | self.write_byte(data_address, c as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/memory.rs:298:47 [INFO] [stderr] | [INFO] [stderr] 298 | self.write_byte(data_address, c as u32); [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/syscalls.rs:289:33 [INFO] [stderr] | [INFO] [stderr] 289 | 0 as *const ::libc::sigset_t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: casting from `*const u32` to a more-strictly-aligned pointer (`*const libc::sigset_t`) [INFO] [stderr] --> src/syscalls.rs:291:33 [INFO] [stderr] | [INFO] [stderr] 291 | sigset.as_ptr() as *const ::libc::sigset_t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/syscalls.rs:294:33 [INFO] [stderr] | [INFO] [stderr] 294 | 0 as *mut ::libc::sigset_t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u32` to a more-strictly-aligned pointer (`*mut libc::sigset_t`) [INFO] [stderr] --> src/syscalls.rs:296:33 [INFO] [stderr] | [INFO] [stderr] 296 | oldsigset.as_mut_ptr() as *mut ::libc::sigset_t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 100 [INFO] [stderr] --> src/syscalls.rs:205:5 [INFO] [stderr] | [INFO] [stderr] 205 | / pub fn eval_syscall( [INFO] [stderr] 206 | | &mut self, [INFO] [stderr] 207 | | _inst: u32, [INFO] [stderr] 208 | | registers: &mut RegisterFile, [INFO] [stderr] ... | [INFO] [stderr] 870 | | } [INFO] [stderr] 871 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut i32`) [INFO] [stderr] --> src/syscalls.rs:422:29 [INFO] [stderr] | [INFO] [stderr] 422 | wstatus as *mut i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `arg3` [INFO] [stderr] --> src/syscalls.rs:430:43 [INFO] [stderr] | [INFO] [stderr] 430 | memory.write_word(arg3 + 0 * 4, rusage[0] as u32); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/syscalls.rs:430:50 [INFO] [stderr] | [INFO] [stderr] 430 | memory.write_word(arg3 + 0 * 4, rusage[0] as u32); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/syscalls.rs:431:50 [INFO] [stderr] | [INFO] [stderr] 431 | memory.write_word(arg3 + 1 * 4, rusage[1] as u32); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/syscalls.rs:435:52 [INFO] [stderr] | [INFO] [stderr] 435 | arg3 + 2 * i * 4 + 1 * 4, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/syscalls.rs:520:54 [INFO] [stderr] | [INFO] [stderr] 520 | .chain(::std::iter::once(0 as *const i8)) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/syscalls.rs:528:48 [INFO] [stderr] | [INFO] [stderr] 528 | .take_while(|a| *a != &(0 as *const i8)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/syscalls.rs:532:48 [INFO] [stderr] | [INFO] [stderr] 532 | .take_while(|a| *a != &(0 as *const i8)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/syscalls.rs:562:56 [INFO] [stderr] | [INFO] [stderr] 562 | ::libc::ioctl(arg1 as i32, arg2 as u64, memory.translate_address(arg3)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(arg2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/syscalls.rs:577:33 [INFO] [stderr] | [INFO] [stderr] 577 | tv_sec: memory.read_word(timeout_ptr) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(memory.read_word(timeout_ptr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/syscalls.rs:578:34 [INFO] [stderr] | [INFO] [stderr] 578 | tv_nsec: memory.read_word(timeout_ptr + 4) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(memory.read_word(timeout_ptr + 4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/syscalls.rs:733:41 [INFO] [stderr] | [INFO] [stderr] 733 | let offset: i64 = (((arg2 as u64) << 32) | (arg3 as u64)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(arg2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/syscalls.rs:733:64 [INFO] [stderr] | [INFO] [stderr] 733 | let offset: i64 = (((arg2 as u64) << 32) | (arg3 as u64)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(arg3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `buf_addr` [INFO] [stderr] --> src/syscalls.rs:753:43 [INFO] [stderr] | [INFO] [stderr] 753 | memory.write_byte(buf_addr + 0, '/' as u32); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/syscalls.rs:789:25 [INFO] [stderr] | [INFO] [stderr] 789 | Err(_) => panic!("Weird time! UNIX epoch is in the future?"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/syscalls.rs:289:33 [INFO] [stderr] | [INFO] [stderr] 289 | 0 as *const ::libc::sigset_t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: casting from `*const u32` to a more-strictly-aligned pointer (`*const libc::sigset_t`) [INFO] [stderr] --> src/syscalls.rs:291:33 [INFO] [stderr] | [INFO] [stderr] 291 | sigset.as_ptr() as *const ::libc::sigset_t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/syscalls.rs:294:33 [INFO] [stderr] | [INFO] [stderr] 294 | 0 as *mut ::libc::sigset_t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u32` to a more-strictly-aligned pointer (`*mut libc::sigset_t`) [INFO] [stderr] --> src/syscalls.rs:296:33 [INFO] [stderr] | [INFO] [stderr] 296 | oldsigset.as_mut_ptr() as *mut ::libc::sigset_t [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut i32`) [INFO] [stderr] --> src/syscalls.rs:422:29 [INFO] [stderr] | [INFO] [stderr] 422 | wstatus as *mut i32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `arg3` [INFO] [stderr] --> src/syscalls.rs:430:43 [INFO] [stderr] | [INFO] [stderr] 430 | memory.write_word(arg3 + 0 * 4, rusage[0] as u32); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/syscalls.rs:430:50 [INFO] [stderr] | [INFO] [stderr] 430 | memory.write_word(arg3 + 0 * 4, rusage[0] as u32); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/syscalls.rs:431:50 [INFO] [stderr] | [INFO] [stderr] 431 | memory.write_word(arg3 + 1 * 4, rusage[1] as u32); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/syscalls.rs:435:52 [INFO] [stderr] | [INFO] [stderr] 435 | arg3 + 2 * i * 4 + 1 * 4, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/syscalls.rs:921:21 [INFO] [stderr] | [INFO] [stderr] 921 | let sigaction = context.get_system().sigactions.get(&signal).map( [INFO] [stderr] | _____________________^ [INFO] [stderr] 922 | | |a| a.clone(), [INFO] [stderr] 923 | | ); [INFO] [stderr] | |_____^ help: Consider calling the dedicated `cloned` method: `context.get_system().sigactions.get(&signal).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/syscalls.rs:520:54 [INFO] [stderr] | [INFO] [stderr] 520 | .chain(::std::iter::once(0 as *const i8)) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/syscalls.rs:528:48 [INFO] [stderr] | [INFO] [stderr] 528 | .take_while(|a| *a != &(0 as *const i8)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/syscalls.rs:532:48 [INFO] [stderr] | [INFO] [stderr] 532 | .take_while(|a| *a != &(0 as *const i8)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | let environment_vars = std::env::vars().into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `std::env::vars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/syscalls.rs:562:56 [INFO] [stderr] | [INFO] [stderr] 562 | ::libc::ioctl(arg1 as i32, arg2 as u64, memory.translate_address(arg3)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(arg2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/syscalls.rs:577:33 [INFO] [stderr] | [INFO] [stderr] 577 | tv_sec: memory.read_word(timeout_ptr) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(memory.read_word(timeout_ptr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/syscalls.rs:578:34 [INFO] [stderr] | [INFO] [stderr] 578 | tv_nsec: memory.read_word(timeout_ptr + 4) as i64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(memory.read_word(timeout_ptr + 4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/syscalls.rs:733:41 [INFO] [stderr] | [INFO] [stderr] 733 | let offset: i64 = (((arg2 as u64) << 32) | (arg3 as u64)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(arg2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/syscalls.rs:733:64 [INFO] [stderr] | [INFO] [stderr] 733 | let offset: i64 = (((arg2 as u64) << 32) | (arg3 as u64)) as i64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(arg3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `buf_addr` [INFO] [stderr] --> src/syscalls.rs:753:43 [INFO] [stderr] | [INFO] [stderr] 753 | memory.write_byte(buf_addr + 0, '/' as u32); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/syscalls.rs:789:25 [INFO] [stderr] | [INFO] [stderr] 789 | Err(_) => panic!("Weird time! UNIX epoch is in the future?"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/syscalls.rs:921:21 [INFO] [stderr] | [INFO] [stderr] 921 | let sigaction = context.get_system().sigactions.get(&signal).map( [INFO] [stderr] | _____________________^ [INFO] [stderr] 922 | | |a| a.clone(), [INFO] [stderr] 923 | | ); [INFO] [stderr] | |_____^ help: Consider calling the dedicated `cloned` method: `context.get_system().sigactions.get(&signal).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: Could not compile `rumipsem`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | let environment_vars = std::env::vars().into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `std::env::vars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rumipsem`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1483428d59b698f51ec34fb13a304fa2926d0b473739945a6334f0d8524c014a"` [INFO] running `"docker" "rm" "-f" "1483428d59b698f51ec34fb13a304fa2926d0b473739945a6334f0d8524c014a"` [INFO] [stdout] 1483428d59b698f51ec34fb13a304fa2926d0b473739945a6334f0d8524c014a