[INFO] updating cached repository utrescu/Rust-Semafors
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/utrescu/Rust-Semafors
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/utrescu/Rust-Semafors" "work/ex/clippy-test-run/sources/stable/gh/utrescu/Rust-Semafors"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/utrescu/Rust-Semafors'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/utrescu/Rust-Semafors" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utrescu/Rust-Semafors"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utrescu/Rust-Semafors'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 86fb95647d6687dabb05d66201fb59d8cf7db000
[INFO] sha for GitHub repo utrescu/Rust-Semafors: 86fb95647d6687dabb05d66201fb59d8cf7db000
[INFO] validating manifest of utrescu/Rust-Semafors on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of utrescu/Rust-Semafors on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing utrescu/Rust-Semafors
[INFO] finished frobbing utrescu/Rust-Semafors
[INFO] frobbed toml for utrescu/Rust-Semafors written to work/ex/clippy-test-run/sources/stable/gh/utrescu/Rust-Semafors/Cargo.toml
[INFO] started frobbing utrescu/Rust-Semafors
[INFO] finished frobbing utrescu/Rust-Semafors
[INFO] frobbed toml for utrescu/Rust-Semafors written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/utrescu/Rust-Semafors/Cargo.toml
[INFO] crate utrescu/Rust-Semafors has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting utrescu/Rust-Semafors against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/utrescu/Rust-Semafors:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] df31e347290bf90b26095385f6697b59bff7686f801ffb64dbd582be146df712
[INFO] running `"docker" "start" "-a" "df31e347290bf90b26095385f6697b59bff7686f801ffb64dbd582be146df712"`
[INFO] [stderr]     Checking semafors v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 |         Err(_) => panic!("Unable to read file {:?}", filename),
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `countlines` is used as a loop counter. Consider using `for (countlines, item) in buffer.lines().enumerate()` or similar iterators
[INFO] [stderr]   --> src/main.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for line in buffer.lines() {
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             Err(_) => panic!("Error reading line {}", countlines),
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 | /     match index == 3 {
[INFO] [stderr] 69 | |         true => Some(result_string),
[INFO] [stderr] 70 | |         false => None,
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if index == 3 { Some(result_string) } else { None }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:19:9
[INFO] [stderr]    |
[INFO] [stderr] 19 |         Err(_) => panic!("Unable to read file {:?}", filename),
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `countlines` is used as a loop counter. Consider using `for (countlines, item) in buffer.lines().enumerate()` or similar iterators
[INFO] [stderr]   --> src/main.rs:26:17
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for line in buffer.lines() {
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/main.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             Err(_) => panic!("Error reading line {}", countlines),
[INFO] [stderr]    |             ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 | /     match index == 3 {
[INFO] [stderr] 69 | |         true => Some(result_string),
[INFO] [stderr] 70 | |         false => None,
[INFO] [stderr] 71 | |     }
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if index == 3 { Some(result_string) } else { None }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.64s
[INFO] running `"docker" "inspect" "df31e347290bf90b26095385f6697b59bff7686f801ffb64dbd582be146df712"`
[INFO] running `"docker" "rm" "-f" "df31e347290bf90b26095385f6697b59bff7686f801ffb64dbd582be146df712"`
[INFO] [stdout] df31e347290bf90b26095385f6697b59bff7686f801ffb64dbd582be146df712