[INFO] updating cached repository usbalbin/liquid_sim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/usbalbin/liquid_sim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/usbalbin/liquid_sim" "work/ex/clippy-test-run/sources/stable/gh/usbalbin/liquid_sim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/usbalbin/liquid_sim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/usbalbin/liquid_sim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/usbalbin/liquid_sim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/usbalbin/liquid_sim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f7c3e23772460763530bd0eada322720d2c19aff [INFO] sha for GitHub repo usbalbin/liquid_sim: f7c3e23772460763530bd0eada322720d2c19aff [INFO] validating manifest of usbalbin/liquid_sim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of usbalbin/liquid_sim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing usbalbin/liquid_sim [INFO] finished frobbing usbalbin/liquid_sim [INFO] frobbed toml for usbalbin/liquid_sim written to work/ex/clippy-test-run/sources/stable/gh/usbalbin/liquid_sim/Cargo.toml [INFO] started frobbing usbalbin/liquid_sim [INFO] finished frobbing usbalbin/liquid_sim [INFO] frobbed toml for usbalbin/liquid_sim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/usbalbin/liquid_sim/Cargo.toml [INFO] crate usbalbin/liquid_sim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting usbalbin/liquid_sim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/usbalbin/liquid_sim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d74df5cabbaef7fbd24cadc67f3dd223bc48ffec13bd0ec5aff52763e0eab0f9 [INFO] running `"docker" "start" "-a" "d74df5cabbaef7fbd24cadc67f3dd223bc48ffec13bd0ec5aff52763e0eab0f9"` [INFO] [stderr] Compiling libc v0.2.36 [INFO] [stderr] Compiling libloading v0.4.3 [INFO] [stderr] Compiling bitflags v1.0.1 [INFO] [stderr] Compiling num-traits v0.1.41 [INFO] [stderr] Compiling cfg-if v0.1.2 [INFO] [stderr] Compiling khronos_api v2.0.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling x11-dl v2.17.2 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Checking dlib v0.4.0 [INFO] [stderr] Compiling rand v0.3.20 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Compiling glutin v0.11.0 [INFO] [stderr] Compiling glium v0.19.0 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking winit v0.9.0 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking liquid_sim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/main.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | let r = to_u8(128.0 + f.0); [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `g` [INFO] [stderr] --> src/main.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | let g = to_u8(128.0 + f.1); [INFO] [stderr] | ^ help: consider using `_g` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `neg` [INFO] [stderr] --> src/main.rs:266:1 [INFO] [stderr] | [INFO] [stderr] 266 | fn neg(a: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / match ev { [INFO] [stderr] 84 | | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 85 | | glium::glutin::WindowEvent::Closed => close = true, [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | }, [INFO] [stderr] 88 | | _ => (), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | if let glium::glutin::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 84 | glium::glutin::WindowEvent::Closed => close = true, [INFO] [stderr] 85 | _ => (), [INFO] [stderr] 86 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:84:68 [INFO] [stderr] | [INFO] [stderr] 84 | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 85 | | glium::glutin::WindowEvent::Closed => close = true, [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let glium::glutin::WindowEvent::Closed = event { close = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | fn update_flow(pressure: &Vec>, flow: &mut Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:129:26 [INFO] [stderr] | [INFO] [stderr] 129 | fn update_heat(old_flow: &Vec>, flow: &mut Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(f32, f32)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:141:56 [INFO] [stderr] | [INFO] [stderr] 141 | fn update_pressure(pressure: &mut Vec>, flow: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(f32, f32)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:153:26 [INFO] [stderr] | [INFO] [stderr] 153 | fn flow_kernel(pressure: &Vec>, flow: &mut(f32, f32), pos: (usize, usize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:173:46 [INFO] [stderr] | [INFO] [stderr] 173 | fn pressure_kernel(pressure: &mut f32, flow: &Vec>, pos: (usize, usize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(f32, f32)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:184:26 [INFO] [stderr] | [INFO] [stderr] 184 | fn heat_kernel(old_flow: &Vec>, flow: &mut(f32, f32), pos: (usize, usize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(f32, f32)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:199:19 [INFO] [stderr] | [INFO] [stderr] 199 | fn get_flow(flow: &Vec>, pos: &(usize, usize), delta: &(i32, i32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(f32, f32)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:199:71 [INFO] [stderr] | [INFO] [stderr] 199 | fn get_flow(flow: &Vec>, pos: &(usize, usize), delta: &(i32, i32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:219:27 [INFO] [stderr] | [INFO] [stderr] 219 | fn get_pressure(pressure: &Vec>, pos: &(usize, usize), delta: &(i32, i32)) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:219:72 [INFO] [stderr] | [INFO] [stderr] 219 | fn get_pressure(pressure: &Vec>, pos: &(usize, usize), delta: &(i32, i32)) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:246:11 [INFO] [stderr] | [INFO] [stderr] 246 | fn dot(a: &(f32, f32), b: &(f32, f32)) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:246:27 [INFO] [stderr] | [INFO] [stderr] 246 | fn dot(a: &(f32, f32), b: &(f32, f32)) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:251:11 [INFO] [stderr] | [INFO] [stderr] 251 | fn add(a: &(f32, f32), b: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:251:27 [INFO] [stderr] | [INFO] [stderr] 251 | fn add(a: &(f32, f32), b: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:258:11 [INFO] [stderr] | [INFO] [stderr] 258 | fn sub(a: &(f32, f32), b: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:258:27 [INFO] [stderr] | [INFO] [stderr] 258 | fn sub(a: &(f32, f32), b: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:266:11 [INFO] [stderr] | [INFO] [stderr] 266 | fn neg(a: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:273:11 [INFO] [stderr] | [INFO] [stderr] 273 | fn mul(a: &(f32, f32), b: f32) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `r` [INFO] [stderr] --> src/main.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | let r = to_u8(128.0 + f.0); [INFO] [stderr] | ^ help: consider using `_r` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `g` [INFO] [stderr] --> src/main.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | let g = to_u8(128.0 + f.1); [INFO] [stderr] | ^ help: consider using `_g` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `neg` [INFO] [stderr] --> src/main.rs:266:1 [INFO] [stderr] | [INFO] [stderr] 266 | fn neg(a: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / match ev { [INFO] [stderr] 84 | | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 85 | | glium::glutin::WindowEvent::Closed => close = true, [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | }, [INFO] [stderr] 88 | | _ => (), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 83 | if let glium::glutin::Event::WindowEvent { event, .. } = ev { match event { [INFO] [stderr] 84 | glium::glutin::WindowEvent::Closed => close = true, [INFO] [stderr] 85 | _ => (), [INFO] [stderr] 86 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:84:68 [INFO] [stderr] | [INFO] [stderr] 84 | glium::glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 85 | | glium::glutin::WindowEvent::Closed => close = true, [INFO] [stderr] 86 | | _ => (), [INFO] [stderr] 87 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let glium::glutin::WindowEvent::Closed = event { close = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:118:26 [INFO] [stderr] | [INFO] [stderr] 118 | fn update_flow(pressure: &Vec>, flow: &mut Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:129:26 [INFO] [stderr] | [INFO] [stderr] 129 | fn update_heat(old_flow: &Vec>, flow: &mut Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(f32, f32)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:141:56 [INFO] [stderr] | [INFO] [stderr] 141 | fn update_pressure(pressure: &mut Vec>, flow: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(f32, f32)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:153:26 [INFO] [stderr] | [INFO] [stderr] 153 | fn flow_kernel(pressure: &Vec>, flow: &mut(f32, f32), pos: (usize, usize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:173:46 [INFO] [stderr] | [INFO] [stderr] 173 | fn pressure_kernel(pressure: &mut f32, flow: &Vec>, pos: (usize, usize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(f32, f32)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:184:26 [INFO] [stderr] | [INFO] [stderr] 184 | fn heat_kernel(old_flow: &Vec>, flow: &mut(f32, f32), pos: (usize, usize)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(f32, f32)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:199:19 [INFO] [stderr] | [INFO] [stderr] 199 | fn get_flow(flow: &Vec>, pos: &(usize, usize), delta: &(i32, i32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<(f32, f32)>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:199:71 [INFO] [stderr] | [INFO] [stderr] 199 | fn get_flow(flow: &Vec>, pos: &(usize, usize), delta: &(i32, i32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:219:27 [INFO] [stderr] | [INFO] [stderr] 219 | fn get_pressure(pressure: &Vec>, pos: &(usize, usize), delta: &(i32, i32)) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:219:72 [INFO] [stderr] | [INFO] [stderr] 219 | fn get_pressure(pressure: &Vec>, pos: &(usize, usize), delta: &(i32, i32)) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:246:11 [INFO] [stderr] | [INFO] [stderr] 246 | fn dot(a: &(f32, f32), b: &(f32, f32)) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:246:27 [INFO] [stderr] | [INFO] [stderr] 246 | fn dot(a: &(f32, f32), b: &(f32, f32)) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:251:11 [INFO] [stderr] | [INFO] [stderr] 251 | fn add(a: &(f32, f32), b: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:251:27 [INFO] [stderr] | [INFO] [stderr] 251 | fn add(a: &(f32, f32), b: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:258:11 [INFO] [stderr] | [INFO] [stderr] 258 | fn sub(a: &(f32, f32), b: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:258:27 [INFO] [stderr] | [INFO] [stderr] 258 | fn sub(a: &(f32, f32), b: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:266:11 [INFO] [stderr] | [INFO] [stderr] 266 | fn neg(a: &(f32, f32)) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:273:11 [INFO] [stderr] | [INFO] [stderr] 273 | fn mul(a: &(f32, f32), b: f32) -> (f32, f32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(f32, f32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 24s [INFO] running `"docker" "inspect" "d74df5cabbaef7fbd24cadc67f3dd223bc48ffec13bd0ec5aff52763e0eab0f9"` [INFO] running `"docker" "rm" "-f" "d74df5cabbaef7fbd24cadc67f3dd223bc48ffec13bd0ec5aff52763e0eab0f9"` [INFO] [stdout] d74df5cabbaef7fbd24cadc67f3dd223bc48ffec13bd0ec5aff52763e0eab0f9