[INFO] updating cached repository uq-eresearch/backup2swift
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/uq-eresearch/backup2swift
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/uq-eresearch/backup2swift" "work/ex/clippy-test-run/sources/stable/gh/uq-eresearch/backup2swift"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/uq-eresearch/backup2swift'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/uq-eresearch/backup2swift" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uq-eresearch/backup2swift"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uq-eresearch/backup2swift'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8894daecdd25b13a204cdc84f85cd8efe6cb5ee9
[INFO] sha for GitHub repo uq-eresearch/backup2swift: 8894daecdd25b13a204cdc84f85cd8efe6cb5ee9
[INFO] validating manifest of uq-eresearch/backup2swift on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of uq-eresearch/backup2swift on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing uq-eresearch/backup2swift
[INFO] finished frobbing uq-eresearch/backup2swift
[INFO] frobbed toml for uq-eresearch/backup2swift written to work/ex/clippy-test-run/sources/stable/gh/uq-eresearch/backup2swift/Cargo.toml
[INFO] started frobbing uq-eresearch/backup2swift
[INFO] finished frobbing uq-eresearch/backup2swift
[INFO] frobbed toml for uq-eresearch/backup2swift written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uq-eresearch/backup2swift/Cargo.toml
[INFO] crate uq-eresearch/backup2swift has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting uq-eresearch/backup2swift against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/uq-eresearch/backup2swift:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3246d79e8a0d0edf0dcee66ee9b2e7154fefe14a3ff3c88dd1ba4c2952886783
[INFO] running `"docker" "start" "-a" "3246d79e8a0d0edf0dcee66ee9b2e7154fefe14a3ff3c88dd1ba4c2952886783"`
[INFO] [stderr]    Compiling cc v1.0.0
[INFO] [stderr]     Checking serde v1.0.15
[INFO] [stderr]     Checking arrayref v0.3.4
[INFO] [stderr]     Checking buf-read-ext v0.2.1
[INFO] [stderr]     Checking lazy_static v0.2.9
[INFO] [stderr]     Checking openssl-probe v0.1.1
[INFO] [stderr]     Checking pipe v0.0.2
[INFO] [stderr]     Checking num_cpus v1.7.0
[INFO] [stderr]     Checking socket2 v0.2.3
[INFO] [stderr]     Checking num-iter v0.1.34
[INFO] [stderr]     Checking tempdir v0.3.5
[INFO] [stderr]     Checking block-buffer v0.3.1
[INFO] [stderr]     Checking thread_local v0.3.4
[INFO] [stderr]    Compiling serde_derive_internals v0.16.0
[INFO] [stderr]     Checking generic-array v0.8.3
[INFO] [stderr]     Checking num v0.1.40
[INFO] [stderr]     Checking hyper v0.10.13
[INFO] [stderr]     Checking chrono v0.4.0
[INFO] [stderr]     Checking digest v0.6.2
[INFO] [stderr]     Checking crypto-mac v0.4.0
[INFO] [stderr]     Checking hmac v0.4.2
[INFO] [stderr]     Checking sha-1 v0.4.1
[INFO] [stderr]    Compiling libz-sys v1.0.17
[INFO] [stderr]    Compiling openssl-sys v0.9.19
[INFO] [stderr]    Compiling curl-sys v0.3.15
[INFO] [stderr]    Compiling serde_derive v1.0.15
[INFO] [stderr]     Checking stderrlog v0.2.3
[INFO] [stderr]     Checking textnonce v0.6.3
[INFO] [stderr]     Checking serde_json v1.0.3
[INFO] [stderr]     Checking mime_multipart v0.5.1
[INFO] [stderr]     Checking formdata v0.12.2
[INFO] [stderr]     Checking curl v0.4.8
[INFO] [stderr]     Checking backup2swift v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:249:30
[INFO] [stderr]     |
[INFO] [stderr] 249 |   let form_data = FormData { fields: fields, files: file_parts };
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:528:5
[INFO] [stderr]     |
[INFO] [stderr] 528 |     max_file_size: max_file_size,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_file_size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:529:5
[INFO] [stderr]     |
[INFO] [stderr] 529 |     max_file_count: max_file_count,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_file_count`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:530:5
[INFO] [stderr]     |
[INFO] [stderr] 530 |     expires: expires,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: replace it with: `expires`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:249:30
[INFO] [stderr]     |
[INFO] [stderr] 249 |   let form_data = FormData { fields: fields, files: file_parts };
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^ help: replace it with: `fields`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:528:5
[INFO] [stderr]     |
[INFO] [stderr] 528 |     max_file_size: max_file_size,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_file_size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:529:5
[INFO] [stderr]     |
[INFO] [stderr] 529 |     max_file_count: max_file_count,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_file_count`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:530:5
[INFO] [stderr]     |
[INFO] [stderr] 530 |     expires: expires,
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: replace it with: `expires`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:35:33
[INFO] [stderr]    |
[INFO] [stderr] 35 | const FORM_MAX_FILE_SIZE: u64 = 1099511627776;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^ help: consider: `1_099_511_627_776`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:36:36
[INFO] [stderr]    |
[INFO] [stderr] 36 | const FORM_MAX_FILE_COUNT: usize = 1048576;
[INFO] [stderr]    |                                    ^^^^^^^ help: consider: `1_048_576`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:37:27
[INFO] [stderr]    |
[INFO] [stderr] 37 | const FORM_EXPIRES: u64 = 4102444800;
[INFO] [stderr]    |                           ^^^^^^^^^^ help: consider: `4_102_444_800`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/main.rs:204:32
[INFO] [stderr]     |
[INFO] [stderr] 204 | fn setup(container_name: &str) -> () {
[INFO] [stderr]     |                                ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/main.rs:219:28
[INFO] [stderr]     |
[INFO] [stderr] 219 |     files: &'a Vec<&Path>) -> () {
[INFO] [stderr]     |                            ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/main.rs:333:15
[INFO] [stderr]     |
[INFO] [stderr] 333 |           }); ()
[INFO] [stderr]     |               ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/main.rs:415:15
[INFO] [stderr]     |
[INFO] [stderr] 415 |           }); ()
[INFO] [stderr]     |               ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:564:32
[INFO] [stderr]     |
[INFO] [stderr] 564 |     const BUFFER_SIZE: usize = 524288;
[INFO] [stderr]     |                                ^^^^^^ help: consider: `524_288`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:35:33
[INFO] [stderr]    |
[INFO] [stderr] 35 | const FORM_MAX_FILE_SIZE: u64 = 1099511627776;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^ help: consider: `1_099_511_627_776`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:36:36
[INFO] [stderr]    |
[INFO] [stderr] 36 | const FORM_MAX_FILE_COUNT: usize = 1048576;
[INFO] [stderr]    |                                    ^^^^^^^ help: consider: `1_048_576`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:37:27
[INFO] [stderr]    |
[INFO] [stderr] 37 | const FORM_EXPIRES: u64 = 4102444800;
[INFO] [stderr]    |                           ^^^^^^^^^^ help: consider: `4_102_444_800`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/main.rs:204:32
[INFO] [stderr]     |
[INFO] [stderr] 204 | fn setup(container_name: &str) -> () {
[INFO] [stderr]     |                                ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/main.rs:219:28
[INFO] [stderr]     |
[INFO] [stderr] 219 |     files: &'a Vec<&Path>) -> () {
[INFO] [stderr]     |                            ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/main.rs:333:15
[INFO] [stderr]     |
[INFO] [stderr] 333 |           }); ()
[INFO] [stderr]     |               ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/main.rs:415:15
[INFO] [stderr]     |
[INFO] [stderr] 415 |           }); ()
[INFO] [stderr]     |               ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:564:32
[INFO] [stderr]     |
[INFO] [stderr] 564 |     const BUFFER_SIZE: usize = 524288;
[INFO] [stderr]     |                                ^^^^^^ help: consider: `524_288`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:196:19
[INFO] [stderr]     |
[INFO] [stderr] 196 |     assert!(files.into_iter().all(|f: &&Path| f.is_file()));
[INFO] [stderr]     |                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:219:12
[INFO] [stderr]     |
[INFO] [stderr] 219 |     files: &'a Vec<&Path>) -> () {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: change this to: `&[&Path]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:225:11
[INFO] [stderr]     |
[INFO] [stderr] 225 |     files.into_iter()
[INFO] [stderr]     |           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:243:30
[INFO] [stderr]     |
[INFO] [stderr] 243 |     ("signature".to_owned(), format!("{}", form_template.signature))
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `form_template.signature.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:245:3
[INFO] [stderr]     |
[INFO] [stderr] 245 | /   match delete_after {
[INFO] [stderr] 246 | |     Some(n) => fields.push(("x_delete_after".to_owned(), format!("{}", n))),
[INFO] [stderr] 247 | |     None => ()
[INFO] [stderr] 248 | |   };
[INFO] [stderr]     | |___^ help: try this: `if let Some(n) = delete_after { fields.push(("x_delete_after".to_owned(), format!("{}", n))) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:254:18
[INFO] [stderr]     |
[INFO] [stderr] 254 |   env::var(name).expect(& format!("{} environment variable not defined", name))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} environment variable not defined", name))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:331:11
[INFO] [stderr]     |
[INFO] [stderr] 331 |              splitter.next().map(|s| s.to_owned()).map(|t| {
[INFO] [stderr]     |   ___________^
[INFO] [stderr]     |  |___________|
[INFO] [stderr]     | ||
[INFO] [stderr] 332 | ||             opt_token = Some(t.trim().to_owned());
[INFO] [stderr] 333 | ||           }); ()
[INFO] [stderr]     | ||____________^- help: try this: `if let Some(t) = splitter.next().map(|s| s.to_owned()) { opt_token = Some(t.trim().to_owned()); }`
[INFO] [stderr]     | |_____________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:359:18
[INFO] [stderr]     |
[INFO] [stderr] 359 |         .map_err(|e| From::from(e))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:364:22
[INFO] [stderr]     |
[INFO] [stderr] 364 |             .map_err(|e| From::from(e))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:379:70
[INFO] [stderr]     |
[INFO] [stderr] 379 |           item.get("endpoints").and_then(|v| v.as_array()).map(|v| v.into_iter()),
[INFO] [stderr]     |                                                                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:405:14
[INFO] [stderr]     |
[INFO] [stderr] 405 |   easy.url(& format!("{}", info.url))?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `info.url.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:413:11
[INFO] [stderr]     |
[INFO] [stderr] 413 |              splitter.next().map(|s| s.to_owned()).map(|t| {
[INFO] [stderr]     |   ___________^
[INFO] [stderr]     |  |___________|
[INFO] [stderr]     | ||
[INFO] [stderr] 414 | ||             opt_temp_url_key = Some(t.trim().to_owned());
[INFO] [stderr] 415 | ||           }); ()
[INFO] [stderr]     | ||____________^- help: try this: `if let Some(t) = splitter.next().map(|s| s.to_owned()) { opt_temp_url_key = Some(t.trim().to_owned()); }`
[INFO] [stderr]     | |_____________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:425:14
[INFO] [stderr]     |
[INFO] [stderr] 425 |     .map_err(|e| From::from(e))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:440:14
[INFO] [stderr]     |
[INFO] [stderr] 440 |   easy.url(& format!("{}", info.url))?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `info.url.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:444:14
[INFO] [stderr]     |
[INFO] [stderr] 444 |     .map_err(|e| From::from(e))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:464:14
[INFO] [stderr]     |
[INFO] [stderr] 464 |     .map_err(|e| From::from(e))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:485:14
[INFO] [stderr]     |
[INFO] [stderr] 485 |     .map_err(|e| From::from(e))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:501:20
[INFO] [stderr]     |
[INFO] [stderr] 501 |     max_file_size: &u64,
[INFO] [stderr]     |                    ^^^^ help: consider passing by value instead: `u64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:502:21
[INFO] [stderr]     |
[INFO] [stderr] 502 |     max_file_count: &usize,
[INFO] [stderr]     |                     ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:503:14
[INFO] [stderr]     |
[INFO] [stderr] 503 |     expires: &u64,
[INFO] [stderr]     |              ^^^^ help: consider passing by value instead: `u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:541:1
[INFO] [stderr]     |
[INFO] [stderr] 541 | / fn read_form_template_file<'a>(config_file: &'a Path) -> Result<FormTemplate, Box<Error>> {
[INFO] [stderr] 542 | |   let f = File::open(config_file)?;
[INFO] [stderr] 543 | |   let rdr = BufReader::new(f);
[INFO] [stderr] 544 | |   serde_json::from_reader(rdr).map_err(|e| From::from(e))
[INFO] [stderr] 545 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:544:40
[INFO] [stderr]     |
[INFO] [stderr] 544 |   serde_json::from_reader(rdr).map_err(|e| From::from(e))
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:196:19
[INFO] [stderr]     |
[INFO] [stderr] 196 |     assert!(files.into_iter().all(|f: &&Path| f.is_file()));
[INFO] [stderr]     |                   ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:219:12
[INFO] [stderr]     |
[INFO] [stderr] 219 |     files: &'a Vec<&Path>) -> () {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: change this to: `&[&Path]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:225:11
[INFO] [stderr]     |
[INFO] [stderr] 225 |     files.into_iter()
[INFO] [stderr]     |           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:243:30
[INFO] [stderr]     |
[INFO] [stderr] 243 |     ("signature".to_owned(), format!("{}", form_template.signature))
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `form_template.signature.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:245:3
[INFO] [stderr]     |
[INFO] [stderr] 245 | /   match delete_after {
[INFO] [stderr] 246 | |     Some(n) => fields.push(("x_delete_after".to_owned(), format!("{}", n))),
[INFO] [stderr] 247 | |     None => ()
[INFO] [stderr] 248 | |   };
[INFO] [stderr]     | |___^ help: try this: `if let Some(n) = delete_after { fields.push(("x_delete_after".to_owned(), format!("{}", n))) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:254:18
[INFO] [stderr]     |
[INFO] [stderr] 254 |   env::var(name).expect(& format!("{} environment variable not defined", name))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} environment variable not defined", name))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:331:11
[INFO] [stderr]     |
[INFO] [stderr] 331 |              splitter.next().map(|s| s.to_owned()).map(|t| {
[INFO] [stderr]     |   ___________^
[INFO] [stderr]     |  |___________|
[INFO] [stderr]     | ||
[INFO] [stderr] 332 | ||             opt_token = Some(t.trim().to_owned());
[INFO] [stderr] 333 | ||           }); ()
[INFO] [stderr]     | ||____________^- help: try this: `if let Some(t) = splitter.next().map(|s| s.to_owned()) { opt_token = Some(t.trim().to_owned()); }`
[INFO] [stderr]     | |_____________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:359:18
[INFO] [stderr]     |
[INFO] [stderr] 359 |         .map_err(|e| From::from(e))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:364:22
[INFO] [stderr]     |
[INFO] [stderr] 364 |             .map_err(|e| From::from(e))
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:379:70
[INFO] [stderr]     |
[INFO] [stderr] 379 |           item.get("endpoints").and_then(|v| v.as_array()).map(|v| v.into_iter()),
[INFO] [stderr]     |                                                                      ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:405:14
[INFO] [stderr]     |
[INFO] [stderr] 405 |   easy.url(& format!("{}", info.url))?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `info.url.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/main.rs:413:11
[INFO] [stderr]     |
[INFO] [stderr] 413 |              splitter.next().map(|s| s.to_owned()).map(|t| {
[INFO] [stderr]     |   ___________^
[INFO] [stderr]     |  |___________|
[INFO] [stderr]     | ||
[INFO] [stderr] 414 | ||             opt_temp_url_key = Some(t.trim().to_owned());
[INFO] [stderr] 415 | ||           }); ()
[INFO] [stderr]     | ||____________^- help: try this: `if let Some(t) = splitter.next().map(|s| s.to_owned()) { opt_temp_url_key = Some(t.trim().to_owned()); }`
[INFO] [stderr]     | |_____________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:425:14
[INFO] [stderr]     |
[INFO] [stderr] 425 |     .map_err(|e| From::from(e))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:440:14
[INFO] [stderr]     |
[INFO] [stderr] 440 |   easy.url(& format!("{}", info.url))?;
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `info.url.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:444:14
[INFO] [stderr]     |
[INFO] [stderr] 444 |     .map_err(|e| From::from(e))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:464:14
[INFO] [stderr]     |
[INFO] [stderr] 464 |     .map_err(|e| From::from(e))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:485:14
[INFO] [stderr]     |
[INFO] [stderr] 485 |     .map_err(|e| From::from(e))
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:501:20
[INFO] [stderr]     |
[INFO] [stderr] 501 |     max_file_size: &u64,
[INFO] [stderr]     |                    ^^^^ help: consider passing by value instead: `u64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:502:21
[INFO] [stderr]     |
[INFO] [stderr] 502 |     max_file_count: &usize,
[INFO] [stderr]     |                     ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/main.rs:503:14
[INFO] [stderr]     |
[INFO] [stderr] 503 |     expires: &u64,
[INFO] [stderr]     |              ^^^^ help: consider passing by value instead: `u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:541:1
[INFO] [stderr]     |
[INFO] [stderr] 541 | / fn read_form_template_file<'a>(config_file: &'a Path) -> Result<FormTemplate, Box<Error>> {
[INFO] [stderr] 542 | |   let f = File::open(config_file)?;
[INFO] [stderr] 543 | |   let rdr = BufReader::new(f);
[INFO] [stderr] 544 | |   serde_json::from_reader(rdr).map_err(|e| From::from(e))
[INFO] [stderr] 545 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:544:40
[INFO] [stderr]     |
[INFO] [stderr] 544 |   serde_json::from_reader(rdr).map_err(|e| From::from(e))
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `From::from`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2m 44s
[INFO] running `"docker" "inspect" "3246d79e8a0d0edf0dcee66ee9b2e7154fefe14a3ff3c88dd1ba4c2952886783"`
[INFO] running `"docker" "rm" "-f" "3246d79e8a0d0edf0dcee66ee9b2e7154fefe14a3ff3c88dd1ba4c2952886783"`
[INFO] [stdout] 3246d79e8a0d0edf0dcee66ee9b2e7154fefe14a3ff3c88dd1ba4c2952886783