[INFO] updating cached repository uptech/alt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/uptech/alt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/uptech/alt" "work/ex/clippy-test-run/sources/stable/gh/uptech/alt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/uptech/alt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/uptech/alt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uptech/alt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uptech/alt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c495007e3db507e744f4ad6f5308eeb65d12c4e2 [INFO] sha for GitHub repo uptech/alt: c495007e3db507e744f4ad6f5308eeb65d12c4e2 [INFO] validating manifest of uptech/alt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of uptech/alt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing uptech/alt [INFO] finished frobbing uptech/alt [INFO] frobbed toml for uptech/alt written to work/ex/clippy-test-run/sources/stable/gh/uptech/alt/Cargo.toml [INFO] started frobbing uptech/alt [INFO] finished frobbing uptech/alt [INFO] frobbed toml for uptech/alt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uptech/alt/Cargo.toml [INFO] crate uptech/alt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting uptech/alt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/uptech/alt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a9ac7b29c35c5ded40de452024e9011c68573b3c1414f41d0d4210d7baa43a1 [INFO] running `"docker" "start" "-a" "8a9ac7b29c35c5ded40de452024e9011c68573b3c1414f41d0d4210d7baa43a1"` [INFO] [stderr] Checking libc v0.2.35 [INFO] [stderr] Checking regex-syntax v0.4.2 [INFO] [stderr] Checking same-file v1.0.1 [INFO] [stderr] Checking crossbeam v0.2.12 [INFO] [stderr] Checking walkdir v2.0.1 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Checking globset v0.2.1 [INFO] [stderr] Checking ignore v0.3.1 [INFO] [stderr] Checking alt v3.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | if s.len() > 1 && s[0..2].to_string() == "./" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `s[0..2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `s2_bytes` [INFO] [stderr] --> src/main.rs:89:18 [INFO] [stderr] | [INFO] [stderr] 89 | for j in 0..s2.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for (j, ) in s2_bytes.iter().enumerate().take(s2.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has the same condition as a previous if [INFO] [stderr] --> src/main.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | else if scoreb < scorea { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::ifs_same_cond)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:117:16 [INFO] [stderr] | [INFO] [stderr] 117 | if scorea > scoreb { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ifs_same_cond [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `alt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | if s.len() > 1 && s[0..2].to_string() == "./" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `s[0..2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `s2_bytes` [INFO] [stderr] --> src/main.rs:89:18 [INFO] [stderr] | [INFO] [stderr] 89 | for j in 0..s2.len() { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for (j, ) in s2_bytes.iter().enumerate().take(s2.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has the same condition as a previous if [INFO] [stderr] --> src/main.rs:120:21 [INFO] [stderr] | [INFO] [stderr] 120 | else if scoreb < scorea { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::ifs_same_cond)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:117:16 [INFO] [stderr] | [INFO] [stderr] 117 | if scorea > scoreb { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ifs_same_cond [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `alt`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8a9ac7b29c35c5ded40de452024e9011c68573b3c1414f41d0d4210d7baa43a1"` [INFO] running `"docker" "rm" "-f" "8a9ac7b29c35c5ded40de452024e9011c68573b3c1414f41d0d4210d7baa43a1"` [INFO] [stdout] 8a9ac7b29c35c5ded40de452024e9011c68573b3c1414f41d0d4210d7baa43a1