[INFO] updating cached repository upsuper/svg-path-utils [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/upsuper/svg-path-utils [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/upsuper/svg-path-utils" "work/ex/clippy-test-run/sources/stable/gh/upsuper/svg-path-utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/upsuper/svg-path-utils'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/upsuper/svg-path-utils" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsuper/svg-path-utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsuper/svg-path-utils'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6d343f3fd3669d526fba4ec4a70e2cd6182fc61a [INFO] sha for GitHub repo upsuper/svg-path-utils: 6d343f3fd3669d526fba4ec4a70e2cd6182fc61a [INFO] validating manifest of upsuper/svg-path-utils on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of upsuper/svg-path-utils on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing upsuper/svg-path-utils [INFO] finished frobbing upsuper/svg-path-utils [INFO] frobbed toml for upsuper/svg-path-utils written to work/ex/clippy-test-run/sources/stable/gh/upsuper/svg-path-utils/Cargo.toml [INFO] started frobbing upsuper/svg-path-utils [INFO] finished frobbing upsuper/svg-path-utils [INFO] frobbed toml for upsuper/svg-path-utils written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsuper/svg-path-utils/Cargo.toml [INFO] crate upsuper/svg-path-utils has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting upsuper/svg-path-utils against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/upsuper/svg-path-utils:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4dff899cdc48f21b850c77ba78097f5fb9b1a9c2aa72cf2e98cf39900b2586a4 [INFO] running `"docker" "start" "-a" "4dff899cdc48f21b850c77ba78097f5fb9b1a9c2aa72cf2e98cf39900b2586a4"` [INFO] [stderr] Checking bitflags v0.4.0 [INFO] [stderr] Checking unicode-width v0.1.3 [INFO] [stderr] Checking encode_unicode v0.1.3 [INFO] [stderr] Checking regex-syntax v0.3.7 [INFO] [stderr] Checking lazy_static v0.2.1 [INFO] [stderr] Checking leak v0.1.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking regex v0.1.77 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking svg-path-utils v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/parser.rs:38:37 [INFO] [stderr] | [INFO] [stderr] 38 | for &(name, param) in table.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | if format.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `format.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:125:1 [INFO] [stderr] | [INFO] [stderr] 125 | / pub fn parse_commands<'c>(content: &'c str) -> Commands<'c> { [INFO] [stderr] 126 | | Commands { [INFO] [stderr] 127 | | iter: Tokens { [INFO] [stderr] 128 | | content: content, [INFO] [stderr] ... | [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `svg-path-utils`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/parser.rs:38:37 [INFO] [stderr] | [INFO] [stderr] 38 | for &(name, param) in table.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | if format.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `format.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:125:1 [INFO] [stderr] | [INFO] [stderr] 125 | / pub fn parse_commands<'c>(content: &'c str) -> Commands<'c> { [INFO] [stderr] 126 | | Commands { [INFO] [stderr] 127 | | iter: Tokens { [INFO] [stderr] 128 | | content: content, [INFO] [stderr] ... | [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `svg-path-utils`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4dff899cdc48f21b850c77ba78097f5fb9b1a9c2aa72cf2e98cf39900b2586a4"` [INFO] running `"docker" "rm" "-f" "4dff899cdc48f21b850c77ba78097f5fb9b1a9c2aa72cf2e98cf39900b2586a4"` [INFO] [stdout] 4dff899cdc48f21b850c77ba78097f5fb9b1a9c2aa72cf2e98cf39900b2586a4