[INFO] updating cached repository upsuper/maildir-pack
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/upsuper/maildir-pack
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/upsuper/maildir-pack" "work/ex/clippy-test-run/sources/stable/gh/upsuper/maildir-pack"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/upsuper/maildir-pack'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/upsuper/maildir-pack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsuper/maildir-pack"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsuper/maildir-pack'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e749841db587c29854aa7064fa8bd1c877fda37a
[INFO] sha for GitHub repo upsuper/maildir-pack: e749841db587c29854aa7064fa8bd1c877fda37a
[INFO] validating manifest of upsuper/maildir-pack on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of upsuper/maildir-pack on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing upsuper/maildir-pack
[INFO] finished frobbing upsuper/maildir-pack
[INFO] frobbed toml for upsuper/maildir-pack written to work/ex/clippy-test-run/sources/stable/gh/upsuper/maildir-pack/Cargo.toml
[INFO] started frobbing upsuper/maildir-pack
[INFO] finished frobbing upsuper/maildir-pack
[INFO] frobbed toml for upsuper/maildir-pack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/upsuper/maildir-pack/Cargo.toml
[INFO] crate upsuper/maildir-pack has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting upsuper/maildir-pack against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/upsuper/maildir-pack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 277bd48432c6e4fd33b4fcf753fc9fdf9997b4508758c3f0c184ff5165333f68
[INFO] running `"docker" "start" "-a" "277bd48432c6e4fd33b4fcf753fc9fdf9997b4508758c3f0c184ff5165333f68"`
[INFO] [stderr]     Checking byte-tools v0.3.0
[INFO] [stderr]    Compiling rayon v1.0.3
[INFO] [stderr]     Checking byteorder v1.2.7
[INFO] [stderr]     Checking ascii v0.9.1
[INFO] [stderr]     Checking either v1.5.0
[INFO] [stderr]     Checking fake-simd v0.1.2
[INFO] [stderr]     Checking opaque-debug v0.2.1
[INFO] [stderr]     Checking leak v0.1.2
[INFO] [stderr]     Checking rand_hc v0.1.0
[INFO] [stderr]     Checking rand_isaac v0.1.1
[INFO] [stderr]     Checking rand_xorshift v0.1.0
[INFO] [stderr]     Checking crossbeam-utils v0.2.2
[INFO] [stderr]     Checking arrayvec v0.4.8
[INFO] [stderr]    Compiling lzma-sys v0.1.11
[INFO] [stderr]     Checking block-padding v0.1.2
[INFO] [stderr]     Checking smallvec v0.6.7
[INFO] [stderr]     Checking lock_api v0.1.5
[INFO] [stderr]    Compiling rand_pcg v0.1.1
[INFO] [stderr]    Compiling rand_chacha v0.1.0
[INFO] [stderr]    Compiling rand v0.6.1
[INFO] [stderr]    Compiling parking_lot_core v0.4.0
[INFO] [stderr]     Checking num_cpus v1.8.0
[INFO] [stderr]     Checking clicolors-control v0.3.1
[INFO] [stderr]     Checking termios v0.3.1
[INFO] [stderr]     Checking xattr v0.2.2
[INFO] [stderr]     Checking filetime v0.2.4
[INFO] [stderr]     Checking rand v0.4.3
[INFO] [stderr]     Checking generic-array v0.12.0
[INFO] [stderr]     Checking num-integer v0.1.39
[INFO] [stderr]     Checking number_prefix v0.2.8
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]     Checking combine v3.6.3
[INFO] [stderr]     Checking tar v0.4.20
[INFO] [stderr]     Checking chrono v0.4.6
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking xz2 v0.1.6
[INFO] [stderr]     Checking block-buffer v0.7.0
[INFO] [stderr]     Checking digest v0.8.0
[INFO] [stderr]     Checking tempdir v0.3.7
[INFO] [stderr]     Checking rayon-core v1.4.1
[INFO] [stderr]     Checking sha2 v0.8.0
[INFO] [stderr]     Checking parking_lot v0.7.0
[INFO] [stderr]     Checking console v0.7.1
[INFO] [stderr]     Checking indicatif v0.10.3
[INFO] [stderr]     Checking maildir-pack v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> tests/basic.rs:21:24
[INFO] [stderr]    |
[INFO] [stderr] 21 | const ARCHIVE_SUFFIX: &'static str = ".tar.xz";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> tests/basic.rs:22:23
[INFO] [stderr]    |
[INFO] [stderr] 22 | const BACKUP_SUFFIX: &'static str = ".tar.xz.bak";
[INFO] [stderr]    |                      -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> tests/basic.rs:65:44
[INFO] [stderr]    |
[INFO] [stderr] 65 |             let entry = result.entry(name).or_insert(vec![]);
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> tests/basic.rs:258:16
[INFO] [stderr]     |
[INFO] [stderr] 258 |             if expected_content.len() > 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!expected_content.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> tests/basic.rs:280:8
[INFO] [stderr]     |
[INFO] [stderr] 280 |     if expected.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!expected.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> tests/basic.rs:281:35
[INFO] [stderr]     |
[INFO] [stderr] 281 |         let archives = join_names(expected.keys().map(|&name| name));
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `expected.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> tests/basic.rs:285:8
[INFO] [stderr]     |
[INFO] [stderr] 285 |     if expected_backup.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!expected_backup.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> tests/basic.rs:286:34
[INFO] [stderr]     |
[INFO] [stderr] 286 |         let backups = join_names(expected_backup.keys().map(|&name| name));
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `expected_backup.keys().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> tests/basic.rs:361:18
[INFO] [stderr]     |
[INFO] [stderr] 361 |     let merged = second_set.union(&initial_set).map(|&email| email).collect();
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `second_set.union(&initial_set).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 33.55s
[INFO] running `"docker" "inspect" "277bd48432c6e4fd33b4fcf753fc9fdf9997b4508758c3f0c184ff5165333f68"`
[INFO] running `"docker" "rm" "-f" "277bd48432c6e4fd33b4fcf753fc9fdf9997b4508758c3f0c184ff5165333f68"`
[INFO] [stdout] 277bd48432c6e4fd33b4fcf753fc9fdf9997b4508758c3f0c184ff5165333f68