[INFO] updating cached repository untoldwind/razer_test_test
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/untoldwind/razer_test_test
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/untoldwind/razer_test_test" "work/ex/clippy-test-run/sources/stable/gh/untoldwind/razer_test_test"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/untoldwind/razer_test_test'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/untoldwind/razer_test_test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/untoldwind/razer_test_test"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/untoldwind/razer_test_test'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b289383f7304d827b3b92aa4ae22c97b46e74ffa
[INFO] sha for GitHub repo untoldwind/razer_test_test: b289383f7304d827b3b92aa4ae22c97b46e74ffa
[INFO] validating manifest of untoldwind/razer_test_test on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of untoldwind/razer_test_test on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing untoldwind/razer_test_test
[INFO] finished frobbing untoldwind/razer_test_test
[INFO] frobbed toml for untoldwind/razer_test_test written to work/ex/clippy-test-run/sources/stable/gh/untoldwind/razer_test_test/Cargo.toml
[INFO] started frobbing untoldwind/razer_test_test
[INFO] finished frobbing untoldwind/razer_test_test
[INFO] frobbed toml for untoldwind/razer_test_test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/untoldwind/razer_test_test/Cargo.toml
[INFO] crate untoldwind/razer_test_test has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting untoldwind/razer_test_test against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/untoldwind/razer_test_test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a684446c16721a0ab5f771420ec2cc153ab3fcc1fd449727e45f0b893ef739b2
[INFO] running `"docker" "start" "-a" "a684446c16721a0ab5f771420ec2cc153ab3fcc1fd449727e45f0b893ef739b2"`
[INFO] [stderr]    Compiling hidapi v0.5.0
[INFO] [stderr]     Checking memchr v2.1.0
[INFO] [stderr]    Compiling syn v0.14.9
[INFO] [stderr]     Checking thread_local v0.3.6
[INFO] [stderr]     Checking error-chain v0.12.0
[INFO] [stderr]     Checking aho-corasick v0.6.8
[INFO] [stderr]     Checking regex v1.0.5
[INFO] [stderr]     Checking env_logger v0.5.13
[INFO] [stderr]    Compiling synstructure v0.9.0
[INFO] [stderr]    Compiling failure_derive v0.1.2
[INFO] [stderr]     Checking failure v0.1.2
[INFO] [stderr]     Checking razer_test_test v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/devices/matrix_keyboard.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 | /     fn hid_device<'a>(&'a self) -> &'a HidDevice {
[INFO] [stderr] 44 | |         &self.hid_device
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/devices/matrix_mice.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 | /     fn hid_device<'a>(&'a self) -> &'a HidDevice {
[INFO] [stderr] 44 | |         &self.hid_device
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `raw`.
[INFO] [stderr]    --> src/devices/razer_report.rs:108:22
[INFO] [stderr]     |
[INFO] [stderr] 108 |             for i in 4..90 {
[INFO] [stderr]     |                      ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 108 |             for <item> in raw.iter().take(90).skip(4) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/devices/soft_keyboard.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         self.name.clone()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 18 |         &(*self.name).clone()
[INFO] [stderr]    |
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 18 |         &str::clone(self.name)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/devices/soft_keyboard.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     fn hid_device<'a>(&'a self) -> &'a HidDevice {
[INFO] [stderr] 40 | |         &self.hid_device
[INFO] [stderr] 41 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/devices/mod.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     fn hid_device<'a>(&'a self) -> &'a HidDevice;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/main.rs:45:12
[INFO] [stderr]    |
[INFO] [stderr] 45 |       if let Some(_) = matches.subcommand_matches("list") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 46 | |         cli::list_devices().unwrap();
[INFO] [stderr] 47 | |     } else if let Some(_) = matches.subcommand_matches("get-brightness") {
[INFO] [stderr] 48 | |         cli::get_brightness().unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 54 | |         cli::set_color(color).unwrap();
[INFO] [stderr] 55 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("list").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/main.rs:47:19
[INFO] [stderr]    |
[INFO] [stderr] 47 |       } else if let Some(_) = matches.subcommand_matches("get-brightness") {
[INFO] [stderr]    |  ____________-      ^^^^^^^
[INFO] [stderr] 48 | |         cli::get_brightness().unwrap();
[INFO] [stderr] 49 | |     } else if let Some(sub_matches) = matches.subcommand_matches("set-brightness") {
[INFO] [stderr] 50 | |         let brightness = sub_matches.value_of("brightness").unwrap().parse::<u8>().unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 54 | |         cli::set_color(color).unwrap();
[INFO] [stderr] 55 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("get-brightness").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `razer_test_test`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/devices/matrix_keyboard.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 | /     fn hid_device<'a>(&'a self) -> &'a HidDevice {
[INFO] [stderr] 44 | |         &self.hid_device
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/devices/matrix_mice.rs:43:5
[INFO] [stderr]    |
[INFO] [stderr] 43 | /     fn hid_device<'a>(&'a self) -> &'a HidDevice {
[INFO] [stderr] 44 | |         &self.hid_device
[INFO] [stderr] 45 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `raw`.
[INFO] [stderr]    --> src/devices/razer_report.rs:108:22
[INFO] [stderr]     |
[INFO] [stderr] 108 |             for i in 4..90 {
[INFO] [stderr]     |                      ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 108 |             for <item> in raw.iter().take(90).skip(4) {
[INFO] [stderr]     |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/devices/soft_keyboard.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 |         self.name.clone()
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 18 |         &(*self.name).clone()
[INFO] [stderr]    |
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 18 |         &str::clone(self.name)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/devices/soft_keyboard.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 | /     fn hid_device<'a>(&'a self) -> &'a HidDevice {
[INFO] [stderr] 40 | |         &self.hid_device
[INFO] [stderr] 41 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/devices/mod.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     fn hid_device<'a>(&'a self) -> &'a HidDevice;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/main.rs:45:12
[INFO] [stderr]    |
[INFO] [stderr] 45 |       if let Some(_) = matches.subcommand_matches("list") {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 46 | |         cli::list_devices().unwrap();
[INFO] [stderr] 47 | |     } else if let Some(_) = matches.subcommand_matches("get-brightness") {
[INFO] [stderr] 48 | |         cli::get_brightness().unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 54 | |         cli::set_color(color).unwrap();
[INFO] [stderr] 55 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("list").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/main.rs:47:19
[INFO] [stderr]    |
[INFO] [stderr] 47 |       } else if let Some(_) = matches.subcommand_matches("get-brightness") {
[INFO] [stderr]    |  ____________-      ^^^^^^^
[INFO] [stderr] 48 | |         cli::get_brightness().unwrap();
[INFO] [stderr] 49 | |     } else if let Some(sub_matches) = matches.subcommand_matches("set-brightness") {
[INFO] [stderr] 50 | |         let brightness = sub_matches.value_of("brightness").unwrap().parse::<u8>().unwrap();
[INFO] [stderr] ...  |
[INFO] [stderr] 54 | |         cli::set_color(color).unwrap();
[INFO] [stderr] 55 | |     }
[INFO] [stderr]    | |_____- help: try this: `if matches.subcommand_matches("get-brightness").is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `razer_test_test`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "a684446c16721a0ab5f771420ec2cc153ab3fcc1fd449727e45f0b893ef739b2"`
[INFO] running `"docker" "rm" "-f" "a684446c16721a0ab5f771420ec2cc153ab3fcc1fd449727e45f0b893ef739b2"`
[INFO] [stdout] a684446c16721a0ab5f771420ec2cc153ab3fcc1fd449727e45f0b893ef739b2