[INFO] updating cached repository unrust/uni-app [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/unrust/uni-app [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/unrust/uni-app" "work/ex/clippy-test-run/sources/stable/gh/unrust/uni-app"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/unrust/uni-app'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/unrust/uni-app" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unrust/uni-app"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unrust/uni-app'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 99edbfcf7c02660f7d31aa68d3b5ab5d89cf1f45 [INFO] sha for GitHub repo unrust/uni-app: 99edbfcf7c02660f7d31aa68d3b5ab5d89cf1f45 [INFO] validating manifest of unrust/uni-app on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unrust/uni-app on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unrust/uni-app [INFO] finished frobbing unrust/uni-app [INFO] frobbed toml for unrust/uni-app written to work/ex/clippy-test-run/sources/stable/gh/unrust/uni-app/Cargo.toml [INFO] started frobbing unrust/uni-app [INFO] finished frobbing unrust/uni-app [INFO] frobbed toml for unrust/uni-app written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unrust/uni-app/Cargo.toml [INFO] crate unrust/uni-app has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unrust/uni-app against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/unrust/uni-app:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 744b7eb37355ed8e3df74b8d7c59167edb14b4efda927f4c466b016f2d53eba3 [INFO] running `"docker" "start" "-a" "744b7eb37355ed8e3df74b8d7c59167edb14b4efda927f4c466b016f2d53eba3"` [INFO] [stderr] Compiling pkg-config v0.3.12 [INFO] [stderr] Compiling cfg-if v0.1.4 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking rand v0.5.4 [INFO] [stderr] Compiling wayland-scanner v0.20.11 [INFO] [stderr] Checking smallvec v0.6.3 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Compiling log v0.4.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Compiling x11-dl v2.18.2 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Checking wayland-sys v0.20.11 [INFO] [stderr] Compiling wayland-client v0.20.11 [INFO] [stderr] Compiling wayland-protocols v0.20.11 [INFO] [stderr] Checking tempfile v3.0.3 [INFO] [stderr] Checking wayland-commons v0.20.11 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking uni-app v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/native_app.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/native_app.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/native_app.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | return self.window.hidpi_factor(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.window.hidpi_factor()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/native_app.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | return running; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `running` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/native_app.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | return !self.exiting; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.exiting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/native_app.rs:313:5 [INFO] [stderr] | [INFO] [stderr] 313 | return time::precise_time_s(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `time::precise_time_s()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/native_app.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | Normal(glutin::GlWindow), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 19 | Normal(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/native_app.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &WindowContext::Normal(ref w) => w.get_hidpi_factor() as f32, [INFO] [stderr] 27 | | _ => 1.0, [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | WindowContext::Normal(ref w) => w.get_hidpi_factor() as f32, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/native_app.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self { [INFO] [stderr] 33 | | &WindowContext::Normal(ref w) => w, [INFO] [stderr] 34 | | _ => unimplemented!(), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self { [INFO] [stderr] 33 | WindowContext::Normal(ref w) => w, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/native_app.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match self { [INFO] [stderr] 40 | | &WindowContext::Normal(ref w) => w, [INFO] [stderr] 41 | | &WindowContext::Headless(ref w) => w, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *self { [INFO] [stderr] 40 | WindowContext::Normal(ref w) => w, [INFO] [stderr] 41 | WindowContext::Headless(ref w) => w, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/native_app.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self { [INFO] [stderr] 48 | | &WindowContext::Normal(ref w) => w.swap_buffers(), [INFO] [stderr] 49 | | &WindowContext::Headless(_) => Ok(()), [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *self { [INFO] [stderr] 48 | WindowContext::Normal(ref w) => w.swap_buffers(), [INFO] [stderr] 49 | WindowContext::Headless(_) => Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/native_app.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | / match event { [INFO] [stderr] 239 | | glutin::Event::WindowEvent { ref event, .. } => match event { [INFO] [stderr] 240 | | &glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 241 | | &glutin::WindowEvent::Resized(size) => { [INFO] [stderr] ... | [INFO] [stderr] 260 | | _ => (), [INFO] [stderr] 261 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 238 | if let glutin::Event::WindowEvent { ref event, .. } = event { match event { [INFO] [stderr] 239 | &glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 240 | &glutin::WindowEvent::Resized(size) => { [INFO] [stderr] 241 | // Fixed for Windows which minimized to emit a Resized(0,0) event [INFO] [stderr] 242 | if size.width != 0.0 && size.height != 0.0 { [INFO] [stderr] 243 | window.window().resize(size.to_physical(dpi_factor as f64)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/native_app.rs:239:65 [INFO] [stderr] | [INFO] [stderr] 239 | glutin::Event::WindowEvent { ref event, .. } => match event { [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 240 | | &glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 241 | | &glutin::WindowEvent::Resized(size) => { [INFO] [stderr] 242 | | // Fixed for Windows which minimized to emit a Resized(0,0) event [INFO] [stderr] ... | [INFO] [stderr] 258 | | _ => (), [INFO] [stderr] 259 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 239 | glutin::Event::WindowEvent { ref event, .. } => match *event { [INFO] [stderr] 240 | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 241 | glutin::WindowEvent::Resized(size) => { [INFO] [stderr] 242 | // Fixed for Windows which minimized to emit a Resized(0,0) event [INFO] [stderr] 243 | if size.width != 0.0 && size.height != 0.0 { [INFO] [stderr] 244 | window.window().resize(size.to_physical(dpi_factor as f64)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/native_app.rs:244:69 [INFO] [stderr] | [INFO] [stderr] 244 | window.window().resize(size.to_physical(dpi_factor as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(dpi_factor)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/native_app.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | translate_event(event, dpi_factor).map(|evt| events.borrow_mut().push(evt)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(evt) = translate_event(event, dpi_factor) { events.borrow_mut().push(evt) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/native_app.rs:285:16 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn run<'a, F>(mut self, mut callback: F) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/native_app.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | return self.window.hidpi_factor(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.window.hidpi_factor()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/native_app.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | return running; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `running` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/native_app.rs:281:9 [INFO] [stderr] | [INFO] [stderr] 281 | return !self.exiting; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!self.exiting` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/native_app.rs:313:5 [INFO] [stderr] | [INFO] [stderr] 313 | return time::precise_time_s(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `time::precise_time_s()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/native_app.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | Normal(glutin::GlWindow), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 19 | Normal(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/native_app.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &WindowContext::Normal(ref w) => w.get_hidpi_factor() as f32, [INFO] [stderr] 27 | | _ => 1.0, [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | WindowContext::Normal(ref w) => w.get_hidpi_factor() as f32, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/native_app.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match self { [INFO] [stderr] 33 | | &WindowContext::Normal(ref w) => w, [INFO] [stderr] 34 | | _ => unimplemented!(), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 32 | match *self { [INFO] [stderr] 33 | WindowContext::Normal(ref w) => w, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/native_app.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match self { [INFO] [stderr] 40 | | &WindowContext::Normal(ref w) => w, [INFO] [stderr] 41 | | &WindowContext::Headless(ref w) => w, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *self { [INFO] [stderr] 40 | WindowContext::Normal(ref w) => w, [INFO] [stderr] 41 | WindowContext::Headless(ref w) => w, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/native_app.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | / match self { [INFO] [stderr] 48 | | &WindowContext::Normal(ref w) => w.swap_buffers(), [INFO] [stderr] 49 | | &WindowContext::Headless(_) => Ok(()), [INFO] [stderr] 50 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 47 | match *self { [INFO] [stderr] 48 | WindowContext::Normal(ref w) => w.swap_buffers(), [INFO] [stderr] 49 | WindowContext::Headless(_) => Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/native_app.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | / match event { [INFO] [stderr] 239 | | glutin::Event::WindowEvent { ref event, .. } => match event { [INFO] [stderr] 240 | | &glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 241 | | &glutin::WindowEvent::Resized(size) => { [INFO] [stderr] ... | [INFO] [stderr] 260 | | _ => (), [INFO] [stderr] 261 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 238 | if let glutin::Event::WindowEvent { ref event, .. } = event { match event { [INFO] [stderr] 239 | &glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 240 | &glutin::WindowEvent::Resized(size) => { [INFO] [stderr] 241 | // Fixed for Windows which minimized to emit a Resized(0,0) event [INFO] [stderr] 242 | if size.width != 0.0 && size.height != 0.0 { [INFO] [stderr] 243 | window.window().resize(size.to_physical(dpi_factor as f64)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/native_app.rs:239:65 [INFO] [stderr] | [INFO] [stderr] 239 | glutin::Event::WindowEvent { ref event, .. } => match event { [INFO] [stderr] | _________________________________________________________________^ [INFO] [stderr] 240 | | &glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 241 | | &glutin::WindowEvent::Resized(size) => { [INFO] [stderr] 242 | | // Fixed for Windows which minimized to emit a Resized(0,0) event [INFO] [stderr] ... | [INFO] [stderr] 258 | | _ => (), [INFO] [stderr] 259 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 239 | glutin::Event::WindowEvent { ref event, .. } => match *event { [INFO] [stderr] 240 | glutin::WindowEvent::CloseRequested => running = false, [INFO] [stderr] 241 | glutin::WindowEvent::Resized(size) => { [INFO] [stderr] 242 | // Fixed for Windows which minimized to emit a Resized(0,0) event [INFO] [stderr] 243 | if size.width != 0.0 && size.height != 0.0 { [INFO] [stderr] 244 | window.window().resize(size.to_physical(dpi_factor as f64)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/native_app.rs:244:69 [INFO] [stderr] | [INFO] [stderr] 244 | window.window().resize(size.to_physical(dpi_factor as f64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(dpi_factor)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/native_app.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | translate_event(event, dpi_factor).map(|evt| events.borrow_mut().push(evt)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(evt) = translate_event(event, dpi_factor) { events.borrow_mut().push(evt) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/native_app.rs:285:16 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn run<'a, F>(mut self, mut callback: F) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/basic.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | / match evt { [INFO] [stderr] 21 | | &uni_app::AppEvent::KeyUp(_) => { [INFO] [stderr] 22 | | uni_app::App::exit(); [INFO] [stderr] 23 | | } [INFO] [stderr] ... | [INFO] [stderr] 27 | | _ => (), [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *evt { [INFO] [stderr] 21 | uni_app::AppEvent::KeyUp(_) => { [INFO] [stderr] 22 | uni_app::App::exit(); [INFO] [stderr] 23 | } [INFO] [stderr] 24 | uni_app::AppEvent::MouseUp(_) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.31s [INFO] running `"docker" "inspect" "744b7eb37355ed8e3df74b8d7c59167edb14b4efda927f4c466b016f2d53eba3"` [INFO] running `"docker" "rm" "-f" "744b7eb37355ed8e3df74b8d7c59167edb14b4efda927f4c466b016f2d53eba3"` [INFO] [stdout] 744b7eb37355ed8e3df74b8d7c59167edb14b4efda927f4c466b016f2d53eba3