[INFO] updating cached repository unixpickle/squidtun [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/unixpickle/squidtun [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/unixpickle/squidtun" "work/ex/clippy-test-run/sources/stable/gh/unixpickle/squidtun"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/unixpickle/squidtun'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/unixpickle/squidtun" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unixpickle/squidtun"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unixpickle/squidtun'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 69c8b05b86b62f30c7c396667c126132a15ab235 [INFO] sha for GitHub repo unixpickle/squidtun: 69c8b05b86b62f30c7c396667c126132a15ab235 [INFO] validating manifest of unixpickle/squidtun on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unixpickle/squidtun on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unixpickle/squidtun [INFO] finished frobbing unixpickle/squidtun [INFO] frobbed toml for unixpickle/squidtun written to work/ex/clippy-test-run/sources/stable/gh/unixpickle/squidtun/Cargo.toml [INFO] started frobbing unixpickle/squidtun [INFO] finished frobbing unixpickle/squidtun [INFO] frobbed toml for unixpickle/squidtun written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unixpickle/squidtun/Cargo.toml [INFO] crate unixpickle/squidtun has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unixpickle/squidtun against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/unixpickle/squidtun:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6284050b6c68788621ed726c1e9cfdb3a9177a8168f6c53b18f47dbdff5097b8 [INFO] running `"docker" "start" "-a" "6284050b6c68788621ed726c1e9cfdb3a9177a8168f6c53b18f47dbdff5097b8"` [INFO] [stderr] Checking base64 v0.9.0 [INFO] [stderr] Checking simple_logger v0.5.0 [INFO] [stderr] Checking tokio-core v0.1.16 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking hyper v0.11.25 [INFO] [stderr] Checking squidtun v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/future_util.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | ReadStream{reader: reader, buf_size: buf_size} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/future_util.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | ReadStream{reader: reader, buf_size: buf_size} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `buf_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/future_util.rs:46:19 [INFO] [stderr] | [INFO] [stderr] 46 | WriteSink{writer: writer, cur_buf: None} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/session.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/session.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/server.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | sessions: sessions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sessions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/server.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | password: password, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/session.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/session.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/server.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | sessions: sessions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sessions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/server.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | password: password, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `password` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/future_util.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | ReadStream{reader: reader, buf_size: buf_size} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/future_util.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | ReadStream{reader: reader, buf_size: buf_size} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `buf_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/future_util.rs:46:19 [INFO] [stderr] | [INFO] [stderr] 46 | WriteSink{writer: writer, cur_buf: None} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/client/main.rs:167:20 [INFO] [stderr] | [INFO] [stderr] 167 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 168 | | if data[0] == 1 { [INFO] [stderr] 169 | | Ok(Some(data[1..data.len()].to_vec())) [INFO] [stderr] 170 | | } else { [INFO] [stderr] 171 | | Ok(None) [INFO] [stderr] 172 | | } [INFO] [stderr] 173 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 167 | } else if data[0] == 1 { [INFO] [stderr] 168 | Ok(Some(data[1..data.len()].to_vec())) [INFO] [stderr] 169 | } else { [INFO] [stderr] 170 | Ok(None) [INFO] [stderr] 171 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/client/main.rs:167:20 [INFO] [stderr] | [INFO] [stderr] 167 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 168 | | if data[0] == 1 { [INFO] [stderr] 169 | | Ok(Some(data[1..data.len()].to_vec())) [INFO] [stderr] 170 | | } else { [INFO] [stderr] 171 | | Ok(None) [INFO] [stderr] 172 | | } [INFO] [stderr] 173 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 167 | } else if data[0] == 1 { [INFO] [stderr] 168 | Ok(Some(data[1..data.len()].to_vec())) [INFO] [stderr] 169 | } else { [INFO] [stderr] 170 | Ok(None) [INFO] [stderr] 171 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server/server.rs:82:27 [INFO] [stderr] | [INFO] [stderr] 82 | Ok(if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/server/server.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | "closed stdout".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"closed stdout"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server/server.rs:176:36 [INFO] [stderr] | [INFO] [stderr] 176 | if components.len() < 3 || components[0].len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!components[0].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server/server.rs:179:23 [INFO] [stderr] | [INFO] [stderr] 179 | let prefixes: Vec<(&str, Box RequestInfo>)> = vec![ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/server.rs:180:34 [INFO] [stderr] | [INFO] [stderr] 180 | ("connect", Box::new(|s| RequestInfo::Connect(s))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestInfo::Connect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/server.rs:181:33 [INFO] [stderr] | [INFO] [stderr] 181 | ("upload", Box::new(|s| RequestInfo::Upload(s))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestInfo::Upload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/server.rs:182:35 [INFO] [stderr] | [INFO] [stderr] 182 | ("download", Box::new(|s| RequestInfo::Download(s))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestInfo::Download` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/server.rs:183:32 [INFO] [stderr] | [INFO] [stderr] 183 | ("close", Box::new(|s| RequestInfo::Close(s))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestInfo::Close` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server/main.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | for i in (0..sessions.len()).into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..sessions.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client/main.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client/main.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | .filter(|info| info.as_ref().unwrap().len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!info.as_ref().unwrap().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client/main.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client/main.rs:176:24 [INFO] [stderr] | [INFO] [stderr] 176 | .filter(|info| info.as_ref().unwrap().len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!info.as_ref().unwrap().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server/server.rs:82:27 [INFO] [stderr] | [INFO] [stderr] 82 | Ok(if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/server/server.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | "closed stdout".as_bytes().to_vec() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"closed stdout"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/server/server.rs:176:36 [INFO] [stderr] | [INFO] [stderr] 176 | if components.len() < 3 || components[0].len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!components[0].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server/server.rs:179:23 [INFO] [stderr] | [INFO] [stderr] 179 | let prefixes: Vec<(&str, Box RequestInfo>)> = vec![ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/server.rs:180:34 [INFO] [stderr] | [INFO] [stderr] 180 | ("connect", Box::new(|s| RequestInfo::Connect(s))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestInfo::Connect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/server.rs:181:33 [INFO] [stderr] | [INFO] [stderr] 181 | ("upload", Box::new(|s| RequestInfo::Upload(s))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestInfo::Upload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/server.rs:182:35 [INFO] [stderr] | [INFO] [stderr] 182 | ("download", Box::new(|s| RequestInfo::Download(s))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestInfo::Download` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/server/server.rs:183:32 [INFO] [stderr] | [INFO] [stderr] 183 | ("close", Box::new(|s| RequestInfo::Close(s))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RequestInfo::Close` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server/main.rs:71:22 [INFO] [stderr] | [INFO] [stderr] 71 | for i in (0..sessions.len()).into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..sessions.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.98s [INFO] running `"docker" "inspect" "6284050b6c68788621ed726c1e9cfdb3a9177a8168f6c53b18f47dbdff5097b8"` [INFO] running `"docker" "rm" "-f" "6284050b6c68788621ed726c1e9cfdb3a9177a8168f6c53b18f47dbdff5097b8"` [INFO] [stdout] 6284050b6c68788621ed726c1e9cfdb3a9177a8168f6c53b18f47dbdff5097b8