[INFO] updating cached repository unixpickle/payrange [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/unixpickle/payrange [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/unixpickle/payrange" "work/ex/clippy-test-run/sources/stable/gh/unixpickle/payrange"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/unixpickle/payrange'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/unixpickle/payrange" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unixpickle/payrange"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unixpickle/payrange'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 024301fd721d7feabd32ef07eda9c1a294ffd362 [INFO] sha for GitHub repo unixpickle/payrange: 024301fd721d7feabd32ef07eda9c1a294ffd362 [INFO] validating manifest of unixpickle/payrange on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unixpickle/payrange on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unixpickle/payrange [INFO] finished frobbing unixpickle/payrange [INFO] frobbed toml for unixpickle/payrange written to work/ex/clippy-test-run/sources/stable/gh/unixpickle/payrange/Cargo.toml [INFO] started frobbing unixpickle/payrange [INFO] finished frobbing unixpickle/payrange [INFO] frobbed toml for unixpickle/payrange written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unixpickle/payrange/Cargo.toml [INFO] crate unixpickle/payrange has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unixpickle/payrange against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/unixpickle/payrange:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 696ae1987b3194d09e59f3e002eb865548f66368304af67757b57a338c163b65 [INFO] running `"docker" "start" "-a" "696ae1987b3194d09e59f3e002eb865548f66368304af67757b57a338c163b65"` [INFO] [stderr] Checking serde v1.0.38 [INFO] [stderr] Compiling openssl-sys v0.9.28 [INFO] [stderr] Compiling proc-macro2 v0.3.6 [INFO] [stderr] Checking base64 v0.9.0 [INFO] [stderr] Checking yaml-rust v0.4.0 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-timer v0.2.1 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking tokio-threadpool v0.1.2 [INFO] [stderr] Compiling quote v0.5.1 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Compiling serde_derive v1.0.38 [INFO] [stderr] Checking hyper v0.11.25 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking payrange v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/call.rs:29:35 [INFO] [stderr] | [INFO] [stderr] 29 | Err(Error::Remote{status: status, reason: r}) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | Client{client: client} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | phone: phone [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `phone` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/call.rs:29:35 [INFO] [stderr] | [INFO] [stderr] 29 | Err(Error::Remote{status: status, reason: r}) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:24:16 [INFO] [stderr] | [INFO] [stderr] 24 | Client{client: client} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | phone: phone [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `phone` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/error.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | &Error::Remote{status: _, reason: Some(ref r)} => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Remote { reason: Some(ref r), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/error.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | &Error::Remote{status: _, reason: Some(ref r)} => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Remote { reason: Some(ref r), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/call.rs:42:59 [INFO] [stderr] | [INFO] [stderr] 42 | req.headers_mut().set_raw("x-pr-api-level", vec![vec!['4' as u8]]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'4' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &Error::Hyper(ref e) => e.fmt(f), [INFO] [stderr] 31 | | &Error::Yaml(ref e) => e.fmt(f), [INFO] [stderr] 32 | | &Error::Remote{status: ref s, reason: Some(ref r)} => { [INFO] [stderr] ... | [INFO] [stderr] 38 | | &Error::Other(ref msg) => write!(f, "{}", msg) [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Error::Hyper(ref e) => e.fmt(f), [INFO] [stderr] 31 | Error::Yaml(ref e) => e.fmt(f), [INFO] [stderr] 32 | Error::Remote{status: ref s, reason: Some(ref r)} => { [INFO] [stderr] 33 | write!(f, "remote error with status {}: {}", s, r) [INFO] [stderr] 34 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match self { [INFO] [stderr] 46 | | &Error::Hyper(ref e) => e.description(), [INFO] [stderr] 47 | | &Error::Yaml(ref e) => e.description(), [INFO] [stderr] 48 | | &Error::Remote{status: _, reason: Some(ref r)} => { [INFO] [stderr] ... | [INFO] [stderr] 54 | | _ => "undescribed error from remote API" [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *self { [INFO] [stderr] 46 | Error::Hyper(ref e) => e.description(), [INFO] [stderr] 47 | Error::Yaml(ref e) => e.description(), [INFO] [stderr] 48 | Error::Remote{status: _, reason: Some(ref r)} => { [INFO] [stderr] 49 | r [INFO] [stderr] 50 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match self { [INFO] [stderr] 60 | | &Error::Hyper(ref e) => Some(e), [INFO] [stderr] 61 | | &Error::Yaml(ref e) => Some(e), [INFO] [stderr] 62 | | _ => None [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *self { [INFO] [stderr] 60 | Error::Hyper(ref e) => Some(e), [INFO] [stderr] 61 | Error::Yaml(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/call.rs:42:59 [INFO] [stderr] | [INFO] [stderr] 42 | req.headers_mut().set_raw("x-pr-api-level", vec![vec!['4' as u8]]); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'4' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match self { [INFO] [stderr] 30 | | &Error::Hyper(ref e) => e.fmt(f), [INFO] [stderr] 31 | | &Error::Yaml(ref e) => e.fmt(f), [INFO] [stderr] 32 | | &Error::Remote{status: ref s, reason: Some(ref r)} => { [INFO] [stderr] ... | [INFO] [stderr] 38 | | &Error::Other(ref msg) => write!(f, "{}", msg) [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Error::Hyper(ref e) => e.fmt(f), [INFO] [stderr] 31 | Error::Yaml(ref e) => e.fmt(f), [INFO] [stderr] 32 | Error::Remote{status: ref s, reason: Some(ref r)} => { [INFO] [stderr] 33 | write!(f, "remote error with status {}: {}", s, r) [INFO] [stderr] 34 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | / match self { [INFO] [stderr] 46 | | &Error::Hyper(ref e) => e.description(), [INFO] [stderr] 47 | | &Error::Yaml(ref e) => e.description(), [INFO] [stderr] 48 | | &Error::Remote{status: _, reason: Some(ref r)} => { [INFO] [stderr] ... | [INFO] [stderr] 54 | | _ => "undescribed error from remote API" [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *self { [INFO] [stderr] 46 | Error::Hyper(ref e) => e.description(), [INFO] [stderr] 47 | Error::Yaml(ref e) => e.description(), [INFO] [stderr] 48 | Error::Remote{status: _, reason: Some(ref r)} => { [INFO] [stderr] 49 | r [INFO] [stderr] 50 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match self { [INFO] [stderr] 60 | | &Error::Hyper(ref e) => Some(e), [INFO] [stderr] 61 | | &Error::Yaml(ref e) => Some(e), [INFO] [stderr] 62 | | _ => None [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *self { [INFO] [stderr] 60 | Error::Hyper(ref e) => Some(e), [INFO] [stderr] 61 | Error::Yaml(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tools/util.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 21 | | if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 22 | | value [INFO] [stderr] 23 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | } else if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 21 | value [INFO] [stderr] 22 | } else { [INFO] [stderr] 23 | eprintln!("Must pass -token or set $PAYRANGE_TOKEN"); [INFO] [stderr] 24 | exit(1); [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tools/util.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 21 | | if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 22 | | value [INFO] [stderr] 23 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | } else if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 21 | value [INFO] [stderr] 22 | } else { [INFO] [stderr] 23 | eprintln!("Must pass -token or set $PAYRANGE_TOKEN"); [INFO] [stderr] 24 | exit(1); [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tools/util.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 21 | | if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 22 | | value [INFO] [stderr] 23 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | } else if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 21 | value [INFO] [stderr] 22 | } else { [INFO] [stderr] 23 | eprintln!("Must pass -token or set $PAYRANGE_TOKEN"); [INFO] [stderr] 24 | exit(1); [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tools/util.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 21 | | if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 22 | | value [INFO] [stderr] 23 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | } else if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 21 | value [INFO] [stderr] 22 | } else { [INFO] [stderr] 23 | eprintln!("Must pass -token or set $PAYRANGE_TOKEN"); [INFO] [stderr] 24 | exit(1); [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/tools/scan.rs:100:31 [INFO] [stderr] | [INFO] [stderr] 100 | category_top: cat_top.unwrap_or(String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cat_top.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/tools/scan.rs:101:31 [INFO] [stderr] | [INFO] [stderr] 101 | category_sub: cat_sub.unwrap_or(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cat_sub.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tools/util.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 21 | | if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 22 | | value [INFO] [stderr] 23 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | } else if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 21 | value [INFO] [stderr] 22 | } else { [INFO] [stderr] 23 | eprintln!("Must pass -token or set $PAYRANGE_TOKEN"); [INFO] [stderr] 24 | exit(1); [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/tools/scan.rs:100:31 [INFO] [stderr] | [INFO] [stderr] 100 | category_top: cat_top.unwrap_or(String::new()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cat_top.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/tools/scan.rs:101:31 [INFO] [stderr] | [INFO] [stderr] 101 | category_sub: cat_sub.unwrap_or(String::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cat_sub.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tools/util.rs:20:12 [INFO] [stderr] | [INFO] [stderr] 20 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 21 | | if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 22 | | value [INFO] [stderr] 23 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 20 | } else if let Ok(value) = env::var("PAYRANGE_TOKEN") { [INFO] [stderr] 21 | value [INFO] [stderr] 22 | } else { [INFO] [stderr] 23 | eprintln!("Must pass -token or set $PAYRANGE_TOKEN"); [INFO] [stderr] 24 | exit(1); [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.50s [INFO] running `"docker" "inspect" "696ae1987b3194d09e59f3e002eb865548f66368304af67757b57a338c163b65"` [INFO] running `"docker" "rm" "-f" "696ae1987b3194d09e59f3e002eb865548f66368304af67757b57a338c163b65"` [INFO] [stdout] 696ae1987b3194d09e59f3e002eb865548f66368304af67757b57a338c163b65