[INFO] updating cached repository underflowed/text-adventure-game-in-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/underflowed/text-adventure-game-in-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/underflowed/text-adventure-game-in-rust" "work/ex/clippy-test-run/sources/stable/gh/underflowed/text-adventure-game-in-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/underflowed/text-adventure-game-in-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/underflowed/text-adventure-game-in-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/underflowed/text-adventure-game-in-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/underflowed/text-adventure-game-in-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 92f6d195657fbe6423ea03a835a421fc37b668ef [INFO] sha for GitHub repo underflowed/text-adventure-game-in-rust: 92f6d195657fbe6423ea03a835a421fc37b668ef [INFO] validating manifest of underflowed/text-adventure-game-in-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of underflowed/text-adventure-game-in-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing underflowed/text-adventure-game-in-rust [INFO] finished frobbing underflowed/text-adventure-game-in-rust [INFO] frobbed toml for underflowed/text-adventure-game-in-rust written to work/ex/clippy-test-run/sources/stable/gh/underflowed/text-adventure-game-in-rust/Cargo.toml [INFO] started frobbing underflowed/text-adventure-game-in-rust [INFO] finished frobbing underflowed/text-adventure-game-in-rust [INFO] frobbed toml for underflowed/text-adventure-game-in-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/underflowed/text-adventure-game-in-rust/Cargo.toml [INFO] crate underflowed/text-adventure-game-in-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting underflowed/text-adventure-game-in-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/underflowed/text-adventure-game-in-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f000186ef8aed01c39b9a0f00b4754ad2c8221eece68788536db14df6141825 [INFO] running `"docker" "start" "-a" "1f000186ef8aed01c39b9a0f00b4754ad2c8221eece68788536db14df6141825"` [INFO] [stderr] Checking text_adventure v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: All variants have the same prefix: `Move` [INFO] [stderr] --> src/main.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | / enum Event { [INFO] [stderr] 58 | | MoveUp, [INFO] [stderr] 59 | | MoveLeft, [INFO] [stderr] 60 | | MoveDown, [INFO] [stderr] 61 | | MoveRight, [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | return Event::MoveLeft; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Event::MoveLeft` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_string` [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | fn to_string(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MoveUp` [INFO] [stderr] --> src/main.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | MoveUp, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MoveDown` [INFO] [stderr] --> src/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | MoveDown, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | let ref mut room = map[y as usize][x as usize]; [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------- help: try: `let room = &mut map[y as usize][x as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Move` [INFO] [stderr] --> src/main.rs:57:1 [INFO] [stderr] | [INFO] [stderr] 57 | / enum Event { [INFO] [stderr] 58 | | MoveUp, [INFO] [stderr] 59 | | MoveLeft, [INFO] [stderr] 60 | | MoveDown, [INFO] [stderr] 61 | | MoveRight, [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | return Event::MoveLeft; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Event::MoveLeft` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_string` [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | fn to_string(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MoveUp` [INFO] [stderr] --> src/main.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | MoveUp, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MoveDown` [INFO] [stderr] --> src/main.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | MoveDown, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | let ref mut room = map[y as usize][x as usize]; [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------- help: try: `let room = &mut map[y as usize][x as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.50s [INFO] running `"docker" "inspect" "1f000186ef8aed01c39b9a0f00b4754ad2c8221eece68788536db14df6141825"` [INFO] running `"docker" "rm" "-f" "1f000186ef8aed01c39b9a0f00b4754ad2c8221eece68788536db14df6141825"` [INFO] [stdout] 1f000186ef8aed01c39b9a0f00b4754ad2c8221eece68788536db14df6141825