[INFO] updating cached repository unclenachoduh/basic_ftl-parser-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/unclenachoduh/basic_ftl-parser-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/unclenachoduh/basic_ftl-parser-rs" "work/ex/clippy-test-run/sources/stable/gh/unclenachoduh/basic_ftl-parser-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/unclenachoduh/basic_ftl-parser-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/unclenachoduh/basic_ftl-parser-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unclenachoduh/basic_ftl-parser-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unclenachoduh/basic_ftl-parser-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a39a146e274344a9915aa06b17e532322cad4883 [INFO] sha for GitHub repo unclenachoduh/basic_ftl-parser-rs: a39a146e274344a9915aa06b17e532322cad4883 [INFO] validating manifest of unclenachoduh/basic_ftl-parser-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unclenachoduh/basic_ftl-parser-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unclenachoduh/basic_ftl-parser-rs [INFO] finished frobbing unclenachoduh/basic_ftl-parser-rs [INFO] frobbed toml for unclenachoduh/basic_ftl-parser-rs written to work/ex/clippy-test-run/sources/stable/gh/unclenachoduh/basic_ftl-parser-rs/Cargo.toml [INFO] started frobbing unclenachoduh/basic_ftl-parser-rs [INFO] finished frobbing unclenachoduh/basic_ftl-parser-rs [INFO] frobbed toml for unclenachoduh/basic_ftl-parser-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/unclenachoduh/basic_ftl-parser-rs/Cargo.toml [INFO] crate unclenachoduh/basic_ftl-parser-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unclenachoduh/basic_ftl-parser-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/unclenachoduh/basic_ftl-parser-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e9a9c9977f5fb12d042acbe92fe074ce707a5ceb34bf72d8a9ce9d732e2fa706 [INFO] running `"docker" "start" "-a" "e9a9c9977f5fb12d042acbe92fe074ce707a5ceb34bf72d8a9ce9d732e2fa706"` [INFO] [stderr] Checking libc v0.2.42 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking ftl_parser-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | let split = contents.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:39:6 [INFO] [stderr] | [INFO] [stderr] 39 | counter = 1 + counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | if &ch == &op.to_string().remove(0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 72 | if ch == op.to_string().remove(0) { [INFO] [stderr] | ^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:79:10 [INFO] [stderr] | [INFO] [stderr] 79 | if op_check == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!op_check` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | let split = contents.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:39:6 [INFO] [stderr] | [INFO] [stderr] 39 | counter = 1 + counter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | if &ch == &op.to_string().remove(0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 72 | if ch == op.to_string().remove(0) { [INFO] [stderr] | ^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:79:10 [INFO] [stderr] | [INFO] [stderr] 79 | if op_check == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!op_check` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.25s [INFO] running `"docker" "inspect" "e9a9c9977f5fb12d042acbe92fe074ce707a5ceb34bf72d8a9ce9d732e2fa706"` [INFO] running `"docker" "rm" "-f" "e9a9c9977f5fb12d042acbe92fe074ce707a5ceb34bf72d8a9ce9d732e2fa706"` [INFO] [stdout] e9a9c9977f5fb12d042acbe92fe074ce707a5ceb34bf72d8a9ce9d732e2fa706