[INFO] updating cached repository umurgdk/jsg
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/umurgdk/jsg
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/umurgdk/jsg" "work/ex/clippy-test-run/sources/stable/gh/umurgdk/jsg"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/umurgdk/jsg'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/umurgdk/jsg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/umurgdk/jsg"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/umurgdk/jsg'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] bf8c8e9e523b23e2b874494bfe27757f102fe4ad
[INFO] sha for GitHub repo umurgdk/jsg: bf8c8e9e523b23e2b874494bfe27757f102fe4ad
[INFO] validating manifest of umurgdk/jsg on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of umurgdk/jsg on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing umurgdk/jsg
[INFO] finished frobbing umurgdk/jsg
[INFO] frobbed toml for umurgdk/jsg written to work/ex/clippy-test-run/sources/stable/gh/umurgdk/jsg/Cargo.toml
[INFO] started frobbing umurgdk/jsg
[INFO] finished frobbing umurgdk/jsg
[INFO] frobbed toml for umurgdk/jsg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/umurgdk/jsg/Cargo.toml
[INFO] crate umurgdk/jsg has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting umurgdk/jsg against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/umurgdk/jsg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f37f941d447003067b826f33a8b8757e98593c69082c61570020b3bfbf6663a0
[INFO] running `"docker" "start" "-a" "f37f941d447003067b826f33a8b8757e98593c69082c61570020b3bfbf6663a0"`
[INFO] [stderr]    Compiling serde v1.0.66
[INFO] [stderr]     Checking serde_json v1.0.21
[INFO] [stderr]     Checking jsg v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:9:15
[INFO] [stderr]   |
[INFO] [stderr] 9 | const USAGE: &'static str = "USAGE: jsg name=jsg num=25 num_as_str=\"25\" arr=\"$(jsg --arr 1 string 3)\" obj=\"$(jsg field=value)\" bool=false another=null";
[INFO] [stderr]   |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:9:15
[INFO] [stderr]   |
[INFO] [stderr] 9 | const USAGE: &'static str = "USAGE: jsg name=jsg num=25 num_as_str=\"25\" arr=\"$(jsg --arr 1 string 3)\" obj=\"$(jsg field=value)\" bool=false another=null";
[INFO] [stderr]   |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]   --> src/main.rs:12:21
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let first_arg = env::args().skip(1).next();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:72:12
[INFO] [stderr]    |
[INFO] [stderr] 72 |         if val_part.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `val_part.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:73:24
[INFO] [stderr]    |
[INFO] [stderr] 73 |             return Err(format!("field value can't be empty").into());
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"field value can't be empty".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:77:12
[INFO] [stderr]    |
[INFO] [stderr] 77 |         if key_part.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `key_part.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:78:24
[INFO] [stderr]    |
[INFO] [stderr] 78 |             return Err(format!("field name can't be empty").into());
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"field name can't be empty".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]   --> src/main.rs:12:21
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let first_arg = env::args().skip(1).next();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:72:12
[INFO] [stderr]    |
[INFO] [stderr] 72 |         if val_part.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `val_part.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:73:24
[INFO] [stderr]    |
[INFO] [stderr] 73 |             return Err(format!("field value can't be empty").into());
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"field value can't be empty".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:77:12
[INFO] [stderr]    |
[INFO] [stderr] 77 |         if key_part.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `key_part.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:78:24
[INFO] [stderr]    |
[INFO] [stderr] 78 |             return Err(format!("field name can't be empty").into());
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"field name can't be empty".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 16.07s
[INFO] running `"docker" "inspect" "f37f941d447003067b826f33a8b8757e98593c69082c61570020b3bfbf6663a0"`
[INFO] running `"docker" "rm" "-f" "f37f941d447003067b826f33a8b8757e98593c69082c61570020b3bfbf6663a0"`
[INFO] [stdout] f37f941d447003067b826f33a8b8757e98593c69082c61570020b3bfbf6663a0