[INFO] updating cached repository ul/kak-lsp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ul/kak-lsp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ul/kak-lsp" "work/ex/clippy-test-run/sources/stable/gh/ul/kak-lsp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ul/kak-lsp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ul/kak-lsp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ul/kak-lsp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ul/kak-lsp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b36293c509d05c39b1a469d1f01e9a611e64da3d [INFO] sha for GitHub repo ul/kak-lsp: b36293c509d05c39b1a469d1f01e9a611e64da3d [INFO] validating manifest of ul/kak-lsp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ul/kak-lsp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ul/kak-lsp [INFO] finished frobbing ul/kak-lsp [INFO] frobbed toml for ul/kak-lsp written to work/ex/clippy-test-run/sources/stable/gh/ul/kak-lsp/Cargo.toml [INFO] started frobbing ul/kak-lsp [INFO] finished frobbing ul/kak-lsp [INFO] frobbed toml for ul/kak-lsp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ul/kak-lsp/Cargo.toml [INFO] crate ul/kak-lsp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ul/kak-lsp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ul/kak-lsp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb11b8a8c6773549a6a38566294f08086821c1bdc3f8b491402a0f4a7cdf8ba6 [INFO] running `"docker" "start" "-a" "bb11b8a8c6773549a6a38566294f08086821c1bdc3f8b491402a0f4a7cdf8ba6"` [INFO] [stderr] Compiling slog v2.4.1 [INFO] [stderr] Checking crossbeam v0.2.12 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Compiling pest v1.0.6 [INFO] [stderr] Checking daemonize v0.3.0 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking memchr v2.1.0 [INFO] [stderr] Compiling syn v0.15.13 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking slog-scope v4.0.1 [INFO] [stderr] Checking slog-async v2.3.0 [INFO] [stderr] Checking slog-stdlog v3.0.2 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Compiling pest_derive v1.0.8 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking slog-kvfilter v0.7.0 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Compiling trackable_derive v0.1.1 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking trackable v0.2.20 [INFO] [stderr] Checking jsonrpc-core v8.0.1 [INFO] [stderr] Checking sloggers v0.3.1 [INFO] [stderr] Checking languageserver-types v0.51.0 [INFO] [stderr] Checking kak-lsp v5.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/language_features/ccls.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return params; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `params` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/language_features/ccls.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return params; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `params` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/session.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | / if controllers.contains_key(&route) { [INFO] [stderr] 120 | | let controller = &controllers[&route]; [INFO] [stderr] 121 | | if let Some(sender) = controller.sender.as_ref() { [INFO] [stderr] 122 | | sender.send(request); [INFO] [stderr] ... | [INFO] [stderr] 131 | | controllers.insert(route, controller); [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ help: consider using: `controllers.entry(route)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/session.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | / if controllers.contains_key(&route) { [INFO] [stderr] 120 | | let controller = &controllers[&route]; [INFO] [stderr] 121 | | if let Some(sender) = controller.sender.as_ref() { [INFO] [stderr] 122 | | sender.send(request); [INFO] [stderr] ... | [INFO] [stderr] 131 | | controllers.insert(route, controller); [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ help: consider using: `controllers.entry(route)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 48.00s [INFO] running `"docker" "inspect" "bb11b8a8c6773549a6a38566294f08086821c1bdc3f8b491402a0f4a7cdf8ba6"` [INFO] running `"docker" "rm" "-f" "bb11b8a8c6773549a6a38566294f08086821c1bdc3f8b491402a0f4a7cdf8ba6"` [INFO] [stdout] bb11b8a8c6773549a6a38566294f08086821c1bdc3f8b491402a0f4a7cdf8ba6