[INFO] updating cached repository ukabuer/path-tracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ukabuer/path-tracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ukabuer/path-tracer" "work/ex/clippy-test-run/sources/stable/gh/ukabuer/path-tracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ukabuer/path-tracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ukabuer/path-tracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ukabuer/path-tracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ukabuer/path-tracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a07e9837bd9edaa55e211f23a033cf3e6601c059 [INFO] sha for GitHub repo ukabuer/path-tracer: a07e9837bd9edaa55e211f23a033cf3e6601c059 [INFO] validating manifest of ukabuer/path-tracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ukabuer/path-tracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ukabuer/path-tracer [INFO] finished frobbing ukabuer/path-tracer [INFO] frobbed toml for ukabuer/path-tracer written to work/ex/clippy-test-run/sources/stable/gh/ukabuer/path-tracer/Cargo.toml [INFO] started frobbing ukabuer/path-tracer [INFO] finished frobbing ukabuer/path-tracer [INFO] frobbed toml for ukabuer/path-tracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ukabuer/path-tracer/Cargo.toml [INFO] crate ukabuer/path-tracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ukabuer/path-tracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ukabuer/path-tracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29730441b3550608cdda8d497f199c150a242e01469a2623578d88363b873ce4 [INFO] running `"docker" "start" "-a" "29730441b3550608cdda8d497f199c150a242e01469a2623578d88363b873ce4"` [INFO] [stderr] Checking deflate v0.7.18 [INFO] [stderr] Compiling quote v0.6.5 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rayon v1.0.2 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking path-tracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/hitable.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | for i in 0..self.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 23 | for in &self { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/hitable.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | / match self[i].hit(r, tmin, closet_so_far) { [INFO] [stderr] 25 | | Some(record) => { [INFO] [stderr] 26 | | closet_so_far = record.t; [INFO] [stderr] 27 | | result = Some(record); [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | _ => (), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | if let Some(record) = self[i].hit(r, tmin, closet_so_far) { [INFO] [stderr] 25 | closet_so_far = record.t; [INFO] [stderr] 26 | result = Some(record); [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `self`. [INFO] [stderr] --> src/hitable.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | for i in 0..self.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 23 | for in &self { [INFO] [stderr] | ^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/hitable.rs:24:7 [INFO] [stderr] | [INFO] [stderr] 24 | / match self[i].hit(r, tmin, closet_so_far) { [INFO] [stderr] 25 | | Some(record) => { [INFO] [stderr] 26 | | closet_so_far = record.t; [INFO] [stderr] 27 | | result = Some(record); [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | _ => (), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 24 | if let Some(record) = self[i].hit(r, tmin, closet_so_far) { [INFO] [stderr] 25 | closet_so_far = record.t; [INFO] [stderr] 26 | result = Some(record); [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.20s [INFO] running `"docker" "inspect" "29730441b3550608cdda8d497f199c150a242e01469a2623578d88363b873ce4"` [INFO] running `"docker" "rm" "-f" "29730441b3550608cdda8d497f199c150a242e01469a2623578d88363b873ce4"` [INFO] [stdout] 29730441b3550608cdda8d497f199c150a242e01469a2623578d88363b873ce4