[INFO] updating cached repository uiureo/nm
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/uiureo/nm
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/uiureo/nm" "work/ex/clippy-test-run/sources/stable/gh/uiureo/nm"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/uiureo/nm'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/uiureo/nm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uiureo/nm"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uiureo/nm'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d32bf88e47403c51ce10377e1d20e1b72aeef453
[INFO] sha for GitHub repo uiureo/nm: d32bf88e47403c51ce10377e1d20e1b72aeef453
[INFO] validating manifest of uiureo/nm on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of uiureo/nm on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing uiureo/nm
[INFO] finished frobbing uiureo/nm
[INFO] frobbed toml for uiureo/nm written to work/ex/clippy-test-run/sources/stable/gh/uiureo/nm/Cargo.toml
[INFO] started frobbing uiureo/nm
[INFO] finished frobbing uiureo/nm
[INFO] frobbed toml for uiureo/nm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/uiureo/nm/Cargo.toml
[INFO] crate uiureo/nm has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting uiureo/nm against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/uiureo/nm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3ef1784675ab986c83a912443f077ad4e376c53b588e2d6134caeed9f08ec072
[INFO] running `"docker" "start" "-a" "3ef1784675ab986c83a912443f077ad4e376c53b588e2d6134caeed9f08ec072"`
[INFO] [stderr]     Checking libc v0.2.29
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking csv-core v0.1.3
[INFO] [stderr]     Checking csv v1.0.0-beta.4
[INFO] [stderr]     Checking nm v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:56:17
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 id: id,
[INFO] [stderr]    |                 ^^^^^^ help: replace it with: `id`
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:56:17
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 id: id,
[INFO] [stderr]    |                 ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:57:17
[INFO] [stderr]    |
[INFO] [stderr] 57 |                 title: title,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:58:17
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 genres: genres
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `genres`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:57:17
[INFO] [stderr]    |
[INFO] [stderr] 57 |                 title: title,
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: replace it with: `title`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:58:17
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 genres: genres
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^ help: replace it with: `genres`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::prelude::*`
[INFO] [stderr]  --> src/main.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::prelude::*`
[INFO] [stderr]  --> src/main.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `genres`
[INFO] [stderr]   --> src/main.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     fn genres(&self) -> Vec<&str> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:17:27
[INFO] [stderr]    |
[INFO] [stderr] 17 |         self.genres.split("|").collect()
[INFO] [stderr]    |                           ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:66:29
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn similarity(movie_rating: &Vec<&Rating>, movie_rating2: &Vec<&Rating>) -> f32 {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^ help: change this to: `&[&Rating]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:66:59
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn similarity(movie_rating: &Vec<&Rating>, movie_rating2: &Vec<&Rating>) -> f32 {
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^ help: change this to: `&[&Rating]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:91:27
[INFO] [stderr]    |
[INFO] [stderr] 91 | fn find_movie<'a>(movies: &'a Vec<Movie>, movie_id: u32) -> &'a Movie {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^ help: change this to: `&[Movie]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `genres`
[INFO] [stderr]   --> src/main.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     fn genres(&self) -> Vec<&str> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:17:27
[INFO] [stderr]    |
[INFO] [stderr] 17 |         self.genres.split("|").collect()
[INFO] [stderr]    |                           ^^^ help: try using a char instead: `'|'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/main.rs:102:69
[INFO] [stderr]     |
[INFO] [stderr] 102 |         let mut movie_rating = movie_ratings.entry(rating.movie_id).or_insert(vec![]);
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:66:29
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn similarity(movie_rating: &Vec<&Rating>, movie_rating2: &Vec<&Rating>) -> f32 {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^ help: change this to: `&[&Rating]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:66:59
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn similarity(movie_rating: &Vec<&Rating>, movie_rating2: &Vec<&Rating>) -> f32 {
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^^ help: change this to: `&[&Rating]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:91:27
[INFO] [stderr]    |
[INFO] [stderr] 91 | fn find_movie<'a>(movies: &'a Vec<Movie>, movie_id: u32) -> &'a Movie {
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^ help: change this to: `&[Movie]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]    --> src/main.rs:102:69
[INFO] [stderr]     |
[INFO] [stderr] 102 |         let mut movie_rating = movie_ratings.entry(rating.movie_id).or_insert(vec![]);
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.71s
[INFO] running `"docker" "inspect" "3ef1784675ab986c83a912443f077ad4e376c53b588e2d6134caeed9f08ec072"`
[INFO] running `"docker" "rm" "-f" "3ef1784675ab986c83a912443f077ad4e376c53b588e2d6134caeed9f08ec072"`
[INFO] [stdout] 3ef1784675ab986c83a912443f077ad4e376c53b588e2d6134caeed9f08ec072