[INFO] updating cached repository udoprog/rust-advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/udoprog/rust-advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/udoprog/rust-advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/udoprog/rust-advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/udoprog/rust-advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/udoprog/rust-advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udoprog/rust-advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udoprog/rust-advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d97d4657a110254256f1585fd6037a2add57612b [INFO] sha for GitHub repo udoprog/rust-advent-of-code-2018: d97d4657a110254256f1585fd6037a2add57612b [INFO] validating manifest of udoprog/rust-advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of udoprog/rust-advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing udoprog/rust-advent-of-code-2018 [INFO] finished frobbing udoprog/rust-advent-of-code-2018 [INFO] frobbed toml for udoprog/rust-advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/udoprog/rust-advent-of-code-2018/Cargo.toml [INFO] started frobbing udoprog/rust-advent-of-code-2018 [INFO] finished frobbing udoprog/rust-advent-of-code-2018 [INFO] frobbed toml for udoprog/rust-advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udoprog/rust-advent-of-code-2018/Cargo.toml [INFO] crate udoprog/rust-advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting udoprog/rust-advent-of-code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/udoprog/rust-advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2d9b1df2d554feae36809a1a88777b9941bb8aa16644183ff8a660b67a38340a [INFO] running `"docker" "start" "-a" "2d9b1df2d554feae36809a1a88777b9941bb8aa16644183ff8a660b67a38340a"` [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-bigint v0.2.1 [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Compiling matrixmultiply v0.1.15 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Checking libm v0.1.2 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Compiling ncurses v5.97.0 [INFO] [stderr] Checking hashbrown v0.1.7 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking backtrace-sys v0.1.24 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking generic-array v0.11.1 [INFO] [stderr] Compiling syn v0.15.22 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking approx v0.3.0 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Checking nalgebra v0.16.11 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking aoc2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | .ok_or_else(|| format!("missing column")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing column".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | self.value.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | self.value.clone().map(|(mn, mx)| mx - mn) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | / self.value [INFO] [stderr] 280 | | .clone() [INFO] [stderr] | |____________________^ help: try removing the `clone` call: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | .ok_or_else(|| format!("missing column")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"missing column".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | self.value.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | self.value.clone().map(|(mn, mx)| mx - mn) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | / self.value [INFO] [stderr] 280 | | .clone() [INFO] [stderr] | |____________________^ help: try removing the `clone` call: `self.value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/day9.rs:176:17 [INFO] [stderr] | [INFO] [stderr] 176 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/day9.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return scores.iter().max_by(|a, b| a.1.cmp(&b.1)).map(|e| *e.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `scores.iter().max_by(|a, b| a.1.cmp(&b.1)).map(|e| *e.1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day9.rs:71:37 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(game(13, 7999), Some(146373)); [INFO] [stderr] | ^^^^^^ help: consider: `146_373` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day9.rs:72:44 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(unsafe_game(13, 7999), Some(146373)); [INFO] [stderr] | ^^^^^^ help: consider: `146_373` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day9.rs:84:51 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(game(players, highest_score), Some(439341)); [INFO] [stderr] | ^^^^^^ help: consider: `439_341` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day9.rs:85:58 [INFO] [stderr] | [INFO] [stderr] 85 | assert_eq!(unsafe_game(players, highest_score), Some(439341)); [INFO] [stderr] | ^^^^^^ help: consider: `439_341` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day9.rs:89:64 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(unsafe_game(players, highest_score * 100), Some(3566801385)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_566_801_385` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day14.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | let input = 209231; [INFO] [stderr] | ^^^^^^ help: consider: `209_231` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day14.rs:89:30 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(part2(input), 20191616); [INFO] [stderr] | ^^^^^^^^ help: consider: `20_191_616` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day3.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | assert_eq!(duplicates, 104712); [INFO] [stderr] | ^^^^^^ help: consider: `104_712` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/day5.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | polar [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/day5.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | let polar = b.is_uppercase() && b.to_lowercase().next() == Some(a) [INFO] [stderr] | _________________^ [INFO] [stderr] 5 | | || a.is_uppercase() && a.to_lowercase().next() == Some(b); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/bin/day5.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | polar [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/bin/day5.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | let polar = b.is_uppercase() && b.to_lowercase().next() == Some(a) [INFO] [stderr] | _________________^ [INFO] [stderr] 5 | | || a.is_uppercase() && a.to_lowercase().next() == Some(b); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/day9.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | cur = cur - 7; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `cur -= 7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/day9.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | cur = cur - circle.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur -= circle.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day9.rs:64:47 [INFO] [stderr] | [INFO] [stderr] 64 | let mut it = input_str!("day9.txt").split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/bin/day9.rs:192:12 [INFO] [stderr] | [INFO] [stderr] 192 | if self.0 == ptr::null_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/day6.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | queue.extend(neigh(c).into_iter().map(|c| (*c, d + 1))); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/day6.rs:159:35 [INFO] [stderr] | [INFO] [stderr] 159 | queue.extend(neigh(c).into_iter()); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `aoc2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day12.rs:211:38 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(calculate(&state, &m, 50000000000), 4049999998575); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `50_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/day12.rs:211:52 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(calculate(&state, &m, 50000000000), 4049999998575); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `4_049_999_998_575` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/day16.rs:284:20 [INFO] [stderr] | [INFO] [stderr] 284 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 285 | | if let Some(codes) = registry.0.get_mut(&test.inst.op_code) { [INFO] [stderr] 286 | | codes.remove(&op); [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 284 | } else if let Some(codes) = registry.0.get_mut(&test.inst.op_code) { [INFO] [stderr] 285 | codes.remove(&op); [INFO] [stderr] 286 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/bin/day12.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | / match self.0.contains(&i) { [INFO] [stderr] 12 | | true => '#'.fmt(fmt)?, [INFO] [stderr] 13 | | false => '.'.fmt(fmt)?, [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if self.0.contains(&i) { '#'.fmt(fmt)? } else { '.'.fmt(fmt)? }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/bin/day12.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | / match b { [INFO] [stderr] 28 | | true => '#'.fmt(fmt)?, [INFO] [stderr] 29 | | false => '.'.fmt(fmt)?, [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if b { '#'.fmt(fmt)? } else { '.'.fmt(fmt)? }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/day16.rs:284:20 [INFO] [stderr] | [INFO] [stderr] 284 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 285 | | if let Some(codes) = registry.0.get_mut(&test.inst.op_code) { [INFO] [stderr] 286 | | codes.remove(&op); [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 284 | } else if let Some(codes) = registry.0.get_mut(&test.inst.op_code) { [INFO] [stderr] 285 | codes.remove(&op); [INFO] [stderr] 286 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/day12.rs:72:39 [INFO] [stderr] | [INFO] [stderr] 72 | [-2, -1, 0, 1, 2].into_iter().all(|t| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `aoc2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day4.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/bin/day2.rs:49:38 [INFO] [stderr] | [INFO] [stderr] 49 | .flat_map(|k| counts.get(&k)) [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 50 | | .fold(1, |a, b| a * b); [INFO] [stderr] | |______________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/day2.rs:48:10 [INFO] [stderr] | [INFO] [stderr] 48 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `aoc2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day16.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | fn apply(&self, d: &mut Device, inputs: &[u64; 2], o: u64) -> Result<(), Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day16.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | let mut it = state.split(" ").flat_map(|d| str::parse(d).ok()); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/day16.rs:455:14 [INFO] [stderr] | [INFO] [stderr] 455 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `aoc2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/day16.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | fn apply(&self, d: &mut Device, inputs: &[u64; 2], o: u64) -> Result<(), Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/day16.rs:160:34 [INFO] [stderr] | [INFO] [stderr] 160 | let mut it = state.split(" ").flat_map(|d| str::parse(d).ok()); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bin/day16.rs:455:14 [INFO] [stderr] | [INFO] [stderr] 455 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `aoc2018`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2d9b1df2d554feae36809a1a88777b9941bb8aa16644183ff8a660b67a38340a"` [INFO] running `"docker" "rm" "-f" "2d9b1df2d554feae36809a1a88777b9941bb8aa16644183ff8a660b67a38340a"` [INFO] [stdout] 2d9b1df2d554feae36809a1a88777b9941bb8aa16644183ff8a660b67a38340a