[INFO] updating cached repository udoprog/quickcfg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/udoprog/quickcfg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/udoprog/quickcfg" "work/ex/clippy-test-run/sources/stable/gh/udoprog/quickcfg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/udoprog/quickcfg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/udoprog/quickcfg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udoprog/quickcfg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udoprog/quickcfg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cad415502f1ad9ab201c1d1cb197d62c7a1f032d [INFO] sha for GitHub repo udoprog/quickcfg: cad415502f1ad9ab201c1d1cb197d62c7a1f032d [INFO] validating manifest of udoprog/quickcfg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of udoprog/quickcfg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing udoprog/quickcfg [INFO] finished frobbing udoprog/quickcfg [INFO] frobbed toml for udoprog/quickcfg written to work/ex/clippy-test-run/sources/stable/gh/udoprog/quickcfg/Cargo.toml [INFO] started frobbing udoprog/quickcfg [INFO] finished frobbing udoprog/quickcfg [INFO] frobbed toml for udoprog/quickcfg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/udoprog/quickcfg/Cargo.toml [INFO] crate udoprog/quickcfg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting udoprog/quickcfg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/udoprog/quickcfg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e0c69a9716cfd116663d9489624cea8da626ccf607dd62036dbcaa1e45817f7 [INFO] running `"docker" "start" "-a" "1e0c69a9716cfd116663d9489624cea8da626ccf607dd62036dbcaa1e45817f7"` [INFO] [stderr] Compiling rand_core v0.3.0 [INFO] [stderr] Compiling openssl v0.10.15 [INFO] [stderr] Compiling ucd-trie v0.1.1 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling maplit v1.0.1 [INFO] [stderr] Compiling regex v1.0.6 [INFO] [stderr] Checking string v0.1.2 [INFO] [stderr] Checking indexmap v1.0.2 [INFO] [stderr] Compiling native-tls v0.2.2 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Compiling encoding_rs v0.8.12 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling openssl-sys v0.9.39 [INFO] [stderr] Checking regex-syntax v0.6.3 [INFO] [stderr] Compiling rand_core v0.2.2 [INFO] [stderr] Checking yaml-rust v0.4.2 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Compiling pest v2.0.2 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Compiling rand v0.5.5 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking relative-path v0.4.0 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking http v0.1.14 [INFO] [stderr] Checking serde_yaml v0.8.7 [INFO] [stderr] Compiling phf_shared v0.7.23 [INFO] [stderr] Checking mime v0.3.12 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking crossbeam-deque v0.6.2 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Compiling pest_meta v2.0.3 [INFO] [stderr] Checking libflate v0.1.18 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking phf v0.7.23 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Compiling pest_generator v2.0.0 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking pretty_env_logger v0.2.5 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Compiling pest_derive v2.0.1 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking quickcfg v0.3.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packages/python.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packages/python.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/facts.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | pub const DISTRO: &'static str = "distro"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_system.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:54:27 [INFO] [stderr] | [INFO] [stderr] 54 | Ok(output) => return Ok(output.status.success()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output.status.success())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | _ => return Err(e.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hierarchy.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | const HEADER: &'static str = "quickcfg:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hierarchy.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return Ok(m); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hierarchy.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | Value::Mapping(m) => return Ok(m), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packages.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | return Ok(Provider { default }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Provider { default })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/copy_dir.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/download_and_run.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/git_sync.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/install_packages.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/link_dir.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/facts.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | pub const DISTRO: &'static str = "distro"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_system.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:54:27 [INFO] [stderr] | [INFO] [stderr] 54 | Ok(output) => return Ok(output.status.success()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output.status.success())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | _ => return Err(e.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hierarchy.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | const HEADER: &'static str = "quickcfg:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hierarchy.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return Ok(m); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hierarchy.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | Value::Mapping(m) => return Ok(m), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packages.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | return Ok(Provider { default }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Provider { default })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/copy_dir.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/download_and_run.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/git_sync.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/install_packages.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/link_dir.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/command.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/environment.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | impl Environment for &HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 28 | impl Environment for &HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/file_system.rs:169:24 [INFO] [stderr] | [INFO] [stderr] 169 | let mut unit = match template { [INFO] [stderr] | ________________________^ [INFO] [stderr] 170 | | true => self.allocator.unit(CopyTemplate { [INFO] [stderr] 171 | | from: from.to_owned(), [INFO] [stderr] 172 | | from_modified, [INFO] [stderr] ... | [INFO] [stderr] 180 | | }), [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 169 | let mut unit = if template { self.allocator.unit(CopyTemplate { [INFO] [stderr] 170 | from: from.to_owned(), [INFO] [stderr] 171 | from_modified, [INFO] [stderr] 172 | to: to.to_owned(), [INFO] [stderr] 173 | to_exists: to_meta.is_some(), [INFO] [stderr] 174 | }) } else { self.allocator.unit(CopyFile { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/file_system.rs:213:23 [INFO] [stderr] | [INFO] [stderr] 213 | dirs.push(c.clone()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 213 | dirs.push(&(*c).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 213 | dirs.push(&std::path::Path::clone(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_system.rs:366:51 [INFO] [stderr] | [INFO] [stderr] 366 | let accessed = FileTime::from_system_time(timestamp.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_system.rs:367:24 [INFO] [stderr] | [INFO] [stderr] 367 | let modified = accessed.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `accessed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/file_system.rs:400:24 [INFO] [stderr] | [INFO] [stderr] 400 | let modified = match template { [INFO] [stderr] | ________________________^ [INFO] [stderr] 401 | | // use the modification time of the hierarchy if modified more recently. [INFO] [stderr] 402 | | true => match self.data.last_modified.as_ref() { [INFO] [stderr] 403 | | Some(data_modified) if from_modified < *data_modified => data_modified, [INFO] [stderr] ... | [INFO] [stderr] 406 | | false => &from_modified, [INFO] [stderr] 407 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 400 | let modified = if template { match self.data.last_modified.as_ref() { [INFO] [stderr] 401 | Some(data_modified) if from_modified < *data_modified => data_modified, [INFO] [stderr] 402 | _ => &from_modified, [INFO] [stderr] 403 | } } else { &from_modified }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_system.rs:410:28 [INFO] [stderr] | [INFO] [stderr] 410 | return Ok(Some(modified.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*modified` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:78:35 [INFO] [stderr] | [INFO] [stderr] 78 | for line in content.split("\n").take(5) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:86:36 [INFO] [stderr] | [INFO] [stderr] 86 | for part in spec.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:93:45 [INFO] [stderr] | [INFO] [stderr] 93 | let mut it = part.splitn(2, ":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/cargo.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/debian.rs:82:37 [INFO] [stderr] | [INFO] [stderr] 82 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/python.rs:46:37 [INFO] [stderr] | [INFO] [stderr] 46 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/ruby.rs:60:37 [INFO] [stderr] | [INFO] [stderr] 60 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/state.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn to_state<'a>(self, config: &'a Config, now: &'a SystemTime) -> State<'a> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/copy_dir.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / system_struct! { [INFO] [stderr] 11 | | CopyDir { [INFO] [stderr] 12 | | #[doc="Where to copy from."] [INFO] [stderr] 13 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/copy_dir.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / system_struct! { [INFO] [stderr] 11 | | CopyDir { [INFO] [stderr] 12 | | #[doc="Where to copy from."] [INFO] [stderr] 13 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/download_and_run.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / system_struct! { [INFO] [stderr] 13 | | DownloadAndRun { [INFO] [stderr] 14 | | #[doc="URL to download."] [INFO] [stderr] 15 | | pub url: String, [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/download_and_run.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / system_struct! { [INFO] [stderr] 13 | | DownloadAndRun { [INFO] [stderr] 14 | | #[doc="URL to download."] [INFO] [stderr] 15 | | pub url: String, [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/git_sync.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / system_struct! { [INFO] [stderr] 16 | | GitSync { [INFO] [stderr] 17 | | #[doc="Path to check out the repo."] [INFO] [stderr] 18 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/git_sync.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / system_struct! { [INFO] [stderr] 16 | | GitSync { [INFO] [stderr] 17 | | #[doc="Path to check out the repo."] [INFO] [stderr] 18 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/install_packages.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / system_struct! { [INFO] [stderr] 13 | | InstallPackages { [INFO] [stderr] 14 | | #[doc="Hierarchy key to lookup for packages to install."] [INFO] [stderr] 15 | | #[serde(default = "default_key")] [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/install_packages.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / system_struct! { [INFO] [stderr] 13 | | InstallPackages { [INFO] [stderr] 14 | | #[doc="Hierarchy key to lookup for packages to install."] [INFO] [stderr] 15 | | #[serde(default = "default_key")] [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | Link { [INFO] [stderr] 11 | | #[doc="Where to create the symlink."] [INFO] [stderr] 12 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | Link { [INFO] [stderr] 11 | | #[doc="Where to create the symlink."] [INFO] [stderr] 12 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/command.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link_dir.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | LinkDir { [INFO] [stderr] 11 | | #[doc="Where to link files from."] [INFO] [stderr] 12 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link_dir.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | LinkDir { [INFO] [stderr] 11 | | #[doc="Where to link files from."] [INFO] [stderr] 12 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/template.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn var<'s>( [INFO] [stderr] 97 | | input: &'s str, [INFO] [stderr] 98 | | mut it: impl Iterator, [INFO] [stderr] 99 | | ) -> Result<(usize, &'s str), Error> { [INFO] [stderr] ... | [INFO] [stderr] 109 | | bail!("missing closing '}'") [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/template.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / fn environ<'s>( [INFO] [stderr] 113 | | input: &'s str, [INFO] [stderr] 114 | | mut it: impl Iterator, [INFO] [stderr] 115 | | ) -> Result<(usize, &'s str), Error> { [INFO] [stderr] ... | [INFO] [stderr] 126 | | Ok((input.len(), &input[start..])) [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/template.rs:118:42 [INFO] [stderr] | [INFO] [stderr] 118 | while let Some((index, c)) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for (index, c) in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/environment.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | impl Environment for &HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 28 | impl Environment for &HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/file_system.rs:169:24 [INFO] [stderr] | [INFO] [stderr] 169 | let mut unit = match template { [INFO] [stderr] | ________________________^ [INFO] [stderr] 170 | | true => self.allocator.unit(CopyTemplate { [INFO] [stderr] 171 | | from: from.to_owned(), [INFO] [stderr] 172 | | from_modified, [INFO] [stderr] ... | [INFO] [stderr] 180 | | }), [INFO] [stderr] 181 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 169 | let mut unit = if template { self.allocator.unit(CopyTemplate { [INFO] [stderr] 170 | from: from.to_owned(), [INFO] [stderr] 171 | from_modified, [INFO] [stderr] 172 | to: to.to_owned(), [INFO] [stderr] 173 | to_exists: to_meta.is_some(), [INFO] [stderr] 174 | }) } else { self.allocator.unit(CopyFile { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/file_system.rs:213:23 [INFO] [stderr] | [INFO] [stderr] 213 | dirs.push(c.clone()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 213 | dirs.push(&(*c).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 213 | dirs.push(&std::path::Path::clone(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_system.rs:366:51 [INFO] [stderr] | [INFO] [stderr] 366 | let accessed = FileTime::from_system_time(timestamp.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_system.rs:367:24 [INFO] [stderr] | [INFO] [stderr] 367 | let modified = accessed.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `accessed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/file_system.rs:400:24 [INFO] [stderr] | [INFO] [stderr] 400 | let modified = match template { [INFO] [stderr] | ________________________^ [INFO] [stderr] 401 | | // use the modification time of the hierarchy if modified more recently. [INFO] [stderr] 402 | | true => match self.data.last_modified.as_ref() { [INFO] [stderr] 403 | | Some(data_modified) if from_modified < *data_modified => data_modified, [INFO] [stderr] ... | [INFO] [stderr] 406 | | false => &from_modified, [INFO] [stderr] 407 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 400 | let modified = if template { match self.data.last_modified.as_ref() { [INFO] [stderr] 401 | Some(data_modified) if from_modified < *data_modified => data_modified, [INFO] [stderr] 402 | _ => &from_modified, [INFO] [stderr] 403 | } } else { &from_modified }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_system.rs:410:28 [INFO] [stderr] | [INFO] [stderr] 410 | return Ok(Some(modified.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*modified` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:78:35 [INFO] [stderr] | [INFO] [stderr] 78 | for line in content.split("\n").take(5) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:86:36 [INFO] [stderr] | [INFO] [stderr] 86 | for part in spec.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:93:45 [INFO] [stderr] | [INFO] [stderr] 93 | let mut it = part.splitn(2, ":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: Could not compile `quickcfg`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/cargo.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/debian.rs:82:37 [INFO] [stderr] | [INFO] [stderr] 82 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/python.rs:46:37 [INFO] [stderr] | [INFO] [stderr] 46 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/ruby.rs:60:37 [INFO] [stderr] | [INFO] [stderr] 60 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/state.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn to_state<'a>(self, config: &'a Config, now: &'a SystemTime) -> State<'a> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/copy_dir.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / system_struct! { [INFO] [stderr] 11 | | CopyDir { [INFO] [stderr] 12 | | #[doc="Where to copy from."] [INFO] [stderr] 13 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/copy_dir.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | / system_struct! { [INFO] [stderr] 11 | | CopyDir { [INFO] [stderr] 12 | | #[doc="Where to copy from."] [INFO] [stderr] 13 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/download_and_run.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / system_struct! { [INFO] [stderr] 13 | | DownloadAndRun { [INFO] [stderr] 14 | | #[doc="URL to download."] [INFO] [stderr] 15 | | pub url: String, [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/download_and_run.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / system_struct! { [INFO] [stderr] 13 | | DownloadAndRun { [INFO] [stderr] 14 | | #[doc="URL to download."] [INFO] [stderr] 15 | | pub url: String, [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/git_sync.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / system_struct! { [INFO] [stderr] 16 | | GitSync { [INFO] [stderr] 17 | | #[doc="Path to check out the repo."] [INFO] [stderr] 18 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/git_sync.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / system_struct! { [INFO] [stderr] 16 | | GitSync { [INFO] [stderr] 17 | | #[doc="Path to check out the repo."] [INFO] [stderr] 18 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/install_packages.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / system_struct! { [INFO] [stderr] 13 | | InstallPackages { [INFO] [stderr] 14 | | #[doc="Hierarchy key to lookup for packages to install."] [INFO] [stderr] 15 | | #[serde(default = "default_key")] [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/install_packages.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / system_struct! { [INFO] [stderr] 13 | | InstallPackages { [INFO] [stderr] 14 | | #[doc="Hierarchy key to lookup for packages to install."] [INFO] [stderr] 15 | | #[serde(default = "default_key")] [INFO] [stderr] ... | [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | Link { [INFO] [stderr] 11 | | #[doc="Where to create the symlink."] [INFO] [stderr] 12 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | Link { [INFO] [stderr] 11 | | #[doc="Where to create the symlink."] [INFO] [stderr] 12 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link_dir.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | LinkDir { [INFO] [stderr] 11 | | #[doc="Where to link files from."] [INFO] [stderr] 12 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/system/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link_dir.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | LinkDir { [INFO] [stderr] 11 | | #[doc="Where to link files from."] [INFO] [stderr] 12 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/template.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / fn var<'s>( [INFO] [stderr] 97 | | input: &'s str, [INFO] [stderr] 98 | | mut it: impl Iterator, [INFO] [stderr] 99 | | ) -> Result<(usize, &'s str), Error> { [INFO] [stderr] ... | [INFO] [stderr] 109 | | bail!("missing closing '}'") [INFO] [stderr] 110 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/template.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | / fn environ<'s>( [INFO] [stderr] 113 | | input: &'s str, [INFO] [stderr] 114 | | mut it: impl Iterator, [INFO] [stderr] 115 | | ) -> Result<(usize, &'s str), Error> { [INFO] [stderr] ... | [INFO] [stderr] 126 | | Ok((input.len(), &input[start..])) [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/template.rs:118:42 [INFO] [stderr] | [INFO] [stderr] 118 | while let Some((index, c)) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for (index, c) in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `quickcfg`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1e0c69a9716cfd116663d9489624cea8da626ccf607dd62036dbcaa1e45817f7"` [INFO] running `"docker" "rm" "-f" "1e0c69a9716cfd116663d9489624cea8da626ccf607dd62036dbcaa1e45817f7"` [INFO] [stdout] 1e0c69a9716cfd116663d9489624cea8da626ccf607dd62036dbcaa1e45817f7